8288980aacb9d7ed5809207856311c5af3c9b830
Files Diff
- Added: 4
- Removed: 1
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type completeState : String to state : TraceState.State in method public TransactionInfoViewModel(transactionId TransactionId, nodes Collection<Node>, links Collection<Link>, recordSet RecordSet, state TraceState.State, logLinkEnable boolean, logButtonName String, logPageUrl String, disableButtonMessage String) in class com.navercorp.pinpoint.web.view.TransactionInfoViewModel | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.web.calltree.span.TraceState from class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Rename Class | 1 | ||
| Rename Class com.navercorp.pinpoint.web.calltree.span.AsyncSpanEventAlign renamed to com.navercorp.pinpoint.web.calltree.span.SpanChunkEventAlign | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.navercorp.pinpoint.web.calltree.span.SpanAligner.SpanIdPair moved and renamed to com.navercorp.pinpoint.web.calltree.span.LongPair | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type key : SpanIdPair to key : LongPair in method private link() : void in class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Change Variable Type key : SpanIdPair to spanIdPairKey : LongPair in method private newSpanToLinkMap(nodeList List<Node>, collectorAcceptTime long) : Map<LongPair,Node> in class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Change Variable Type that : SpanIdPair to that : LongPair in method public equals(o Object) : boolean in class com.navercorp.pinpoint.web.calltree.span.LongPair | From | To | |
| Change Variable Type spanToLinkMap : Map<SpanIdPair,Node> to spanToLinkMap : Map<LongPair,Node> in method private newSpanToLinkMap(nodeList List<Node>, collectorAcceptTime long) : Map<LongPair,Node> in class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Extract Variable | 1 | ||
| Extract Variable depth : int in method private populateSpanEvent(node Node, spanCallTree SpanCallTree, spanEventBoList List<SpanEventBo>, asyncSpanEventMap SpanAsyncEventMap, localAsyncIdBo LocalAsyncIdBo) : void from class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Rename Method | 7 | ||
| Rename Method public getSpanId2() : long renamed to public getFirst() : long in class com.navercorp.pinpoint.web.calltree.span.LongPair | From | To | |
| Rename Method public addAsyncSpanBo(asyncSpanBo SpanChunkBo) : void renamed to public addSpanChunkBo(asyncSpanBo SpanChunkBo) : void in class com.navercorp.pinpoint.common.server.bo.SpanBo | From | To | |
| Rename Method public getSpanId1() : long renamed to public getSecond() : long in class com.navercorp.pinpoint.web.calltree.span.LongPair | From | To | |
| Rename Method public getLastTime() : long renamed to public getEndTime() : long in class com.navercorp.pinpoint.web.calltree.span.SpanEventAlign | From | To | |
| Rename Method private newSpanEventAlign(node Node, spanEventBo SpanEventBo, localAsyncIdBo LocalAsyncIdBo) : SpanEventAlign renamed to private getSpanEventAlign(node Node, spanEventBo SpanEventBo, localAsyncIdBo LocalAsyncIdBo) : Align in class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Rename Method public getLastTime() : long renamed to public getEndTime() : long in class com.navercorp.pinpoint.web.calltree.span.Align | From | To | |
| Rename Method public getLastTime() : long renamed to public getEndTime() : long in class com.navercorp.pinpoint.web.calltree.span.SpanAlign | From | To | |
| Rename Variable | 1 | ||
| Rename Variable key : SpanIdPair to spanIdPairKey : LongPair in method private newSpanToLinkMap(nodeList List<Node>, collectorAcceptTime long) : Map<LongPair,Node> in class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Change Return Type | 3 | ||
| Change Return Type int to TraceState.State in method public getMatchType() : TraceState.State in class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Change Return Type Map<SpanIdPair,Node> to Map<LongPair,Node> in method private newSpanToLinkMap(nodeList List<Node>, collectorAcceptTime long) : Map<LongPair,Node> in class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Change Return Type SpanEventAlign to Align in method private getSpanEventAlign(node Node, spanEventBo SpanEventBo, localAsyncIdBo LocalAsyncIdBo) : Align in class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute asyncSpanChunkBoList : List<SpanChunkBo> to spanChunkBoList : List<SpanChunkBo> in class com.navercorp.pinpoint.common.server.bo.SpanBo | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type completeState : String to completeState : TraceState.State in class com.navercorp.pinpoint.web.view.TransactionInfoViewModel | From | To | |
| Change Attribute Type spanToLinkMap : Map<SpanIdPair,Node> to spanToLinkMap : Map<LongPair,Node> in class com.navercorp.pinpoint.web.calltree.span.SpanAligner | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public newSpanEventAlign(spanEventBo SpanEventBo) : Align extracted from private newSpanEventAlign(node Node, spanEventBo SpanEventBo, localAsyncIdBo LocalAsyncIdBo) : SpanEventAlign in class com.navercorp.pinpoint.web.calltree.span.SpanAligner & moved to class com.navercorp.pinpoint.web.calltree.span.SpanAligner.Node | From | To | |
| Extract And Move Method public getSpanBo() : SpanBo extracted from private populate() : void in class com.navercorp.pinpoint.web.calltree.span.SpanAligner & moved to class com.navercorp.pinpoint.web.calltree.span.SpanAligner.Node | From | To | |
| Extract And Move Method public getSpanBo() : SpanBo extracted from private newSpanToLinkMap(nodeList List<Node>, collectorAcceptTime long) : Map<SpanIdPair,Node> in class com.navercorp.pinpoint.web.calltree.span.SpanAligner & moved to class com.navercorp.pinpoint.web.calltree.span.SpanAligner.Node | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter completeState : String to state : TraceState.State in method public TransactionInfoViewModel(transactionId TransactionId, nodes Collection<Node>, links Collection<Link>, recordSet RecordSet, state TraceState.State, logLinkEnable boolean, logButtonName String, logPageUrl String, disableButtonMessage String) in class com.navercorp.pinpoint.web.view.TransactionInfoViewModel | From | To | |
| Rename Parameter spanId1 : long to first : long in method public LongPair(first long, second long) in class com.navercorp.pinpoint.web.calltree.span.LongPair | From | To | |
| Rename Parameter spanId2 : long to second : long in method public LongPair(first long, second long) in class com.navercorp.pinpoint.web.calltree.span.LongPair | From | To |