pinpoint 83111e1b3fed82f52d6b322a8d9c84a5b13e425c

83111e1b3fed82f52d6b322a8d9c84a5b13e425c

Files Diff

Added: 14
Removed: 1
Renamed: 0
Modified: 22

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	4
Move And Rename Method protected createStorageFactory() : StorageFactory from class com.navercorp.pinpoint.profiler.DefaultAgent to public get() : StorageFactory from class com.navercorp.pinpoint.profiler.context.provider.StorageFactoryProvider	From	To
Move And Rename Method protected createPinpointClientFactory(commandDispatcher CommandDispatcher) : PinpointClientFactory from class com.navercorp.pinpoint.profiler.DefaultAgent to public get() : PinpointClientFactory from class com.navercorp.pinpoint.profiler.context.provider.PinpointClientFactoryProvider	From	To
Move And Rename Method private createTraceContext(enhancedDataSender EnhancedDataSender, idGenerator IdGenerator, activeTraceRepository ActiveTraceRepository, pluginMonitorContext PluginMonitorContext) : TraceContext from class com.navercorp.pinpoint.profiler.DefaultAgent to private newTraceContext(profilerConfig ProfilerConfig, storageFactory StorageFactory, serverMetaDataHolder ServerMetaDataHolder, enhancedDataSender EnhancedDataSender, idGenerator IdGenerator, activeTraceRepository ActiveTraceRepository, pluginMonitorContext PluginMonitorContext) : TraceContext from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move And Rename Method protected createServerMetaDataHolder() : ServerMetaDataHolder from class com.navercorp.pinpoint.profiler.DefaultAgent to public get() : ServerMetaDataHolder from class com.navercorp.pinpoint.profiler.context.provider.ServerMetaDataHolderProvider	From	To
Move And Inline Method	1
Move And Inline Method protected getTcpDataSender() : EnhancedDataSender moved from class com.navercorp.pinpoint.profiler.DefaultAgent to class com.navercorp.pinpoint.test.PluginTestAgent & inlined to private getTestTcpDataSender() : TestTcpDataSender	From	To
Change Parameter Type	5
Change Parameter Type agent : DefaultAgent to applicationContext : ApplicationContext in method public TestClassLoader(applicationContext ApplicationContext) in class com.navercorp.pinpoint.test.classloader.TestClassLoader	From	To
Change Parameter Type agent : DefaultAgent to applicationContext : ApplicationContext in method public ProfilerPluginLoader(applicationContext ApplicationContext) in class com.navercorp.pinpoint.profiler.plugin.ProfilerPluginLoader	From	To
Change Parameter Type agent : DefaultAgent to applicationContext : ApplicationContext in method public createTestClassLoader(applicationContext ApplicationContext) : TestClassLoader in class com.navercorp.pinpoint.test.classloader.TestClassLoaderFactory	From	To
Change Parameter Type agent : DefaultAgent to applicationContext : ApplicationContext in method public ClassFileTransformerDispatcher(applicationContext ApplicationContext, pluginContexts List<DefaultProfilerPluginContext>) in class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher	From	To
Change Parameter Type agent : DefaultAgent to applicationContext : ApplicationContext in method public DefaultProfilerPluginContext(applicationContext ApplicationContext, classInjector ClassInjector) in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext	From	To
Move Method	19
Move Method private createTraceFactory(storageFactory StorageFactory, sampler Sampler, idGenerator IdGenerator, activeTraceRepository ActiveTraceRepository) : TraceFactoryBuilder from class com.navercorp.pinpoint.profiler.DefaultAgent to private createTraceFactory(storageFactory StorageFactory, sampler Sampler, idGenerator IdGenerator, activeTraceRepository ActiveTraceRepository) : TraceFactoryBuilder from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method public getClassPool() : InstrumentClassPool from class com.navercorp.pinpoint.profiler.DefaultAgent to public getClassPool() : InstrumentClassPool from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method private createPluginMonitorContext() : PluginMonitorContext from class com.navercorp.pinpoint.profiler.DefaultAgent to private createPluginMonitorContext(profilerConfig ProfilerConfig) : PluginMonitorContext from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method private createSampler() : Sampler from class com.navercorp.pinpoint.profiler.DefaultAgent to private createSampler(profilerConfig ProfilerConfig) : Sampler from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method public getProfilerConfig() : ProfilerConfig from class com.navercorp.pinpoint.bootstrap.DummyAgent to public getProfilerConfig() : ProfilerConfig from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method public getBootstrapJarPaths() : List<String> from class com.navercorp.pinpoint.profiler.DefaultAgent to public getBootstrapJarPaths() : List<String> from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method public getClassFileTransformerDispatcher() : ClassFileTransformerDispatcher from class com.navercorp.pinpoint.profiler.DefaultAgent to public getClassFileTransformerDispatcher() : ClassFileTransformerDispatcher from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method public getDynamicTransformService() : DynamicTransformService from class com.navercorp.pinpoint.profiler.DefaultAgent to public getDynamicTransformService() : DynamicTransformService from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method protected loadPlugins(agentOption AgentOption) : List<DefaultProfilerPluginContext> from class com.navercorp.pinpoint.profiler.DefaultAgent to protected loadPlugins(agentOption AgentOption) : List<DefaultProfilerPluginContext> from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method public getTraceContext() : TraceContext from class com.navercorp.pinpoint.bootstrap.DummyAgent to public getTraceContext() : TraceContext from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method private closeTcpDataSender() : void from class com.navercorp.pinpoint.profiler.DefaultAgent to private closeTcpDataSender() : void from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method private createActiveTraceRepository() : ActiveTraceRepository from class com.navercorp.pinpoint.profiler.DefaultAgent to private createActiveTraceRepository(profilerConfig ProfilerConfig) : ActiveTraceRepository from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method protected getSpanDataSender() : DataSender from class com.navercorp.pinpoint.profiler.DefaultAgent to public getSpanDataSender() : DataSender from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method private createCommandService(profilerConfig ProfilerConfig, activeTraceRepository ActiveTraceRepository) : CommandDispatcher from class com.navercorp.pinpoint.profiler.DefaultAgent to private createCommandService(profilerConfig ProfilerConfig, activeTraceRepository ActiveTraceRepository) : CommandDispatcher from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method public getTraceContext() : TraceContext from class com.navercorp.pinpoint.profiler.DefaultAgent to public getTraceContext() : TraceContext from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method public getAgentInformation() : AgentInformation from class com.navercorp.pinpoint.profiler.DefaultAgent to public getAgentInformation() : AgentInformation from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method private wrapClassFileTransformer(classFileTransformerDispatcher ClassFileTransformer) : ClassFileTransformer from class com.navercorp.pinpoint.profiler.DefaultAgent to private wrapClassFileTransformer(profilerConfig ProfilerConfig, classFileTransformerDispatcher ClassFileTransformer) : ClassFileTransformer from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method private createInstrumentEngine(agentOption AgentOption, interceptorRegistryBinder InterceptorRegistryBinder) : InstrumentClassPool from class com.navercorp.pinpoint.profiler.DefaultAgent to private createInstrumentEngine(profilerConfig ProfilerConfig, agentOption AgentOption, interceptorRegistryBinder InterceptorRegistryBinder) : InstrumentClassPool from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Method public getInstrumentation() : Instrumentation from class com.navercorp.pinpoint.profiler.DefaultAgent to public getInstrumentation() : Instrumentation from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute	15
Move Attribute private classPool : InstrumentClassPool from class com.navercorp.pinpoint.profiler.DefaultAgent to private classPool : InstrumentClassPool from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private instrumentation : Instrumentation from class com.navercorp.pinpoint.profiler.DefaultAgent to private instrumentation : Instrumentation from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private client : PinpointClient from class com.navercorp.pinpoint.profiler.DefaultAgent to private client : PinpointClient from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private clientFactory : PinpointClientFactory from class com.navercorp.pinpoint.profiler.DefaultAgent to private clientFactory : PinpointClientFactory from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private agentStatMonitor : AgentStatMonitor from class com.navercorp.pinpoint.profiler.DefaultAgent to private agentStatMonitor : AgentStatMonitor from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private dynamicTransformService : DynamicTransformService from class com.navercorp.pinpoint.profiler.DefaultAgent to private dynamicTransformService : DynamicTransformService from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private tcpDataSender : EnhancedDataSender from class com.navercorp.pinpoint.profiler.DefaultAgent to private tcpDataSender : EnhancedDataSender from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private agentInformation : AgentInformation from class com.navercorp.pinpoint.profiler.DefaultAgent to private agentInformation : AgentInformation from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private agentOption : AgentOption from class com.navercorp.pinpoint.profiler.DefaultAgent to private agentOption : AgentOption from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private spanDataSender : DataSender from class com.navercorp.pinpoint.profiler.DefaultAgent to private spanDataSender : DataSender from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private agentInfoSender : AgentInfoSender from class com.navercorp.pinpoint.profiler.DefaultAgent to private agentInfoSender : AgentInfoSender from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private serverMetaDataHolder : ServerMetaDataHolder from class com.navercorp.pinpoint.profiler.DefaultAgent to private serverMetaDataHolder : ServerMetaDataHolder from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private classFileTransformer : ClassFileTransformerDispatcher from class com.navercorp.pinpoint.profiler.DefaultAgent to private classFileTransformer : ClassFileTransformerDispatcher from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private traceContext : TraceContext from class com.navercorp.pinpoint.profiler.DefaultAgent to private traceContext : TraceContext from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Move Attribute private statDataSender : DataSender from class com.navercorp.pinpoint.profiler.DefaultAgent to private statDataSender : DataSender from class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext	From	To
Extract Class	2
Extract Class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext from class com.navercorp.pinpoint.bootstrap.DummyAgent	From	To
Extract Class com.navercorp.pinpoint.profiler.context.DefaultApplicationContext from class com.navercorp.pinpoint.profiler.DefaultAgent	From	To
Rename Class	1
Rename Class com.navercorp.pinpoint.test.MockAgent renamed to com.navercorp.pinpoint.test.MockApplicationContext	From	To
Change Variable Type	4
Change Variable Type agent : DefaultAgent to applicationContext : ApplicationContext in method public test() : void in class com.navercorp.pinpoint.test.plugin.DefaultClassEditorBuilderTest	From	To
Change Variable Type agent : DefaultAgent to applicationContext : ApplicationContext in method private getTestClassLoader() : TestClassLoader in class com.navercorp.pinpoint.test.javasssit.JavassistClassTest	From	To
Change Variable Type agent : DefaultAgent to applicationContext : ApplicationContext in method private getTestClassLoader() : TestClassLoader in class com.navercorp.pinpoint.test.javasssit.accessor.AccessorInjectionTest	From	To
Change Variable Type mockAgent : MockAgent to mockApplicationContext : MockApplicationContext in method public setup(testContext TestContext) : void in class com.navercorp.pinpoint.test.junit4.BasePinpointTest	From	To
Extract Variable	7
Extract Variable getMethod : Method in method private getInterceptor(loader TestClassLoader, index int) : Interceptor from class com.navercorp.pinpoint.test.javasssit.JavassistClassTest	From	To
Extract Variable traceContext : TraceContext in method public cleanUp(detachTraceObject boolean) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Extract Variable interceptorClazz : Class<?> in method private getInterceptor(loader TestClassLoader, index int) : Interceptor from class com.navercorp.pinpoint.test.javasssit.JavassistClassTest	From	To
Extract Variable traceContext : TraceContext in method public initialize(createTraceObject boolean) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Extract Variable orderedSpanRecorder : OrderedSpanRecorder in method private createUdpSpanDataSender() : DataSender from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Extract Variable recorder : OrderedSpanRecorder in method private popSpan() : Object from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Extract Variable callaMethod : InstrumentMethod in method public doInTransform(instrumentor Instrumentor, classLoader ClassLoader, className String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classfileBuffer byte[]) : byte[] from class com.navercorp.pinpoint.test.javasssit.JavassistClassTest.testBeforeAddInterceptor.addTransformer	From	To
Rename Method	3
Rename Method protected createServerMetaDataHolder() : ServerMetaDataHolder renamed to protected newServerMetaDataHolderProvider() : Provider<ServerMetaDataHolder> in class com.navercorp.pinpoint.test.MockApplicationContext	From	To
Rename Method private createMockAgent() : MockAgent renamed to private createMockApplicationContext() : MockApplicationContext in class com.navercorp.pinpoint.test.junit4.TestContext	From	To
Rename Method public getMockAgent() : MockAgent renamed to public getMockApplicationContext() : MockApplicationContext in class com.navercorp.pinpoint.test.junit4.TestContext	From	To
Rename Variable	4
Rename Variable agent : DefaultAgent to applicationContext : ApplicationContext in method public test() : void in class com.navercorp.pinpoint.test.plugin.DefaultClassEditorBuilderTest	From	To
Rename Variable agent : DefaultAgent to applicationContext : ApplicationContext in method private getTestClassLoader() : TestClassLoader in class com.navercorp.pinpoint.test.javasssit.JavassistClassTest	From	To
Rename Variable agent : DefaultAgent to applicationContext : ApplicationContext in method private getTestClassLoader() : TestClassLoader in class com.navercorp.pinpoint.test.javasssit.accessor.AccessorInjectionTest	From	To
Rename Variable mockAgent : MockAgent to mockApplicationContext : MockApplicationContext in method public setup(testContext TestContext) : void in class com.navercorp.pinpoint.test.junit4.BasePinpointTest	From	To
Change Return Type	5
Change Return Type MockAgent to MockApplicationContext in method public getMockApplicationContext() : MockApplicationContext in class com.navercorp.pinpoint.test.junit4.TestContext	From	To
Change Return Type ServerMetaDataHolder to Provider<ServerMetaDataHolder> in method protected newServerMetaDataHolderProvider() : Provider<ServerMetaDataHolder> in class com.navercorp.pinpoint.test.MockApplicationContext	From	To
Change Return Type MockAgent to MockApplicationContext in method public of(configPath String) : MockApplicationContext in class com.navercorp.pinpoint.test.MockApplicationContext	From	To
Change Return Type MockAgent to MockApplicationContext in method public of(config ProfilerConfig) : MockApplicationContext in class com.navercorp.pinpoint.test.MockApplicationContext	From	To
Change Return Type MockAgent to MockApplicationContext in method private createMockApplicationContext() : MockApplicationContext in class com.navercorp.pinpoint.test.junit4.TestContext	From	To
Rename Attribute	4
Rename Attribute agent : DefaultAgent to applicationContext : ApplicationContext in class com.navercorp.pinpoint.profiler.plugin.ProfilerPluginLoader	From	To
Rename Attribute mockAgent : MockAgent to mockApplicationContext : MockApplicationContext in class com.navercorp.pinpoint.test.junit4.TestContext	From	To
Rename Attribute agent : DefaultAgent to applicationContext : ApplicationContext in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext	From	To
Rename Attribute agent : DefaultAgent to applicationContext : ApplicationContext in class com.navercorp.pinpoint.test.classloader.TestClassLoader	From	To
Change Attribute Type	4
Change Attribute Type agent : DefaultAgent to applicationContext : ApplicationContext in class com.navercorp.pinpoint.profiler.plugin.ProfilerPluginLoader	From	To
Change Attribute Type agent : DefaultAgent to applicationContext : ApplicationContext in class com.navercorp.pinpoint.test.classloader.TestClassLoader	From	To
Change Attribute Type mockAgent : MockAgent to mockApplicationContext : MockApplicationContext in class com.navercorp.pinpoint.test.junit4.TestContext	From	To
Change Attribute Type agent : DefaultAgent to applicationContext : ApplicationContext in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext	From	To
Extract And Move Method	1
Extract And Move Method protected newApplicationContext(agentOption AgentOption, interceptorRegistryBinder InterceptorRegistryBinder) : ApplicationContext extracted from public DefaultAgent(agentOption AgentOption, interceptorRegistryBinder InterceptorRegistryBinder) in class com.navercorp.pinpoint.profiler.DefaultAgent & moved to class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Rename Parameter	5
Rename Parameter agent : DefaultAgent to applicationContext : ApplicationContext in method public createTestClassLoader(applicationContext ApplicationContext) : TestClassLoader in class com.navercorp.pinpoint.test.classloader.TestClassLoaderFactory	From	To
Rename Parameter agent : DefaultAgent to applicationContext : ApplicationContext in method public ClassFileTransformerDispatcher(applicationContext ApplicationContext, pluginContexts List<DefaultProfilerPluginContext>) in class com.navercorp.pinpoint.profiler.ClassFileTransformerDispatcher	From	To
Rename Parameter agent : DefaultAgent to applicationContext : ApplicationContext in method public DefaultProfilerPluginContext(applicationContext ApplicationContext, classInjector ClassInjector) in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext	From	To
Rename Parameter agent : DefaultAgent to applicationContext : ApplicationContext in method public TestClassLoader(applicationContext ApplicationContext) in class com.navercorp.pinpoint.test.classloader.TestClassLoader	From	To
Rename Parameter agent : DefaultAgent to applicationContext : ApplicationContext in method public ProfilerPluginLoader(applicationContext ApplicationContext) in class com.navercorp.pinpoint.profiler.plugin.ProfilerPluginLoader	From	To

83111e1b3fed82f52d6b322a8d9c84a5b13e425c

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: