851e25bc863e814aff2f70370c129f5b84a7e473
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 10
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 4 | ||
| Change Parameter Type servletRequestEvent : ServletRequestEvent to httpServletRequest : HttpServletRequest in method private getStatusCode(httpServletRequest HttpServletRequest) : int in class com.navercorp.pinpoint.plugin.resin.ResinServletRequestListener | From | To | |
| Change Parameter Type servletRequestEvent : ServletRequestEvent to httpServletRequest : ServletRequest in method private getStatusCode(httpServletRequest ServletRequest) : int in class com.navercorp.pinpoint.plugin.tomcat.TomcatServletRequestListener | From | To | |
| Change Parameter Type servletRequestEvent : ServletRequestEvent to httpServletRequest : HttpServletRequest in method private getStatusCode(httpServletRequest HttpServletRequest) : int in class com.navercorp.pinpoint.plugin.weblogic.WeblogicServletRequestListener | From | To | |
| Change Parameter Type servletRequestEvent : ServletRequestEvent to httpServletRequest : HttpServletRequest in method private getStatusCode(httpServletRequest HttpServletRequest) : int in class com.navercorp.pinpoint.plugin.jetty.JettyServletRequestListener | From | To | |
| Move Method | 1 | ||
| Move Method private getRemoteAddress(realIpHeaderName String, realIpHeaderEmptyValue String, requestWrapper RequestWrapper, remoteAddr String) : String from class com.navercorp.pinpoint.bootstrap.plugin.request.ServletServerRequestWrapperFactory to public getRemoteAddress(requestWrapper RequestWrapper, remoteAddr String) : String from class com.navercorp.pinpoint.bootstrap.plugin.request.RealIpHeaderResolver | From | To | |
| Rename Variable | 5 | ||
| Rename Variable asyncTrace : Trace to trace : Object in method private getTrace(request ServletRequest) : Object in class com.navercorp.pinpoint.plugin.tomcat.TomcatServletRequestListener | From | To | |
| Rename Variable throwable : Throwable to exception : Object in method private getException(request ServletRequest) : Throwable in class com.navercorp.pinpoint.plugin.tomcat.TomcatServletRequestListener | From | To | |
| Rename Variable throwable : Throwable to exception : Object in method private getException(request ServletRequest) : Throwable in class com.navercorp.pinpoint.plugin.weblogic.WeblogicServletRequestListener | From | To | |
| Rename Variable throwable : Throwable to exception : Object in method private getException(request ServletRequest) : Throwable in class com.navercorp.pinpoint.plugin.jboss.JbossServletRequestListener | From | To | |
| Rename Variable throwable : Throwable to exception : Object in method private getException(request ServletRequest) : Throwable in class com.navercorp.pinpoint.plugin.resin.ResinServletRequestListener | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private realIpHeaderName : String from class com.navercorp.pinpoint.bootstrap.plugin.request.ServletServerRequestWrapperFactory to private realIpHeaderName : String from class com.navercorp.pinpoint.bootstrap.plugin.request.RealIpHeaderResolver | From | To | |
| Move Attribute private realIpHeaderEmptyValue : String from class com.navercorp.pinpoint.bootstrap.plugin.request.ServletServerRequestWrapperFactory to private realIpHeaderEmptyValue : String from class com.navercorp.pinpoint.bootstrap.plugin.request.RealIpHeaderResolver | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.bootstrap.plugin.request.RealIpHeaderResolver from class com.navercorp.pinpoint.bootstrap.plugin.request.ServletServerRequestWrapperFactory | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute realIpHeaderEmptyValue : String to remoteAddressResolver : RemoteAddressResolver in class com.navercorp.pinpoint.bootstrap.plugin.request.ServletServerRequestWrapperFactory | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type throwable : Throwable to exception : Object in method private getException(request ServletRequest) : Throwable in class com.navercorp.pinpoint.plugin.weblogic.WeblogicServletRequestListener | From | To | |
| Change Variable Type throwable : Throwable to exception : Object in method private getException(request ServletRequest) : Throwable in class com.navercorp.pinpoint.plugin.tomcat.TomcatServletRequestListener | From | To | |
| Change Variable Type throwable : Throwable to exception : Object in method private getException(request ServletRequest) : Throwable in class com.navercorp.pinpoint.plugin.resin.ResinServletRequestListener | From | To | |
| Change Variable Type throwable : Throwable to exception : Object in method private getException(request ServletRequest) : Throwable in class com.navercorp.pinpoint.plugin.jboss.JbossServletRequestListener | From | To | |
| Change Variable Type asyncTrace : Trace to trace : Object in method private getTrace(request ServletRequest) : Object in class com.navercorp.pinpoint.plugin.tomcat.TomcatServletRequestListener | From | To | |
| Extract Method | 5 | ||
| Extract Method private getTrace(request ServletRequest) : Object extracted from public requestDestroyed(servletRequestEvent ServletRequestEvent) : void in class com.navercorp.pinpoint.plugin.tomcat.TomcatServletRequestListener | From | To | |
| Extract Method private getException(request ServletRequest) : Throwable extracted from public requestDestroyed(servletRequestEvent ServletRequestEvent) : void in class com.navercorp.pinpoint.plugin.weblogic.WeblogicServletRequestListener | From | To | |
| Extract Method private getException(request ServletRequest) : Throwable extracted from public requestDestroyed(servletRequestEvent ServletRequestEvent) : void in class com.navercorp.pinpoint.plugin.tomcat.TomcatServletRequestListener | From | To | |
| Extract Method private getException(request ServletRequest) : Throwable extracted from public requestDestroyed(servletRequestEvent ServletRequestEvent) : void in class com.navercorp.pinpoint.plugin.jboss.JbossServletRequestListener | From | To | |
| Extract Method private getException(request ServletRequest) : Throwable extracted from public requestDestroyed(servletRequestEvent ServletRequestEvent) : void in class com.navercorp.pinpoint.plugin.resin.ResinServletRequestListener | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type realIpHeaderEmptyValue : String to remoteAddressResolver : RemoteAddressResolver in class com.navercorp.pinpoint.bootstrap.plugin.request.ServletServerRequestWrapperFactory | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter servletRequestEvent : ServletRequestEvent to httpServletRequest : HttpServletRequest in method private getStatusCode(httpServletRequest HttpServletRequest) : int in class com.navercorp.pinpoint.plugin.jetty.JettyServletRequestListener | From | To | |
| Rename Parameter servletRequestEvent : ServletRequestEvent to httpServletRequest : ServletRequest in method private getStatusCode(httpServletRequest ServletRequest) : int in class com.navercorp.pinpoint.plugin.tomcat.TomcatServletRequestListener | From | To | |
| Rename Parameter servletRequestEvent : ServletRequestEvent to httpServletRequest : HttpServletRequest in method private getStatusCode(httpServletRequest HttpServletRequest) : int in class com.navercorp.pinpoint.plugin.weblogic.WeblogicServletRequestListener | From | To | |
| Rename Parameter servletRequestEvent : ServletRequestEvent to httpServletRequest : HttpServletRequest in method private getStatusCode(httpServletRequest HttpServletRequest) : int in class com.navercorp.pinpoint.plugin.resin.ResinServletRequestListener | From | To |