91607dd2a4b011e06980e2aabd5e96572a26b266
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private replaceDataInSendAgentStatService() : void renamed to private replaceDataInSendDataToFlinkService() : void in class com.navercorp.pinpoint.collector.cluster.flink.TcpDataSenderRepository | From | To | |
| Rename Method public setAgentStatHandler(agentStatHandler AgentStatHandler) : void renamed to public setSimpletHandler(simpleHandler SimpleHandler) : void in class com.navercorp.pinpoint.flink.receiver.TcpDispatchHandler | From | To | |
| Pull Up Method | 3 | ||
| Pull Up Method public replaceFlinkTcpDataSenderList(flinkTcpDataSenderList List<FlinkTcpDataSender>) : void from class com.navercorp.pinpoint.collector.service.SendAgentStatService to public replaceFlinkTcpDataSenderList(flinkTcpDataSenderList List<FlinkTcpDataSender>) : void from class com.navercorp.pinpoint.collector.service.SendDataToFlinkService | From | To | |
| Pull Up Method private roundRobinTcpDataSender() : FlinkTcpDataSender from class com.navercorp.pinpoint.collector.service.SendAgentStatService to private roundRobinTcpDataSender() : FlinkTcpDataSender from class com.navercorp.pinpoint.collector.service.SendDataToFlinkService | From | To | |
| Pull Up Method public addSourceContext(sourceContext SourceContext) : void from class com.navercorp.pinpoint.flink.receiver.AgentStatHandler to public addSourceContext(sourceContext SourceFunction.SourceContext) : void from class com.navercorp.pinpoint.flink.receiver.SourceContextManager | From | To | |
| Change Parameter Type | 5 | ||
| Change Parameter Type config : CollectorConfiguration to config : FlinkConfiguration in method public FlinkClusterService(config FlinkConfiguration, clusterConnectionManager FlinkClusterConnectionManager, pinpointFlinkClusterPath String) in class com.navercorp.pinpoint.collector.cluster.flink.FlinkClusterService | From | To | |
| Change Parameter Type sourceContext : SourceContext to sourceContext : SourceFunction.SourceContext in method public addSourceContext(sourceContext SourceFunction.SourceContext) : void in class com.navercorp.pinpoint.flink.receiver.SourceContextManager | From | To | |
| Change Parameter Type agentStatHandler : AgentStatHandler to simpleHandler : SimpleHandler in method public setSimpletHandler(simpleHandler SimpleHandler) : void in class com.navercorp.pinpoint.flink.receiver.TcpDispatchHandler | From | To | |
| Change Parameter Type config : CollectorConfiguration to config : FlinkConfiguration in method public SendAgentStatService(config FlinkConfiguration) in class com.navercorp.pinpoint.collector.service.SendAgentStatService | From | To | |
| Change Parameter Type sendAgentStatService : SendAgentStatService to sendDataToFlinkService : SendDataToFlinkService in method package TcpDataSenderRepository(sendDataToFlinkService SendDataToFlinkService) in class com.navercorp.pinpoint.collector.cluster.flink.TcpDataSenderRepository | From | To | |
| Move Method | 3 | ||
| Move Method public getFlinkClusterSessionTimeout() : int from class com.navercorp.pinpoint.collector.config.CollectorConfiguration to public getFlinkClusterSessionTimeout() : int from class com.navercorp.pinpoint.collector.config.FlinkConfiguration | From | To | |
| Move Method public isFlinkClusterEnable() : boolean from class com.navercorp.pinpoint.collector.config.CollectorConfiguration to public isFlinkClusterEnable() : boolean from class com.navercorp.pinpoint.collector.config.FlinkConfiguration | From | To | |
| Move Method public getFlinkClusterZookeeperAddress() : String from class com.navercorp.pinpoint.collector.config.CollectorConfiguration to public getFlinkClusterZookeeperAddress() : String from class com.navercorp.pinpoint.collector.config.FlinkConfiguration | From | To | |
| Pull Up Attribute | 3 | ||
| Pull Up Attribute private callCount : AtomicInteger from class com.navercorp.pinpoint.collector.service.SendAgentStatService to private callCount : AtomicInteger from class com.navercorp.pinpoint.collector.service.SendDataToFlinkService | From | To | |
| Pull Up Attribute private callCount : AtomicInteger from class com.navercorp.pinpoint.flink.receiver.AgentStatHandler to private callCount : AtomicInteger from class com.navercorp.pinpoint.flink.receiver.SourceContextManager | From | To | |
| Pull Up Attribute private flinkTcpDataSenderList : List<FlinkTcpDataSender> from class com.navercorp.pinpoint.collector.service.SendAgentStatService to private flinkTcpDataSenderList : List<FlinkTcpDataSender> from class com.navercorp.pinpoint.collector.service.SendDataToFlinkService | From | To | |
| Change Return Type | 4 | ||
| Change Return Type void to boolean in method public insertSpanChunk(spanChunk SpanChunkBo) : boolean in class com.navercorp.pinpoint.collector.dao.TraceDao | From | To | |
| Change Return Type void to boolean in method public insert(spanBo SpanBo) : boolean in class com.navercorp.pinpoint.collector.dao.hbase.HbaseTraceDaoV2 | From | To | |
| Change Return Type void to boolean in method public insert(span SpanBo) : boolean in class com.navercorp.pinpoint.collector.dao.TraceDao | From | To | |
| Change Return Type void to boolean in method public insertSpanChunk(spanChunkBo SpanChunkBo) : boolean in class com.navercorp.pinpoint.collector.dao.hbase.HbaseTraceDaoV2 | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private flinkClusterSessionTimeout : int from class com.navercorp.pinpoint.collector.config.CollectorConfiguration to protected flinkClusterSessionTimeout : int from class com.navercorp.pinpoint.collector.config.FlinkConfiguration | From | To | |
| Move Attribute private flinkClusterEnable : boolean from class com.navercorp.pinpoint.collector.config.CollectorConfiguration to protected flinkClusterEnable : boolean from class com.navercorp.pinpoint.collector.config.FlinkConfiguration | From | To | |
| Move Attribute private flinkClusterZookeeperAddress : String from class com.navercorp.pinpoint.collector.config.CollectorConfiguration to protected flinkClusterZookeeperAddress : String from class com.navercorp.pinpoint.collector.config.FlinkConfiguration | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass com.navercorp.pinpoint.collector.service.SendDataToFlinkService from classes [com.navercorp.pinpoint.collector.service.SendAgentStatService] | From | To | |
| Extract Superclass com.navercorp.pinpoint.flink.receiver.SourceContextManager from classes [com.navercorp.pinpoint.flink.receiver.AgentStatHandler] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute PINPOINT_FLINK_CLUSTER_PATH : String to pinpointFlinkClusterPath : String in class com.navercorp.pinpoint.collector.cluster.flink.FlinkClusterService | From | To | |
| Rename Attribute sendAgentStatService : SendAgentStatService to sendDataToFlinkService : SendDataToFlinkService in class com.navercorp.pinpoint.collector.cluster.flink.TcpDataSenderRepository | From | To | |
| Rename Attribute agentStatHandler : AgentStatHandler to simpleHandler : SimpleHandler in class com.navercorp.pinpoint.flink.receiver.TcpDispatchHandler | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type config : CollectorConfiguration to config : FlinkConfiguration in class com.navercorp.pinpoint.collector.cluster.flink.FlinkClusterService | From | To | |
| Change Attribute Type sendAgentStatService : SendAgentStatService to sendDataToFlinkService : SendDataToFlinkService in class com.navercorp.pinpoint.collector.cluster.flink.TcpDataSenderRepository | From | To | |
| Change Attribute Type agentStatHandler : AgentStatHandler to simpleHandler : SimpleHandler in class com.navercorp.pinpoint.flink.receiver.TcpDispatchHandler | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter sendAgentStatService : SendAgentStatService to sendDataToFlinkService : SendDataToFlinkService in method package TcpDataSenderRepository(sendDataToFlinkService SendDataToFlinkService) in class com.navercorp.pinpoint.collector.cluster.flink.TcpDataSenderRepository | From | To | |
| Rename Parameter agentStatHandler : AgentStatHandler to simpleHandler : SimpleHandler in method public setSimpletHandler(simpleHandler SimpleHandler) : void in class com.navercorp.pinpoint.flink.receiver.TcpDispatchHandler | From | To |