92567f6f4bd737c33cc8c3bb5853e721f597d951
Files Diff
- Added: 4
- Removed: 2
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 6 | ||
| Move Method private getHistogramSlotTime(span SpanBo, serviceType ServiceType) : short from class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl to private getHistogramSlotTime(span SpanBo, serviceType ServiceType) : short from class com.navercorp.pinpoint.web.service.map.FilteredMapBuilder | From | To | |
| Move Method private checkDuplicatedSpanId(transaction List<SpanBo>) : Map<Long,SpanBo> from class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl to private checkDuplicatedSpanId(transaction List<SpanBo>) : Map<Long,SpanBo> from class com.navercorp.pinpoint.web.service.map.FilteredMapBuilder | From | To | |
| Move Method private addNodeFromSpanEvent(span SpanBo, window TimeWindow, linkDataDuplexMap LinkDataDuplexMap, transactionSpanMap Map<Long,SpanBo>) : void from class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl to private addNodeFromSpanEvent(span SpanBo, transactionSpanMap Map<Long,SpanBo>) : void from class com.navercorp.pinpoint.web.service.map.FilteredMapBuilder | From | To | |
| Move Method private createParentApplication(span SpanBo, transactionSpanMap Map<Long,SpanBo>, version int) : Application from class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl to private createParentApplication(span SpanBo, transactionSpanMap Map<Long,SpanBo>, version int) : Application from class com.navercorp.pinpoint.web.service.map.FilteredMapBuilder | From | To | |
| Move Method private getHistogramSlotTime(spanEvent SpanEventBo, serviceType ServiceType) : short from class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl to private getHistogramSlotTime(spanEvent SpanEventBo, serviceType ServiceType) : short from class com.navercorp.pinpoint.web.service.map.FilteredMapBuilder | From | To | |
| Move Method private getHistogramSlotTime(hasException boolean, elapsedTime int, serviceType ServiceType) : short from class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl to private getHistogramSlotTime(hasException boolean, elapsedTime int, serviceType ServiceType) : short from class com.navercorp.pinpoint.web.service.map.FilteredMapBuilder | From | To | |
| Rename Variable | 2 | ||
| Rename Variable responseHistogramBuilder : ResponseHistogramBuilder to responseHistograms : ResponseHistograms in method public setUp() : void in class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderCompatibilityTest | From | To | |
| Rename Variable result : Map<Application,List<ResponseTime>> to responseTimeMap : Map<Application,List<ResponseTime>> in method public build() : ResponseHistograms in class com.navercorp.pinpoint.web.vo.ResponseHistograms.Builder | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to ResponseHistograms in method public build() : ResponseHistograms in class com.navercorp.pinpoint.web.vo.ResponseHistograms.Builder | From | To | |
| Change Return Type void to Builder in method public addHistogram(application Application, span SpanBo, timestamp long) : Builder in class com.navercorp.pinpoint.web.vo.ResponseHistograms.Builder | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private range : Range from class com.navercorp.pinpoint.web.service.DotExtractor to private range : Range from class com.navercorp.pinpoint.web.service.map.FilteredMapBuilder | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.web.service.map.FilteredMapBuilder from class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.navercorp.pinpoint.web.vo.ResponseHistogramBuilder moved and renamed to com.navercorp.pinpoint.web.vo.ResponseHistograms.Builder | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type responseHistogramBuilder : ResponseHistogramBuilder to responseHistograms : ResponseHistograms in method public setUp() : void in class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderCompatibilityTest | From | To | |
| Extract Variable | 1 | ||
| Extract Variable applicationScatterData : Map<Application,ScatterData> in method public selectApplicationMapWithScatterData(transactionIdList List<TransactionId>, originalRange Range, scanRange Range, xGroupUnit int, yGroupUnit int, filter Filter, version int) : ApplicationMap from class com.navercorp.pinpoint.web.service.FilteredMapServiceImpl | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type responseHistogramBuilderNodeHistogramDataSource : ResponseHistogramBuilderNodeHistogramDataSource to responseHistogramBuilderNodeHistogramDataSource : ResponseHistogramsNodeHistogramDataSource in class com.navercorp.pinpoint.web.applicationmap.ApplicationMapBuilderCompatibilityTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter timeStamp : Long to timestamp : Long in method private getResponseTime(application Application, timestamp Long) : ResponseTime in class com.navercorp.pinpoint.web.vo.ResponseHistograms.Builder | From | To | |
| Rename Parameter timeStamp : long to timestamp : long in method public addHistogram(application Application, span SpanBo, timestamp long) : Builder in class com.navercorp.pinpoint.web.vo.ResponseHistograms.Builder | From | To |