94a38e1f0459b043f7c49f225f26e136fcc0eb0e
Files Diff
- Added: 29
- Removed: 20
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 4 | ||
| Change Parameter Type condition : Condition to condition : ClassCondition in method public ConditionalClassEditor(condition ClassCondition, delegate DedicatedClassEditor) in class com.navercorp.pinpoint.bootstrap.plugin.editor.ConditionalClassEditor | From | To | |
| Change Parameter Type condition : Condition to condition : ClassCondition in method public condition(condition ClassCondition) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Change Parameter Type condition : Condition to condition : MethodCondition in method public condition(condition MethodCondition) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Change Parameter Type injectors : List<Injector> to recipe : ClassRecipe in method public BasicClassEditor(targetClassName String, recipe ClassRecipe) in class com.navercorp.pinpoint.bootstrap.plugin.editor.BasicClassEditor | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private methodName : String from class com.navercorp.pinpoint.bootstrap.plugin.ClassEditorBuilder.InterceptorBuilder to private methodName : String from class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.MethodEditorBuilder | From | To | |
| Move Attribute private filter : MethodFilter from class com.navercorp.pinpoint.bootstrap.plugin.ClassEditorBuilder.InterceptorBuilder to private filter : MethodFilter from class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.MethodEditorBuilder | From | To | |
| Move Attribute private parameterNames : String[] from class com.navercorp.pinpoint.bootstrap.plugin.ClassEditorBuilder.InterceptorBuilder to private parameterNames : String[] from class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.MethodEditorBuilder | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.MethodEditorBuilder from class com.navercorp.pinpoint.bootstrap.plugin.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Move And Rename Class | 3 | ||
| Move And Rename Class com.navercorp.pinpoint.bootstrap.plugin.Condition moved and renamed to com.navercorp.pinpoint.bootstrap.plugin.editor.MethodCondition | From | To | |
| Move And Rename Class com.navercorp.pinpoint.bootstrap.plugin.Condition moved and renamed to com.navercorp.pinpoint.bootstrap.plugin.editor.ClassCondition | From | To | |
| Move And Rename Class com.navercorp.pinpoint.bootstrap.plugin.Injector moved and renamed to com.navercorp.pinpoint.bootstrap.plugin.editor.ClassRecipe | From | To | |
| Move Class | 11 | ||
| Move Class com.navercorp.pinpoint.bootstrap.plugin.PluginTestVerifierHolder moved to com.navercorp.pinpoint.bootstrap.plugin.test.PluginTestVerifierHolder | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.PluginTestVerifier moved to com.navercorp.pinpoint.bootstrap.plugin.test.PluginTestVerifier | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.ClassEditorBuilder moved to com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.DefaultInterceptorFactory moved to com.navercorp.pinpoint.bootstrap.plugin.editor.DefaultInterceptorFactory | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.DedicatedClassEditor moved to com.navercorp.pinpoint.bootstrap.plugin.editor.DedicatedClassEditor | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.FieldSnooperInjector moved to com.navercorp.pinpoint.bootstrap.plugin.editor.FieldSnooperInjector | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.ConditionalClassEditor moved to com.navercorp.pinpoint.bootstrap.plugin.editor.ConditionalClassEditor | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.ClassEditor moved to com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditor | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.MetadataInjector moved to com.navercorp.pinpoint.bootstrap.plugin.editor.MetadataInjector | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.BasicClassEditor moved to com.navercorp.pinpoint.bootstrap.plugin.editor.BasicClassEditor | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.plugin.InterceptorFactory moved to com.navercorp.pinpoint.bootstrap.plugin.editor.InterceptorFactory | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type injectors : List<Injector> to recipe : ClassRecipe in method private buildClassEditor(recipe ClassRecipe) : DedicatedClassEditor in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Change Variable Type interceptorBuilder : InterceptorBuilder to methodEditorBuilder : MethodEditorBuilder in method public editMethod() : MethodEditorBuilder in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Change Variable Type ib : InterceptorBuilder to ib : MethodEditorBuilder in method public test() : void in class com.navercorp.pinpoint.bootstrap.plugin.ClassEditorBuilderTest | From | To | |
| Change Variable Type injector : Injector to injector : InterceptorInjector in method private buildInterceptorInjector(factory InterceptorFactory) : InterceptorInjector in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Extract Method | 3 | ||
| Extract Method private buildClassEditor(recipe ClassRecipe) : DedicatedClassEditor extracted from public build() : DedicatedClassEditor in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Extract Method private buildInterceptorInjector(factory InterceptorFactory) : InterceptorInjector extracted from package build() : Injector in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Extract Method private buildInterceptorFactory() : InterceptorFactory extracted from package build() : Injector in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Rename Method | 10 | ||
| Rename Method public inject(classLoader ClassLoader, target InstrumentClass) : void renamed to public edit(classLoader ClassLoader, target InstrumentClass) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.MetadataInjector | From | To | |
| Rename Method public when(condition Condition) : void renamed to public condition(condition ClassCondition) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Rename Method public constructedWith(args Object...) : void renamed to public constructorArgs(args Object...) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Rename Method public inject(classLoader ClassLoader, target InstrumentClass) : void renamed to public edit(classLoader ClassLoader, target InstrumentClass) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassRecipe | From | To | |
| Rename Method public when(condition Condition) : void renamed to public condition(condition MethodCondition) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Rename Method public with(interceptorClassName String) : void renamed to public scope(scopeName String) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Rename Method public getValue() : String renamed to public getName() : String in class com.navercorp.pinpoint.common.AnnotationKey | From | To | |
| Rename Method public inject(classLoader ClassLoader, target InstrumentClass) : void renamed to public edit(classLoader ClassLoader, target InstrumentClass) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.FieldSnooperInjector | From | To | |
| Rename Method public newInterceptorBuilder() : InterceptorBuilder renamed to public editMethod() : MethodEditorBuilder in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Rename Method public edit(targetClassName String) : void renamed to public target(targetClassName String) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Inline Method | 1 | ||
| Inline Method private createInstance(classLoader ClassLoader, traceContext TraceContext, target InstrumentClass, targetMethod MethodInfo) : Interceptor inlined to public getInterceptor(classLoader ClassLoader, target InstrumentClass, targetMethod MethodInfo) : Interceptor in class com.navercorp.pinpoint.bootstrap.plugin.editor.DefaultInterceptorFactory | From | To | |
| Rename Variable | 1 | ||
| Rename Variable interceptorBuilder : InterceptorBuilder to methodEditorBuilder : MethodEditorBuilder in method public editMethod() : MethodEditorBuilder in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Injector to InterceptorInjector in method package build() : InterceptorInjector in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Change Return Type InterceptorBuilder to MethodEditorBuilder in method public editMethod() : MethodEditorBuilder in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable injectors : List<Injector> to recipe : ClassRecipe in method private buildClassEditor(recipe ClassRecipe) : DedicatedClassEditor in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute injectors : List<Injector> to recipes : List<ClassRecipe> in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Rename Attribute scopeName : String to pluginContext : ProfilerPluginContext in class com.navercorp.pinpoint.bootstrap.plugin.editor.DefaultInterceptorFactory | From | To | |
| Rename Attribute value : String to name : String in class com.navercorp.pinpoint.common.AnnotationKey | From | To | |
| Rename Attribute injectorBuilders : List<InjectorBuilder> to methodEditorBuilders : List<MethodEditorBuilder> in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Rename Attribute injectors : List<Injector> to recipe : ClassRecipe in class com.navercorp.pinpoint.bootstrap.plugin.editor.BasicClassEditor | From | To | |
| Change Attribute Type | 7 | ||
| Change Attribute Type condition : Condition to condition : ClassCondition in class com.navercorp.pinpoint.bootstrap.plugin.editor.ConditionalClassEditor | From | To | |
| Change Attribute Type condition : Condition to condition : ClassCondition in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Change Attribute Type injectors : List<Injector> to recipes : List<ClassRecipe> in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Change Attribute Type injectors : List<Injector> to recipe : ClassRecipe in class com.navercorp.pinpoint.bootstrap.plugin.editor.BasicClassEditor | From | To | |
| Change Attribute Type condition : Condition to condition : MethodCondition in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Change Attribute Type scopeName : String to pluginContext : ProfilerPluginContext in class com.navercorp.pinpoint.bootstrap.plugin.editor.DefaultInterceptorFactory | From | To | |
| Change Attribute Type injectorBuilders : List<InjectorBuilder> to methodEditorBuilders : List<MethodEditorBuilder> in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter interceptorClassName : String to scopeName : String in method public scope(scopeName String) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To | |
| Rename Parameter injectors : List<Injector> to recipe : ClassRecipe in method public BasicClassEditor(targetClassName String, recipe ClassRecipe) in class com.navercorp.pinpoint.bootstrap.plugin.editor.BasicClassEditor | From | To | |
| Rename Parameter scopeName : String to interceptorClassName : String in method public interceptorClass(interceptorClassName String) : void in class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassEditorBuilder.InterceptorBuilder | From | To |