96a61af7a2576b82d718278695a3006b42694038
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method private awaitHandshake0() : PinpointClientHandler renamed to public awaitConnected() : PinpointClient in class com.navercorp.pinpoint.rpc.client.Connection | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type handshakeData : Map<String,Object> to handshaker : PinpointClientHandshaker in method public DefaultPinpointClientHandler(connectionFactory ConnectionFactory, handshaker PinpointClientHandshaker, localClusterOption ClusterOption, clientOption ClientOption, channelTimer Timer, messageListener MessageListener, serverStreamChannelMessageListener ServerStreamChannelMessageListener, stateChangeEventListeners List<StateChangeEventListener>) in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
Rename Variable | 1 | ||
Rename Variable handshakeData : Map<String,Object> to copyProperties : Map<String,Object> in method private createConnectionFactory() : ConnectionFactory in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory | From | To | |
Inline Method | 1 | ||
Inline Method private newHandShakeData() : Map<String,Object> inlined to private createConnectionFactory() : ConnectionFactory in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientFactory | From | To | |
Change Return Type | 2 | ||
Change Return Type PinpointClientHandler to PinpointClient in method public awaitConnected() : PinpointClient in class com.navercorp.pinpoint.rpc.client.Connection | From | To | |
Change Return Type DefaultPinpointClientHandler to PinpointClientHandler in method public newClientHandler(connectionFactory ConnectionFactory, channelTimer Timer, reconnect boolean) : PinpointClientHandler in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandlerFactory | From | To | |
Move Attribute | 3 | ||
Move Attribute private handshakeData : Map<String,Object> from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler to private handshakeData : Map<String,Object> from class com.navercorp.pinpoint.rpc.client.PinpointClientHandshaker | From | To | |
Move Attribute private maxHandshakeCount : int from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler to private maxHandshakeCount : int from class com.navercorp.pinpoint.rpc.client.HandshakerFactory | From | To | |
Move Attribute private DEFAULT_ENABLE_WORKER_PACKET_RETRY_COUNT : int from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler to private DEFAULT_ENABLE_WORKER_PACKET_RETRY_COUNT : int from class com.navercorp.pinpoint.rpc.client.HandshakerFactory | From | To | |
Extract Class | 1 | ||
Extract Class com.navercorp.pinpoint.rpc.client.HandshakerFactory from class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To | |
Rename Attribute | 1 | ||
Rename Attribute handShakeData : Map<String,Object> to handshakerFactory : HandshakerFactory in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandlerFactory | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type handShakeData : Map<String,Object> to handshakerFactory : HandshakerFactory in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandlerFactory | From | To | |
Extract Method | 1 | ||
Extract Method private awaitConnected0() : PinpointClientHandler extracted from private awaitHandshake0() : PinpointClientHandler in class com.navercorp.pinpoint.rpc.client.Connection | From | To | |
Rename Parameter | 1 | ||
Rename Parameter handshakeData : Map<String,Object> to handshaker : PinpointClientHandshaker in method public DefaultPinpointClientHandler(connectionFactory ConnectionFactory, handshaker PinpointClientHandshaker, localClusterOption ClusterOption, clientOption ClientOption, channelTimer Timer, messageListener MessageListener, serverStreamChannelMessageListener ServerStreamChannelMessageListener, stateChangeEventListeners List<StateChangeEventListener>) in class com.navercorp.pinpoint.rpc.client.DefaultPinpointClientHandler | From | To |