a4f3dd9dbcaef80ff43b771743439f60c56e7c62
Files Diff
- Added: 8
- Removed: 5
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 5 | ||
| Change Parameter Type executor : ExecutorService to executor : Executor in method public ServerFactory(name String, hostname String, port int, executor Executor, serverOption ServerOption) in class com.navercorp.pinpoint.grpc.server.ServerFactory | From | To | |
| Change Parameter Type inetAddressFilter : InetAddressFilter to addressFilter : AddressFilter in method public PermissionServerTransportFilter(addressFilter AddressFilter) in class com.navercorp.pinpoint.collector.receiver.grpc.PermissionServerTransportFilter | From | To | |
| Change Parameter Type executor : ExecutorService to executor : Executor in method public setExecutor(executor Executor) : void in class com.navercorp.pinpoint.collector.receiver.grpc.SpanServer | From | To | |
| Change Parameter Type executor : ExecutorService to executor : Executor in method public ServerFactory(name String, hostname String, port int, executor Executor) in class com.navercorp.pinpoint.grpc.server.ServerFactory | From | To | |
| Change Parameter Type executor : ExecutorService to executor : Executor in method public setExecutor(executor Executor) : void in class com.navercorp.pinpoint.collector.receiver.grpc.StatServer | From | To | |
| Rename Variable | 2 | ||
| Rename Variable serverTransportFilter : ServerTransportFilter to transportFilter : ServerTransportFilter in method public build() : Server in class com.navercorp.pinpoint.grpc.server.ServerFactory | From | To | |
| Rename Variable transportId : int to transportMetadata : TransportMetadata in method public transportReady(attributes Attributes) : Attributes in class com.navercorp.pinpoint.grpc.server.MetadataServerTransportFilter | From | To | |
| Inline Method | 1 | ||
| Inline Method public extract(headers Metadata, attributes Attributes) : Header inlined to public extract(headers Metadata) : Header in class com.navercorp.pinpoint.grpc.AgentHeaderFactory | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.grpc.server.DefaultTransportMetadata from class com.navercorp.pinpoint.grpc.AgentHeaderFactory.Header | From | To | |
| Rename Class | 1 | ||
| Rename Class com.navercorp.pinpoint.grpc.server.IdGeneratorServerTransportFilter renamed to com.navercorp.pinpoint.grpc.server.MetadataServerTransportFilter | From | To | |
| Move Class | 1 | ||
| Move Class com.navercorp.pinpoint.grpc.server.PermissionServerTransportFilter moved to com.navercorp.pinpoint.collector.receiver.grpc.PermissionServerTransportFilter | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute inetAddressFilter : InetAddressFilter to addressFilter : AddressFilter in class com.navercorp.pinpoint.collector.receiver.grpc.PermissionServerTransportFilter | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type transportId : int to transportMetadata : TransportMetadata in method public transportReady(attributes Attributes) : Attributes in class com.navercorp.pinpoint.grpc.server.MetadataServerTransportFilter | From | To | |
| Change Variable Type bindableService : BindableService to bindableService : ServerServiceDefinition in method public build() : Server in class com.navercorp.pinpoint.grpc.server.ServerFactory | From | To | |
| Extract Variable | 8 | ||
| Extract Variable metadataTransportFilter : ServerTransportFilter in method public afterPropertiesSet() : void from class com.navercorp.pinpoint.collector.receiver.grpc.AgentServer | From | To | |
| Extract Variable empty : Empty in method public onCompleted() : void from class com.navercorp.pinpoint.collector.receiver.grpc.service.TraceService.sendSpanChunk.observer | From | To | |
| Extract Variable traceService : BindableService in method public afterPropertiesSet() : void from class com.navercorp.pinpoint.collector.receiver.grpc.SpanServer | From | To | |
| Extract Variable permissionServerTransportFilter : ServerTransportFilter in method public afterPropertiesSet() : void from class com.navercorp.pinpoint.collector.receiver.grpc.AgentServer | From | To | |
| Extract Variable empty : Empty in method public onCompleted() : void from class com.navercorp.pinpoint.collector.receiver.grpc.service.TraceService.sendSpan.observer | From | To | |
| Extract Variable permissionServerTransportFilter : ServerTransportFilter in method public afterPropertiesSet() : void from class com.navercorp.pinpoint.collector.receiver.grpc.StatServer | From | To | |
| Extract Variable statService : BindableService in method public afterPropertiesSet() : void from class com.navercorp.pinpoint.collector.receiver.grpc.StatServer | From | To | |
| Extract Variable permissionServerTransportFilter : ServerTransportFilter in method public afterPropertiesSet() : void from class com.navercorp.pinpoint.collector.receiver.grpc.SpanServer | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type bindableServices : List<BindableService> to bindableServices : List<ServerServiceDefinition> in class com.navercorp.pinpoint.grpc.server.ServerFactory | From | To | |
| Change Attribute Type inetAddressFilter : InetAddressFilter to addressFilter : AddressFilter in class com.navercorp.pinpoint.collector.receiver.grpc.PermissionServerTransportFilter | From | To | |
| Change Attribute Type executor : ExecutorService to executor : Executor in class com.navercorp.pinpoint.grpc.server.ServerFactory | From | To | |
| Change Attribute Type executor : ExecutorService to executor : Executor in class com.navercorp.pinpoint.collector.receiver.grpc.SpanServer | From | To | |
| Change Attribute Type executor : ExecutorService to executor : Executor in class com.navercorp.pinpoint.collector.receiver.grpc.StatServer | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter inetAddressFilter : InetAddressFilter to addressFilter : AddressFilter in method public PermissionServerTransportFilter(addressFilter AddressFilter) in class com.navercorp.pinpoint.collector.receiver.grpc.PermissionServerTransportFilter | From | To | |
| Rename Parameter grpcAgentLifeCycleAsyncTask : AgentLifeCycleAsyncTaskService to agentLifeCycleAsyncTask : AgentLifeCycleAsyncTaskService in method public KeepAliveService(agentEventAsyncTask AgentEventAsyncTaskService, agentLifeCycleAsyncTask AgentLifeCycleAsyncTaskService) in class com.navercorp.pinpoint.collector.receiver.grpc.service.KeepAliveService | From | To | |
| Rename Parameter grpcAgentEventAsyncTask : AgentEventAsyncTaskService to agentEventAsyncTask : AgentEventAsyncTaskService in method public KeepAliveService(agentEventAsyncTask AgentEventAsyncTaskService, agentLifeCycleAsyncTask AgentLifeCycleAsyncTaskService) in class com.navercorp.pinpoint.collector.receiver.grpc.service.KeepAliveService | From | To | |
| Rename Parameter agentId : String to id : String in method private validateId(id String) : String in class com.navercorp.pinpoint.grpc.AgentHeaderFactory.Header | From | To |