a8e95065925a376358b7e6b1d0039f049bccf189
Files Diff
- Added: 8
- Removed: 1
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type zookeeperClient : MockZookeeperClient to zookeeperClient : InMemoryZookeeperClient in method private waitZookeeperServerData(expectedServerDataCount int, zookeeperClient InMemoryZookeeperClient) : void in class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable streamObserver : StreamObserver<PCmdMessage> to responseObserver : StreamObserver<PCmdMessage> in method public handleCommand(requestObserver StreamObserver<PCmdRequest>) : StreamObserver<PCmdMessage> in class com.navercorp.pinpoint.collector.receiver.grpc.service.command.GrpcCommandService | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.navercorp.pinpoint.collector.cluster.zookeeper.ZookeeperJobWorkerTest.MockZookeeperClient moved and renamed to com.navercorp.pinpoint.collector.cluster.zookeeper.InMemoryZookeeperClient | From | To | |
| Move Class | 1 | ||
| Move Class com.navercorp.pinpoint.collector.receiver.grpc.service.GrpcCommandService moved to com.navercorp.pinpoint.collector.receiver.grpc.service.command.GrpcCommandService | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute channelMap : ConcurrentMap<Integer,StreamChannel> to streamChannelMap : ConcurrentMap<Integer,StreamChannel> in class com.navercorp.pinpoint.rpc.stream.StreamChannelRepository | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type recordedStreamObserver : RecordedStreamObserver to recordedStreamObserver : RecordedStreamObserver<PCmdRequest> in method public requestTest() : void in class com.navercorp.pinpoint.collector.receiver.grpc.PinpointGrpcServerTest | From | To | |
| Extract Method | 4 | ||
| Extract Method public createFailedFuture(failException Exception) : Future<ResponseMessage> extracted from public request(message GeneratedMessageV3) : Future<ResponseMessage> in class com.navercorp.pinpoint.collector.receiver.grpc.PinpointGrpcServer | From | To | |
| Extract Method public close(serverStop boolean) : void extracted from public disconnected() : void in class com.navercorp.pinpoint.collector.receiver.grpc.PinpointGrpcServer | From | To | |
| Extract Method private createRequest(message GeneratedMessageV3) : PCmdRequest extracted from public request(message GeneratedMessageV3) : Future<ResponseMessage> in class com.navercorp.pinpoint.collector.receiver.grpc.PinpointGrpcServer | From | To | |
| Extract Method public close(serverStop boolean) : void extracted from public close() : void in class com.navercorp.pinpoint.collector.receiver.grpc.PinpointGrpcServer | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public checkState(expectedState SocketStateCode) : boolean extracted from public request(message GeneratedMessageV3) : Future<ResponseMessage> in class com.navercorp.pinpoint.collector.receiver.grpc.PinpointGrpcServer & moved to class com.navercorp.pinpoint.rpc.common.SocketState | From | To | |
| Extract And Move Method public close(closeCode StreamCode) : void extracted from public close() : void in class com.navercorp.pinpoint.rpc.stream.StreamChannelManager & moved to class com.navercorp.pinpoint.rpc.stream.StreamChannelRepository | From | To | |
| Extract And Move Method public checkState(expectedState SocketStateCode) : boolean extracted from public handleMessage(responseId int, message GeneratedMessageV3) : void in class com.navercorp.pinpoint.collector.receiver.grpc.PinpointGrpcServer & moved to class com.navercorp.pinpoint.rpc.common.SocketState | From | To |