b51e033d244db59aae98013dfa0967ee08b9cfe6
Files Diff
- Added: 16
- Removed: 2
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public toTJvmGcType(value int) : TJvmGcType from class com.navercorp.pinpoint.profiler.monitor.collector.jvmgc.TJvmGcTypeUtils to private toJvmGcType(type PJvmGcType) : JvmGcType from class com.navercorp.pinpoint.collector.mapper.grpc.stat.GrpcJvmGcBoMapper | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass com.navercorp.pinpoint.profiler.sender.grpc.SpanGrpcDataSender from class com.navercorp.pinpoint.profiler.sender.grpc.GrpcDataSender | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type value : int to type : PJvmGcType in method private toJvmGcType(type PJvmGcType) : JvmGcType in class com.navercorp.pinpoint.collector.mapper.grpc.stat.GrpcJvmGcBoMapper | From | To | |
| Change Parameter Type gcTypeCode : int to jvmGcType : JvmGcType in method public JvmInformation(jvmVersion String, jvmGcType JvmGcType) in class com.navercorp.pinpoint.profiler.JvmInformation | From | To | |
| Move Method | 1 | ||
| Move Method private convertJvmGcType(jvmGcType JvmGcType) : TJvmGcType from class com.navercorp.pinpoint.profiler.context.thrift.StatThriftMessageConverter to private convertJvmGcType(jvmGcType JvmGcType) : TJvmGcType from class com.navercorp.pinpoint.profiler.context.thrift.JvmGcTypeThriftMessageConverter | From | To | |
| Push Down Attribute | 3 | ||
| Push Down Attribute private spanChunkStream : StreamObserver<PSpanChunk> from class com.navercorp.pinpoint.profiler.sender.grpc.GrpcDataSender to private spanChunkStream : StreamObserver<PSpanChunk> from class com.navercorp.pinpoint.profiler.sender.grpc.SpanGrpcDataSender | From | To | |
| Push Down Attribute private spanStub : SpanGrpc.SpanStub from class com.navercorp.pinpoint.profiler.sender.grpc.GrpcDataSender to private spanStub : SpanGrpc.SpanStub from class com.navercorp.pinpoint.profiler.sender.grpc.SpanGrpcDataSender | From | To | |
| Push Down Attribute private spanStream : StreamObserver<PSpan> from class com.navercorp.pinpoint.profiler.sender.grpc.GrpcDataSender to private spanStream : StreamObserver<PSpan> from class com.navercorp.pinpoint.profiler.sender.grpc.SpanGrpcDataSender | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.profiler.context.thrift.JvmGcTypeThriftMessageConverter from class com.navercorp.pinpoint.profiler.context.thrift.StatThriftMessageConverter | From | To | |
| Rename Class | 1 | ||
| Rename Class com.navercorp.pinpoint.profiler.context.provider.grpc.GrpcDataSenderProvider renamed to com.navercorp.pinpoint.profiler.context.provider.grpc.SpanGrpcDataSenderProvider | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type metadataMessageConverterKey : Key<MessageConverter<TBase<?,?>>> to metadataMessageConverterKey : Key<MessageConverter<GeneratedMessageV3>> in method protected configure() : void in class com.navercorp.pinpoint.profiler.context.module.GrpcModule | From | To | |
| Change Variable Type statMessageConverterKey : Key<MessageConverter<TBase<?,?>>> to statMessageConverterKey : Key<MessageConverter<GeneratedMessageV3>> in method protected configure() : void in class com.navercorp.pinpoint.profiler.context.module.GrpcModule | From | To | |
| Change Variable Type thriftMessageConverter : TypeLiteral<MessageConverter<TBase<?,?>>> to metadataMessageConverter : TypeLiteral<MessageConverter<GeneratedMessageV3>> in method protected configure() : void in class com.navercorp.pinpoint.profiler.context.module.GrpcModule | From | To | |
| Change Variable Type statMessageConverter : TypeLiteral<MessageConverter<TBase<?,?>>> to statMessageConverter : TypeLiteral<MessageConverter<GeneratedMessageV3>> in method protected configure() : void in class com.navercorp.pinpoint.profiler.context.module.GrpcModule | From | To | |
| Push Down Method | 3 | ||
| Push Down Method private newSpanStream() : StreamObserver<PSpan> from class com.navercorp.pinpoint.profiler.sender.grpc.GrpcDataSender to private newSpanStream() : StreamObserver<PSpan> from class com.navercorp.pinpoint.profiler.sender.grpc.SpanGrpcDataSender | From | To | |
| Push Down Method private send0(data Object) : boolean from class com.navercorp.pinpoint.profiler.sender.grpc.GrpcDataSender to public send0(data Object) : boolean from class com.navercorp.pinpoint.profiler.sender.grpc.SpanGrpcDataSender | From | To | |
| Push Down Method private newSpanChunkStream() : StreamObserver<PSpanChunk> from class com.navercorp.pinpoint.profiler.sender.grpc.GrpcDataSender to private newSpanChunkStream() : StreamObserver<PSpanChunk> from class com.navercorp.pinpoint.profiler.sender.grpc.SpanGrpcDataSender | From | To | |
| Rename Variable | 1 | ||
| Rename Variable thriftMessageConverter : TypeLiteral<MessageConverter<TBase<?,?>>> to metadataMessageConverter : TypeLiteral<MessageConverter<GeneratedMessageV3>> in method protected configure() : void in class com.navercorp.pinpoint.profiler.context.module.GrpcModule | From | To | |
| Change Return Type | 1 | ||
| Change Return Type TJvmGcType to JvmGcType in method private toJvmGcType(type PJvmGcType) : JvmGcType in class com.navercorp.pinpoint.collector.mapper.grpc.stat.GrpcJvmGcBoMapper | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute gcTypeCode : int to jvmGcType : JvmGcType in class com.navercorp.pinpoint.profiler.JvmInformation | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type gcTypeCode : int to jvmGcType : JvmGcType in class com.navercorp.pinpoint.profiler.JvmInformation | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter value : int to type : PJvmGcType in method private toJvmGcType(type PJvmGcType) : JvmGcType in class com.navercorp.pinpoint.collector.mapper.grpc.stat.GrpcJvmGcBoMapper | From | To | |
| Rename Parameter gcTypeCode : int to jvmGcType : JvmGcType in method public JvmInformation(jvmVersion String, jvmGcType JvmGcType) in class com.navercorp.pinpoint.profiler.JvmInformation | From | To |