pinpoint bae3a4d2dde8aeccd45cd697c77116f786e0c7f4

bae3a4d2dde8aeccd45cd697c77116f786e0c7f4

Files Diff

Added: 28
Removed: 5
Renamed: 0
Modified: 24

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method public recordParameter(spanRecorder SpanEventRecorder, request T) : void renamed to public record(spanRecorder SpanEventRecorder, request T, throwable Throwable) : void in class com.navercorp.pinpoint.bootstrap.plugin.request.util.HttpParameterRecorder	From	To
Rename Method public recordParameter(spanRecorder SpanEventRecorder, request T) : void renamed to public record(spanRecorder SpanEventRecorder, request T, throwable Throwable) : void in class com.navercorp.pinpoint.bootstrap.plugin.request.util.ParameterRecorder	From	To
Move And Rename Method	5
Move And Rename Method public getCookieValue() : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestWrapper to public getCookie(cookie HttpRequest) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4CookieExtractor	From	To
Move And Rename Method public getCookieValue() : String from class com.navercorp.pinpoint.plugin.vertx.VertxHttpClientRequestWrapper to public getCookie(httpRequest HttpRequest) : String from class com.navercorp.pinpoint.plugin.vertx.VertxCookieExtractor	From	To
Move And Rename Method public getCookieValue() : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestWrapper to public getCookie(httpMethod HttpMethod) : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3CookieExtractor	From	To
Move And Rename Method public getEntityValue() : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestWrapper to public getEntity(httpMethod HttpMethod) : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3EntityExtractor	From	To
Move And Rename Method public getEntityValue() : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestWrapper to public getEntity(httpRequest HttpRequest) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4EntityExtractor	From	To
Change Parameter Type	3
Change Parameter Type clientRequestWrapper : ClientRequestWrapper to cookie : T in method private recordCookie(recorder SpanEventRecorder, cookie T) : void in class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultCookieRecorder	From	To
Change Parameter Type clientRequestWrapper : ClientRequestWrapper to entity : T in method private recordEntity(recorder SpanEventRecorder, entity T) : void in class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultEntityRecorder	From	To
Change Parameter Type httpDumpConfig : HttpDumpConfig to clientRequestAdaptor : ClientRequestAdaptor<T> in method public ClientRequestRecorder(param boolean, clientRequestAdaptor ClientRequestAdaptor<T>) in class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Move Method	5
Move Method private recordCookie(recorder SpanEventRecorder, clientRequestWrapper ClientRequestWrapper) : void from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder to private recordCookie(recorder SpanEventRecorder, cookie T) : void from class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultCookieRecorder	From	To
Move Method private recordEntity(recorder SpanEventRecorder, clientRequestWrapper ClientRequestWrapper) : void from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder to private recordEntity(recorder SpanEventRecorder, entity T) : void from class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultEntityRecorder	From	To
Move Method private entityUtilsToString(entity HttpEntity, defaultCharset String, maxLength int) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestWrapper to private entityUtilsToString(entity HttpEntity, defaultCharset String, maxLength int) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4EntityExtractor	From	To
Move Method private entityUtilsToString(entity RequestEntity, charSet String) : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestWrapper to private entityUtilsToString(entity RequestEntity, charSet String) : String from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3EntityExtractor	From	To
Move Method public getContentCharSet(entity HttpEntity) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestWrapper to private getContentCharSet(entity HttpEntity) : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4EntityExtractor	From	To
Move Attribute	5
Move Attribute private httpDumpConfig : HttpDumpConfig from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder to private httpDumpConfig : HttpDumpConfig from class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultCookieRecorder	From	To
Move Attribute private httpDumpConfig : HttpDumpConfig from class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder to private httpDumpConfig : HttpDumpConfig from class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultEntityRecorder	From	To
Move Attribute private logger : PLogger from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestWrapper to private logger : PLogger from class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultCookieRecorder	From	To
Move Attribute private MAX_READ_SIZE : int from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3RequestWrapper to private MAX_READ_SIZE : int from class com.navercorp.pinpoint.plugin.httpclient3.HttpClient3EntityExtractor	From	To
Move Attribute private isDebug : boolean from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestWrapper to private isDebug : boolean from class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultCookieRecorder	From	To
Extract Class	2
Extract Class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultCookieRecorder from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestWrapper	From	To
Extract Class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4EntityExtractor from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestWrapper	From	To
Rename Attribute	1
Rename Attribute httpDumpConfig : HttpDumpConfig to clientRequestAdaptor : ClientRequestAdaptor<T> in class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Extract Variable	4
Extract Variable clientRequest : ClientRequestWrapper in method public after(target Object, args Object[], result Object, throwable Throwable) : void from class com.navercorp.pinpoint.plugin.vertx.interceptor.HttpClientStreamInterceptor	From	To
Extract Variable clientRequest : ClientRequestWrapper in method public after(target Object, args Object[], result Object, throwable Throwable) : void from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.DefaultClientExchangeHandlerImplStartMethodInterceptor	From	To
Extract Variable requestLine : RequestLine in method public getUrl() : String from class com.navercorp.pinpoint.plugin.httpclient4.HttpClient4RequestWrapper	From	To
Extract Variable clientRequest : ClientRequestWrapper in method public after(target Object, args Object[], result Object, throwable Throwable) : void from class com.navercorp.pinpoint.plugin.httpclient4.interceptor.HttpRequestExecutorExecuteMethodInterceptor	From	To
Change Attribute Type	12
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<Request> in class com.navercorp.pinpoint.plugin.ning.asynchttpclient.interceptor.ExecuteRequestInterceptor	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<Request> in class com.navercorp.pinpoint.plugin.okhttp.v3.interceptor.HttpEngineSendRequestMethodInterceptor	From	To
Change Attribute Type httpDumpConfig : HttpDumpConfig to clientRequestAdaptor : ClientRequestAdaptor<T> in class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<Request> in class com.navercorp.pinpoint.plugin.okhttp.v2.interceptor.HttpEngineSendRequestMethodInterceptor	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<ClientRequestWrapper> in class com.navercorp.pinpoint.plugin.httpclient4.interceptor.HttpRequestExecutorExecuteMethodInterceptor	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<Request> in class com.navercorp.pinpoint.plugin.okhttp.v3.interceptor.BridgeInterceptorInterceptMethodInterceptor	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<ClientRequestWrapper> in class com.navercorp.pinpoint.plugin.httpclient4.interceptor.DefaultClientExchangeHandlerImplStartMethodInterceptor	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<ClientRequestWrapper> in class com.navercorp.pinpoint.plugin.httpclient3.interceptor.HttpMethodBaseExecuteMethodInterceptor	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<ClientRequestWrapper> in class com.navercorp.pinpoint.plugin.netty.interceptor.http.HttpEncoderInterceptor	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<HttpURLConnection> in class com.navercorp.pinpoint.plugin.jdk.http.interceptor.HttpURLConnectionInterceptor	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<Request> in class com.navercorp.pinpoint.plugin.ning.asynchttpclient.interceptor.ExecuteInterceptor	From	To
Change Attribute Type clientRequestRecorder : ClientRequestRecorder to clientRequestRecorder : ClientRequestRecorder<ClientRequestWrapper> in class com.navercorp.pinpoint.plugin.vertx.interceptor.HttpClientStreamInterceptor	From	To
Rename Parameter	4
Rename Parameter clientRequestWrapper : ClientRequestWrapper to cookie : T in method private recordCookie(recorder SpanEventRecorder, cookie T) : void in class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultCookieRecorder	From	To
Rename Parameter clientRequestWrapper : ClientRequestWrapper to entity : T in method private recordEntity(recorder SpanEventRecorder, entity T) : void in class com.navercorp.pinpoint.bootstrap.plugin.request.util.DefaultEntityRecorder	From	To
Rename Parameter httpDumpConfig : HttpDumpConfig to clientRequestAdaptor : ClientRequestAdaptor<T> in method public ClientRequestRecorder(param boolean, clientRequestAdaptor ClientRequestAdaptor<T>) in class com.navercorp.pinpoint.bootstrap.plugin.request.ClientRequestRecorder	From	To
Rename Parameter request : T to header : T in method public setHeader(header T, name String, value String) : void in class com.navercorp.pinpoint.bootstrap.plugin.request.ClientHeaderAdaptor	From	To

bae3a4d2dde8aeccd45cd697c77116f786e0c7f4

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: