beeb4126470a459404963770ce53a86e0a66b805
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public onDisconnect(code SocketStateCode) : boolean renamed to public onClose(code SocketStateCode) : boolean in class com.navercorp.pinpoint.rpc.common.SocketStateCode | From | To | |
| Rename Method private messageReceivedHandshakeResponse(message ControlHandshakeResponsePacket, channel Channel) : void renamed to private handleHandshakePacket(message ControlHandshakeResponsePacket, channel Channel) : void in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private stateTo(nextState SocketStateCode) : SocketStateChangeResult from class com.navercorp.pinpoint.rpc.server.DefaultPinpointServer to private to(nextState SocketStateCode) : SocketStateChangeResult from class com.navercorp.pinpoint.rpc.server.DefaultPinpointServerState | From | To | |
| Move Method | 1 | ||
| Move Method private executeChangeEventHandler(pinpointServer DefaultPinpointServer, nextState SocketStateCode) : void from class com.navercorp.pinpoint.rpc.server.DefaultPinpointServer to private executeChangeEventHandler(pinpointServer DefaultPinpointServer, nextState SocketStateCode) : void from class com.navercorp.pinpoint.rpc.server.DefaultPinpointServerState | From | To | |
| Rename Variable | 3 | ||
| Rename Variable currentState : int to currentStateCode : SocketStateCode in method public channelClosed(ctx ChannelHandlerContext, e ChannelStateEvent) : void in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Rename Variable run : boolean to isEnable : boolean in method public request(bytes byte[]) : Future<ResponseMessage> in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Rename Variable currentState : int to currentStateCode : SocketStateCode in method private ensureOpen() : void in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Inline Method | 1 | ||
| Inline Method package isRun() : boolean inlined to public request(bytes byte[]) : Future<ResponseMessage> in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type currentState : int to currentStateCode : SocketStateCode in method public channelClosed(ctx ChannelHandlerContext, e ChannelStateEvent) : void in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Change Variable Type currentState : int to currentStateCode : SocketStateCode in method private ensureOpen() : void in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Extract Method | 3 | ||
| Extract Method private closeChannel() : void extracted from public close() : void in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Extract Method public getCurrentStateCode() : SocketStateCode extracted from public channelClosed(ctx ChannelHandlerContext, e ChannelStateEvent) : void in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Extract Method public getCurrentStateCode() : SocketStateCode extracted from private ensureOpen() : void in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type state : SocketState to state : DefaultPinpointServerState in class com.navercorp.pinpoint.rpc.server.DefaultPinpointServer | From | To | |
| Change Attribute Type state : State to state : PinpointSocketHandlerState in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To |