c7745a31e12508a1fdd0915dc099695b2e855da1
Files Diff
- Added: 36
- Removed: 12
- Renamed: 0
- Modified: 32
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 5 | ||
| Change Parameter Type classLoaderType : Class to classLoaderType : Class<?> in method private onLoadTest(classLoaderType Class<?>, testClass Class) : ClassLoader in class com.navercorp.pinpoint.bootstrap.java9.classloader.Java9ClassLoaderTest | From | To | |
| Change Parameter Type defaultValue : List<String> to defaultValue : String in method public getManifestValue(jarFile JarFile, key String, defaultValue String) : String in class com.navercorp.pinpoint.common.plugin.JarFileUtils | From | To | |
| Change Parameter Type libClass : LibClass to libClass : List<String> in method public Java9ClassLoader(name String, urls URL[], parent ClassLoader, libClass List<String>) in class com.navercorp.pinpoint.bootstrap.java9.classloader.Java9ClassLoader | From | To | |
| Change Parameter Type libClass : LibClass to libClass : List<String> in method public Java6ClassLoader(name String, urls URL[], parent ClassLoader, libClass List<String>) in class com.navercorp.pinpoint.bootstrap.classloader.Java6ClassLoader | From | To | |
| Change Parameter Type libClass : LibClass to libClass : List<String> in method public ParallelClassLoader(name String, urls URL[], parent ClassLoader, libClass List<String>) in class com.navercorp.pinpoint.bootstrap.classloader.ParallelClassLoader | From | To | |
| Move Method | 1 | ||
| Move Method private createClassLoader(urls URL[], parentClassLoader ClassLoader) : ClassLoader from class com.navercorp.pinpoint.bootstrap.AgentBootLoader to private createClassLoader(name String, urls URL[], parentClassLoader ClassLoader) : ClassLoader from class com.navercorp.pinpoint.bootstrap.PinpointStarter | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.bootstrap.java9.classloader.ProfilerLibClass from class com.navercorp.pinpoint.bootstrap.classloader.Java9ClassLoader | From | To | |
| Rename Class | 1 | ||
| Rename Class com.navercorp.pinpoint.bootstrap.classloader.InnerClassLoaderFactory renamed to com.navercorp.pinpoint.bootstrap.classloader.ClassLoaderFactory | From | To | |
| Move And Rename Class | 2 | ||
| Move And Rename Class com.navercorp.pinpoint.bootstrap.module.Java9ModuleSupportFactory moved and renamed to com.navercorp.pinpoint.bootstrap.java9.module.ModuleSupportFactory | From | To | |
| Move And Rename Class com.navercorp.pinpoint.bootstrap.module.ModuleSupport moved and renamed to com.navercorp.pinpoint.bootstrap.java9.module.PackageAnalyzer | From | To | |
| Move Class | 5 | ||
| Move Class com.navercorp.pinpoint.bootstrap.classloader.PlatformClassLoaderTest moved to com.navercorp.pinpoint.bootstrap.java9.classloader.PlatformClassLoaderTest | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.classloader.Java9BootLoader moved to com.navercorp.pinpoint.bootstrap.java9.classloader.Java9BootLoader | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.classloader.Java9BootLoaderTest moved to com.navercorp.pinpoint.bootstrap.java9.classloader.Java9BootLoaderTest | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.classloader.Java9ClassLoaderTest moved to com.navercorp.pinpoint.bootstrap.java9.classloader.Java9ClassLoaderTest | From | To | |
| Move Class com.navercorp.pinpoint.bootstrap.classloader.Java9ClassLoader moved to com.navercorp.pinpoint.bootstrap.java9.classloader.Java9ClassLoader | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type bootLoader : BootLoader to bootLoader : Java9BootLoader in method public testFindResources() : void in class com.navercorp.pinpoint.bootstrap.java9.classloader.Java9BootLoaderTest | From | To | |
| Change Variable Type libClassFilter : LibClass to lib : List<String> in method private createContextTypeMatchClassLoader(urlArray URL[]) : ClassLoader in class com.navercorp.pinpoint.profiler.instrument.classloading.JarProfilerPluginClassInjectorTest | From | To | |
| Change Variable Type bootLoader : BootLoader to bootLoader : Java9BootLoader in method public testFindResource() : void in class com.navercorp.pinpoint.bootstrap.java9.classloader.Java9BootLoaderTest | From | To | |
| Extract Method | 2 | ||
| Extract Method private loadModuleBootLoader(instrumentation Instrumentation, parentClassLoader ClassLoader) : ModuleBootLoader extracted from public premain(agentArgs String, instrumentation Instrumentation) : void in class com.navercorp.pinpoint.bootstrap.PinpointBootStrap | From | To | |
| Extract Method public getPackageName(fqcn String, packageSeparator char, defaultValue String) : String extracted from public getPackageName(fqcn String) : String in class com.navercorp.pinpoint.common.util.ClassUtils | From | To | |
| Rename Method | 4 | ||
| Rename Method public createURLClassLoader(urls URL[], parent ClassLoader) : ClassLoader renamed to public createClassLoader(name String, urls URL[], parent ClassLoader, libClass List<String>) : ClassLoader in class com.navercorp.pinpoint.bootstrap.classloader.Java6ClassLoaderFactory | From | To | |
| Rename Method public createURLClassLoader(urls URL[], parent ClassLoader) : ClassLoader renamed to public createClassLoader(name String, urls URL[], parent ClassLoader, libClass List<String>) : ClassLoader in class com.navercorp.pinpoint.bootstrap.classloader.ClassLoaderFactory | From | To | |
| Rename Method public createURLClassLoader(urls URL[], parent ClassLoader) : ClassLoader renamed to public createClassLoader(name String, urls URL[], parent ClassLoader, libClass List<String>) : ClassLoader in class com.navercorp.pinpoint.bootstrap.classloader.ParallelClassLoaderFactory | From | To | |
| Rename Method public readManifestToList(jarFile JarFile, key String, defaultValue List<String>) : List<String> renamed to public getManifestValue(jarFile JarFile, key String, defaultValue String) : String in class com.navercorp.pinpoint.common.plugin.JarFileUtils | From | To | |
| Rename Variable | 2 | ||
| Rename Variable systemClassLoader : ClassLoader to bootstrapClassLoader : ClassLoader in method public injectClass(classLoader ClassLoader, className String) : Class<? extends T> in class com.navercorp.pinpoint.profiler.instrument.classloading.PlainClassLoaderHandler | From | To | |
| Rename Variable libClassFilter : LibClass to lib : List<String> in method private createContextTypeMatchClassLoader(urlArray URL[]) : ClassLoader in class com.navercorp.pinpoint.profiler.instrument.classloading.JarProfilerPluginClassInjectorTest | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to List<String> in method private findRequiredLibraries(urls URL[]) : List<String> in class com.navercorp.pinpoint.test.plugin.AbstractPinpointPluginTestSuite | From | To | |
| Change Return Type InnerClassLoaderFactory to ClassLoaderFactory in method private newClassLoaderFactory(factoryName String) : ClassLoaderFactory in class com.navercorp.pinpoint.bootstrap.classloader.PinpointClassLoaderFactory | From | To | |
| Change Return Type List<String> to String in method public getManifestValue(jarFile JarFile, key String, defaultValue String) : String in class com.navercorp.pinpoint.common.plugin.JarFileUtils | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute libClass : LibClass to profilerLibClass : ProfilerLibClass in class com.navercorp.pinpoint.bootstrap.java9.classloader.Java9ClassLoader | From | To | |
| Rename Attribute PINPOINT_PROFILER_CLASS : String[] to profilerClass : String[] in class com.navercorp.pinpoint.bootstrap.classloader.ProfilerLibClass | From | To | |
| Change Attribute Type | 6 | ||
| Change Attribute Type totalValue : LongAdder to totalValue : Counter in class com.navercorp.pinpoint.profiler.monitor.metric.response.ReuseResponseTimeCollector.ResponseTimeCollector | From | To | |
| Change Attribute Type CLASS_LOADER_FACTORY : InnerClassLoaderFactory to CLASS_LOADER_FACTORY : ClassLoaderFactory in class com.navercorp.pinpoint.bootstrap.classloader.PinpointClassLoaderFactory | From | To | |
| Change Attribute Type DEFAULT_PINPOINT_PLUGIN_PACKAGE_NAME : List<String> to DEFAULT_PINPOINT_PLUGIN_PACKAGE_NAME : String in class com.navercorp.pinpoint.profiler.plugin.PluginConfig | From | To | |
| Change Attribute Type transactionCount : LongAdder to transactionCount : Counter in class com.navercorp.pinpoint.profiler.monitor.metric.response.ReuseResponseTimeCollector.ResponseTimeCollector | From | To | |
| Change Attribute Type libClass : LibClass to profilerLibClass : ProfilerLibClass in class com.navercorp.pinpoint.bootstrap.java9.classloader.Java9ClassLoader | From | To | |
| Change Attribute Type bootLoader : BootLoader to bootLoader : Java9BootLoader in class com.navercorp.pinpoint.bootstrap.java9.classloader.Java9ClassLoader | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter parentClassLoader : ClassLoader to agentClassLoader : ClassLoader in method public AgentBootLoader(bootClass String, urls URL[], agentClassLoader ClassLoader) in class com.navercorp.pinpoint.bootstrap.AgentBootLoader | From | To |