pinpoint c8043f6151382f95284fbf2e7508b10df225a53b

c8043f6151382f95284fbf2e7508b10df225a53b

Files Diff

Added: 7
Removed: 2
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	2
Move And Rename Method private isValidId(propertyName String, maxSize int) : boolean from class com.navercorp.pinpoint.bootstrap.PinpointStarter to private getValidId(propertyName String, maxSize int) : String from class com.navercorp.pinpoint.bootstrap.IdValidator	From	To
Move And Rename Method private parseAgentArgs(str String) : Map<String,String> from class com.navercorp.pinpoint.bootstrap.PinpointStarter to public parse(args String) : Map<String,String> from class com.navercorp.pinpoint.bootstrap.ArgsParser	From	To
Extract Subclass	1
Extract Subclass com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver from class com.navercorp.pinpoint.bootstrap.ClassPathResolver	From	To
Move Method	2
Move Method private getLength(value String) : int from class com.navercorp.pinpoint.bootstrap.PinpointStarter to public getLength(id String) : int from class com.navercorp.pinpoint.bootstrap.util.IdValidateUtils	From	To
Move Method private getJarFile(jarFilePath String) : JarFile from class com.navercorp.pinpoint.bootstrap.PinpointBootStrap to private getJarFile(jarFilePath String) : JarFile from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Move Attribute	2
Move Attribute private STATE_NONE : boolean from class com.navercorp.pinpoint.bootstrap.PinpointBootStrap to private STATE_NONE : boolean from class com.navercorp.pinpoint.bootstrap.LoadState	From	To
Move Attribute private STATE_STARTED : boolean from class com.navercorp.pinpoint.bootstrap.PinpointBootStrap to private STATE_STARTED : boolean from class com.navercorp.pinpoint.bootstrap.LoadState	From	To
Push Down Attribute	17
Push Down Attribute private agentCorePattern : Pattern from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private agentCorePattern : Pattern from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private DEFAULT_AGENT_COMMONS_PATTERN : Pattern from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private DEFAULT_AGENT_COMMONS_PATTERN : Pattern from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private DEFAULT_AGENT_CORE_PATTERN : Pattern from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private DEFAULT_AGENT_CORE_PATTERN : Pattern from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private DEFAULT_AGENT_CORE_OPTIONAL_PATTERN : Pattern from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private DEFAULT_AGENT_CORE_OPTIONAL_PATTERN : Pattern from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private DEFAULT_AGENT_PATTERN : Pattern from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private DEFAULT_AGENT_PATTERN : Pattern from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private bootStrapCoreOptionalJar : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private bootStrapCoreOptionalJar : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private logger : BootLogger from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private logger : BootLogger from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private fileExtensionList : List<String> from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private fileExtensionList : List<String> from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private agentJarName : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private agentJarName : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private agentJarFullPath : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private agentJarFullPath : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private agentCommonsPattern : Pattern from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private agentCommonsPattern : Pattern from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private bootStrapCoreJar : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private bootStrapCoreJar : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private classPath : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private classPath : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private agentCoreOptionalPattern : Pattern from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private agentCoreOptionalPattern : Pattern from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private agentDirPath : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private agentDirPath : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private pinpointCommonsJar : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private pinpointCommonsJar : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Attribute private agentPattern : Pattern from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private agentPattern : Pattern from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Extract Class	1
Extract Class com.navercorp.pinpoint.bootstrap.LoadState from class com.navercorp.pinpoint.bootstrap.PinpointBootStrap	From	To
Rename Class	1
Rename Class com.navercorp.pinpoint.bootstrap.ClassPathResolverTest renamed to com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolverTest	From	To
Change Variable Type	3
Change Variable Type classPathResolver : ClassPathResolver to classPathResolver : AgentDirBaseClassPathResolver in method private findAgentJarAssertFail(path String) : void in class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolverTest	From	To
Change Variable Type classPathResolver : ClassPathResolver to classPathResolver : AgentDirBaseClassPathResolver in method private findAgentJar(path String) : void in class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolverTest	From	To
Change Variable Type classPathResolver : ClassPathResolver to classPathResolver : AgentDirBaseClassPathResolver in method public testFindAgentJar() : void in class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolverTest	From	To
Extract Method	2
Extract Method public checkPattern(id String) : boolean extracted from public validateId(id String, maxLength int) : boolean in class com.navercorp.pinpoint.bootstrap.util.IdValidateUtils	From	To
Extract Method private listFiles(name String, pattern Pattern, bootDirPath String) : File[] extracted from private findFromBootDir(name String, pattern Pattern) : String in class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Rename Method	2
Rename Method public getAgentArgs() : String renamed to public getAgentId() : String in class com.navercorp.pinpoint.bootstrap.AgentOption	From	To
Rename Method public getAgentArgs() : String renamed to public getAgentId() : String in class com.navercorp.pinpoint.bootstrap.DefaultAgentOption	From	To
Push Down Method	26
Push Down Method public resolveLib() : List<URL> from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public resolveLib() : List<URL> from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getPinpointCommonsJar() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getPinpointCommonsJar() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getAgentLogFilePath() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getAgentLogFilePath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getClassPathFromSystemProperty() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getClassPathFromSystemProperty() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getAgentJarFullPath() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getAgentJarFullPath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getBootStrapCoreJar() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getBootStrapCoreJar() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method private findFromBootDir(name String, pattern Pattern) : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private findFromBootDir(name String, pattern Pattern) : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method private parseAgentJarPath(classPath String, agentJar String) : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private parseAgentJarPath(classPath String, agentJar String) : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public ClassPathResolver() from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public AgentDirBaseClassPathResolver() from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public findAgentJar() : boolean from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to package findAgentJar() : boolean from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method private parseAgentJar(matcher Matcher) : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private parseAgentJar(matcher Matcher) : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method private toURI(file File) : URL from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private toURI(file File) : URL from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method private findjar(libDir File) : File[] from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private findJar(libDir File) : File[] from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getAgentJarName() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getAgentJarName() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public resolvePlugins() : URL[] from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public resolvePlugins() : URL[] from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public setClassPath(classPath String) : void from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public setClassPathFromSystemProperty() : void from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public ClassPathResolver(classPath String) from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public AgentDirBaseClassPathResolver(classPath String) from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getDefaultFileExtensionList() : List<String> from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getDefaultFileExtensionList() : List<String> from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getAgentDirPath() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getAgentDirPath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getBootStrapCoreOptionalJar() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getBootStrapCoreOptionalJar() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public setClassPathFromSystemProperty() : void from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public setClassPathFromSystemProperty() : void from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public ClassPathResolver(classPath String, agentPattern String) from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public AgentDirBaseClassPathResolver(classPath String, agentPattern String) from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getAgentConfigPath() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getAgentConfigPath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getAgentPluginPath() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getAgentPluginPath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public parseAgentDirPath(agentJarFullPath String) : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to private parseAgentDirPath(agentJarFullPath String) : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Push Down Method public getAgentLibPath() : String from class com.navercorp.pinpoint.bootstrap.ClassPathResolver to public getAgentLibPath() : String from class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolver	From	To
Change Return Type	2
Change Return Type boolean to String in method private getValidId(propertyName String, maxSize int) : String in class com.navercorp.pinpoint.bootstrap.IdValidator	From	To
Change Return Type void to boolean in method public start() : boolean in class com.navercorp.pinpoint.bootstrap.PinpointStarter	From	To
Replace Variable With Attribute	1
Replace Variable With Attribute path : String to agentBootstrapPath : String in method public testFindAgentJar() : void in class com.navercorp.pinpoint.bootstrap.AgentDirBaseClassPathResolverTest	From	To
Rename Attribute	2
Rename Attribute bootstrapJars : List<String> to bootstrapJarFile : BootstrapJarFile in class com.navercorp.pinpoint.bootstrap.PinpointStarter	From	To
Rename Attribute agentArgs : String to agentId : String in class com.navercorp.pinpoint.bootstrap.DefaultAgentOption	From	To
Change Attribute Type	2
Change Attribute Type agentArgs : String to agentArgs : Map<String,String> in class com.navercorp.pinpoint.bootstrap.PinpointStarter	From	To
Change Attribute Type bootstrapJars : List<String> to bootstrapJarFile : BootstrapJarFile in class com.navercorp.pinpoint.bootstrap.PinpointStarter	From	To
Rename Parameter	2
Rename Parameter str : String to args : String in method public parse(args String) : Map<String,String> in class com.navercorp.pinpoint.bootstrap.ArgsParser	From	To
Rename Parameter value : String to id : String in method public getLength(id String) : int in class com.navercorp.pinpoint.bootstrap.util.IdValidateUtils	From	To

c8043f6151382f95284fbf2e7508b10df225a53b

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: