pinpoint cb7169cecfe97efe1312492297fe16ef7ace09bc

cb7169cecfe97efe1312492297fe16ef7ace09bc

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 5

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	2
Extract Subclass com.navercorp.pinpoint.rpc.stream.NettyClientStreamChannel from class com.navercorp.pinpoint.rpc.stream.ClientStreamChannel	From	To
Extract Subclass com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel from class com.navercorp.pinpoint.rpc.stream.StreamChannel	From	To
Move Method	1
Move Method public getRemoteAddress() : SocketAddress from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public getRemoteAddress() : SocketAddress from class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel	From	To
Push Down Attribute	7
Push Down Attribute private streamChannelId : int from class com.navercorp.pinpoint.rpc.stream.StreamChannel to private streamChannelId : int from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Attribute protected streamChannelRepository : StreamChannelRepository from class com.navercorp.pinpoint.rpc.stream.StreamChannel to protected streamChannelRepository : StreamChannelRepository from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Attribute protected logger : Logger from class com.navercorp.pinpoint.rpc.stream.StreamChannel to protected logger : Logger from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Attribute private attribute : ConcurrentHashMap<String,Object> from class com.navercorp.pinpoint.rpc.stream.StreamChannel to private attribute : ConcurrentHashMap<String,Object> from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Attribute private streamChannelEventHandler : ClientStreamChannelEventHandler from class com.navercorp.pinpoint.rpc.stream.ClientStreamChannel to private streamChannelEventHandler : ClientStreamChannelEventHandler from class com.navercorp.pinpoint.rpc.stream.NettyClientStreamChannel	From	To
Push Down Attribute private openLatch : CountDownLatch from class com.navercorp.pinpoint.rpc.stream.StreamChannel to private openLatch : CountDownLatch from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Attribute protected state : StreamChannelState from class com.navercorp.pinpoint.rpc.stream.StreamChannel to protected state : StreamChannelState from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Move Attribute	1
Move Attribute protected channel : Channel from class com.navercorp.pinpoint.rpc.stream.StreamChannel to private channel : Channel from class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel	From	To
Change Variable Type	4
Change Variable Type newStreamChannel : ClientStreamChannel to newStreamChannel : NettyClientStreamChannel in method public openStream(payload byte[], streamChannelEventHandler ClientStreamChannelEventHandler) : ClientStreamChannel in class com.navercorp.pinpoint.rpc.stream.StreamChannelManager	From	To
Change Variable Type sc : ClientStreamChannel to sc : NettyClientStreamChannel in method public testName() : void in class com.navercorp.pinpoint.rpc.stream.StreamChannelTest	From	To
Change Variable Type dataPacket : StreamResponsePacket to packet : StreamPacket in method package write(expectedCode StreamChannelStateCode, packet StreamPacket) : void in class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel	From	To
Change Variable Type sc : ClientStreamChannel to sc : NettyClientStreamChannel in method public stateChangeTest() : void in class com.navercorp.pinpoint.rpc.stream.StreamChannelTest	From	To
Extract Method	2
Extract Method package write(expectedCode StreamChannelStateCode, packet StreamPacket) : void extracted from public sendData(payload byte[]) : ChannelFuture in class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel	From	To
Extract Method package write(expectedCode StreamChannelStateCode, packet StreamPacket) : void extracted from public sendCreateSuccess() : ChannelFuture in class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel	From	To
Push Down Method	28
Push Down Method private sendClose(streamChannelId int, code StreamCode) : ChannelFuture from class com.navercorp.pinpoint.rpc.stream.StreamChannel to private sendClose(streamChannelId int, code StreamCode) : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method package changeStateConnected() : boolean from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public changeStateConnected() : boolean from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public setAttributeIfAbsent(key String, value Object) : Object from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public setAttributeIfAbsent(key String, value Object) : Object from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public getAttribute(key String) : Object from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public getAttribute(key String) : Object from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public sendPong(requestId int) : ChannelFuture from class com.navercorp.pinpoint.rpc.stream.StreamChannel to private sendClose(streamChannelId int, code StreamCode) : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public StreamChannel(channel Channel, streamId int, streamChannelRepository StreamChannelRepository) from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public AbstractStreamChannel(streamId int, streamChannelRepository StreamChannelRepository) from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method package getStateChangeEventHandler() : StreamChannelStateChangeEventHandler from class com.navercorp.pinpoint.rpc.stream.ClientStreamChannel to package getStateChangeEventHandler() : StreamChannelStateChangeEventHandler from class com.navercorp.pinpoint.rpc.stream.NettyClientStreamChannel	From	To
Push Down Method public disconnect(streamCode StreamCode) : void from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public disconnect(streamCode StreamCode) : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public close(streamPacket StreamPacket) : void from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public close(streamPacket StreamPacket) : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method protected changeStateTo(currentState StreamChannelStateCode, nextState StreamChannelStateCode) : boolean from class com.navercorp.pinpoint.rpc.stream.StreamChannel to protected changeStateTo(currentState StreamChannelStateCode, nextState StreamChannelStateCode) : boolean from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public handleStreamClosePacket(packet StreamClosePacket) : void from class com.navercorp.pinpoint.rpc.stream.ClientStreamChannel to public handleStreamClosePacket(packet StreamClosePacket) : void from class com.navercorp.pinpoint.rpc.stream.NettyClientStreamChannel	From	To
Push Down Method public removeAttribute(key String) : Object from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public removeAttribute(key String) : Object from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method protected changeStateTo(nextState StreamChannelStateCode, throwException boolean) : boolean from class com.navercorp.pinpoint.rpc.stream.StreamChannel to protected changeStateTo(nextState StreamChannelStateCode, throwException boolean) : boolean from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method protected changeStateTo(nextState StreamChannelStateCode) : boolean from class com.navercorp.pinpoint.rpc.stream.StreamChannel to protected changeStateTo(nextState StreamChannelStateCode) : boolean from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public getCurrentState() : StreamChannelStateCode from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public getCurrentState() : StreamChannelStateCode from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public getStreamId() : int from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public getStreamId() : int from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public handleStreamResponsePacket(packet StreamResponsePacket) : void from class com.navercorp.pinpoint.rpc.stream.ClientStreamChannel to public handleStreamResponsePacket(packet StreamResponsePacket) : void from class com.navercorp.pinpoint.rpc.stream.NettyClientStreamChannel	From	To
Push Down Method package abstract getStateChangeEventHandler() : StreamChannelStateChangeEventHandler from class com.navercorp.pinpoint.rpc.stream.StreamChannel to package abstract getStateChangeEventHandler() : StreamChannelStateChangeEventHandler from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public close() : void from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public close() : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public sendPing(requestId int) : ChannelFuture from class com.navercorp.pinpoint.rpc.stream.StreamChannel to private sendClose(streamChannelId int, code StreamCode) : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public awaitOpen(timeoutMillis long) : boolean from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public awaitOpen(timeoutMillis long) : boolean from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public connect(payload byte[], timeout long) : void from class com.navercorp.pinpoint.rpc.stream.ClientStreamChannel to public connect(payload byte[], timeout long) : void from class com.navercorp.pinpoint.rpc.stream.NettyClientStreamChannel	From	To
Push Down Method private clearStreamChannelResource() : void from class com.navercorp.pinpoint.rpc.stream.StreamChannel to private clearStreamChannelResource() : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public disconnect() : void from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public disconnect() : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method package init() : void from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public init() : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public close(code StreamCode) : void from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public close(code StreamCode) : void from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method private changeStateClose() : boolean from class com.navercorp.pinpoint.rpc.stream.StreamChannel to private changeStateClose() : boolean from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Push Down Method public toString() : String from class com.navercorp.pinpoint.rpc.stream.StreamChannel to public toString() : String from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Pull Up Method	1
Pull Up Method public toString() : String from class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel to public toString() : String from class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Rename Variable	1
Rename Variable dataPacket : StreamResponsePacket to packet : StreamResponsePacket in method public sendData(payload byte[]) : void in class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel	From	To
Change Return Type	5
Change Return Type ChannelFuture to void in method private sendClose(streamChannelId int, code StreamCode) : void in class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To
Change Return Type ChannelFuture to void in method public sendData(payload byte[]) : void in class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel	From	To
Change Return Type ChannelFuture to void in method public sendCreateSuccess() : void in class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel	From	To
Parameterize Variable	1
Parameterize Variable dataPacket : StreamResponsePacket to packet : StreamPacket in method package write(expectedCode StreamChannelStateCode, packet StreamPacket) : void in class com.navercorp.pinpoint.rpc.stream.ServerStreamChannel	From	To
Extract Superclass	1
Extract Superclass com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel from classes [com.navercorp.pinpoint.rpc.stream.ServerStreamChannel]	From	To
Rename Parameter	2
Rename Parameter requestId : int to streamChannelId : int in method private sendClose(streamChannelId int, code StreamCode) : void in class com.navercorp.pinpoint.rpc.stream.AbstractStreamChannel	From	To

cb7169cecfe97efe1312492297fe16ef7ace09bc

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: