d9482e32dbaab295a02d98e3887bdb3853821b3d
Files Diff
- Added: 12
- Removed: 9
- Renamed: 0
- Modified: 10
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method private doInBeforeTrace(recorder SpanEventRecorder, trace Trace, args Object[]) : void renamed to private setPinpointHeaders(recorder SpanEventRecorder, trace Trace, record ProducerRecord, sample boolean) : void in class com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerSendInterceptor | From | To | |
| Rename Method public getEncoder() : String renamed to public getKafkaEntryPoint() : String in class com.navercorp.pinpoint.plugin.kafka.KafkaConfig | From | To | |
| Rename Method public isEnable() : boolean renamed to public isProducerEnable() : boolean in class com.navercorp.pinpoint.plugin.kafka.KafkaConfig | From | To | |
| Rename Method public isCreateContext() : boolean renamed to public isConsumerEnable() : boolean in class com.navercorp.pinpoint.plugin.kafka.KafkaConfig | From | To | |
| Rename Variable | 2 | ||
| Rename Variable method : InstrumentMethod to constructor : InstrumentMethod in method public doInTransform(instrumentor Instrumentor, classLoader ClassLoader, className String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classfileBuffer byte[]) : byte[] in class com.navercorp.pinpoint.plugin.kafka.KafkaPlugin.setup.transform | From | To | |
| Rename Variable method : InstrumentMethod to sendMethod : InstrumentMethod in method public doInTransform(instrumentor Instrumentor, classLoader ClassLoader, className String, classBeingRedefined Class<?>, protectionDomain ProtectionDomain, classfileBuffer byte[]) : byte[] in class com.navercorp.pinpoint.plugin.kafka.KafkaPlugin.setup.transform | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private logger : PLogger from class com.navercorp.pinpoint.plugin.kafka.encoder.PinpointValueEncoder to private logger : PLogger from class com.navercorp.pinpoint.plugin.kafka.KafkaPlugin | From | To | |
| Rename Class | 2 | ||
| Rename Class com.navercorp.pinpoint.plugin.kafka.interceptor.ConsumerRecordConstructorInterceptor renamed to com.navercorp.pinpoint.plugin.kafka.interceptor.ConsumerRecordEntryPointInterceptor | From | To | |
| Rename Class com.navercorp.pinpoint.plugin.kafka.interceptor.KafkaProducerSendInterceptor renamed to com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerSendInterceptor | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute encoder : String to kafkaEntryPoint : String in class com.navercorp.pinpoint.plugin.kafka.KafkaConfig | From | To | |
| Rename Attribute enable : boolean to producerEnable : boolean in class com.navercorp.pinpoint.plugin.kafka.KafkaConfig | From | To | |
| Rename Attribute KAFKA : ServiceType to KAFKA_CLIENT : ServiceType in class com.navercorp.pinpoint.plugin.kafka.KafkaConstants | From | To | |
| Rename Attribute includeHeader : boolean to consumerEnable : boolean in class com.navercorp.pinpoint.plugin.kafka.KafkaConfig | From | To | |
| Extract Variable | 1 | ||
| Extract Variable kafkaHeaders : Headers in method private setPinpointHeaders(recorder SpanEventRecorder, trace Trace, record ProducerRecord, sample boolean) : void from class com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerSendInterceptor | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type recorder : SpanRecorder to recorder : SpanEventRecorder in method public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.kafka.interceptor.ConsumerRecordEntryPointInterceptor | From | To | |
| Extract Method | 5 | ||
| Extract Method private createTrace(consumerRecord ConsumerRecord) : Trace extracted from public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.kafka.interceptor.ConsumerRecordEntryPointInterceptor | From | To | |
| Extract Method private getConsumerRecord(args Object[]) : ConsumerRecord extracted from public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.kafka.interceptor.ConsumerRecordEntryPointInterceptor | From | To | |
| Extract Method private populateTraceIdFromHeaders(headers Headers) : TraceId extracted from public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.kafka.interceptor.ConsumerRecordEntryPointInterceptor | From | To | |
| Extract Method public transformEntryPoint(entryPoint String) : void extracted from public setup(context ProfilerPluginSetupContext) : void in class com.navercorp.pinpoint.plugin.kafka.KafkaPlugin | From | To | |
| Extract Method private recordRootSpan(recorder SpanRecorder, consumerRecord ConsumerRecord, parentApplicationName String, parentApplicationType String) : void extracted from public before(target Object, args Object[]) : void in class com.navercorp.pinpoint.plugin.kafka.interceptor.ConsumerRecordEntryPointInterceptor | From | To |