e1729549ffdb0de97325bf09cbdc129fd1adf797
Files Diff
- Added: 8
- Removed: 10
- Renamed: 0
- Modified: 51
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public testGetScope_Type_SIMPLE() : void renamed to public testGetScope() : void in class com.navercorp.pinpoint.profiler.util.ThreadLocalScopePoolTest | From | To | |
| Rename Method public verifySpanEvent(serviceTypeName String, method Method, rpc String, endPoint String, destinationId String, annotations ExpectedAnnotation...) : void renamed to public verifySpan(type SpanType, serviceTypeName String, methodSignature String, rpc String, endPoint String, remoteAddr String, destinationId String, annotations ExpectedAnnotation...) : void in class com.navercorp.pinpoint.test.PluginTestAgent | From | To | |
| Rename Method public verifySpanEvent(serviceType String, method Method, rpc String, endPoint String, destinationId String, annotations ExpectedAnnotation...) : void renamed to public verifySpan(type SpanType, serviceType String, methodSignature String, rpc String, endPoint String, remoteAddr String, destinationId String, annotations ExpectedAnnotation...) : void in class com.navercorp.pinpoint.bootstrap.plugin.test.PluginTestVerifier | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type scopeFactory : ScopeFactory to scopeDefinition : ScopeDefinition in method public ThreadLocalScope(scopeDefinition ScopeDefinition) in class com.navercorp.pinpoint.profiler.util.ThreadLocalScope | From | To | |
| Inline Method | 1 | ||
| Inline Method private loadServiceTypeProviders(pluginJars URL[]) : ServiceTypeRegistryService inlined to public premain(agentArgs String, instrumentation Instrumentation) : void in class com.navercorp.pinpoint.bootstrap.PinpointBootStrap | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to InterceptorBuilder in method public injectInterceptor(interceptorClassName String, constructorArguments Object...) : InterceptorBuilder in class com.navercorp.pinpoint.bootstrap.plugin.editor.BaseMethodEditorBuilder | From | To | |
| Change Return Type void to InterceptorBuilder in method public injectInterceptor(interceptorClassName String, constructorArguments Object...) : InterceptorBuilder in class com.navercorp.pinpoint.profiler.plugin.editor.DefaultClassEditorBuilder.DefaultMethodEditorBuilder | From | To | |
| Change Return Type T to Object in method public createAttachment() : Object in class com.navercorp.pinpoint.bootstrap.instrument.AttachmentFactory | From | To | |
| Rename Class | 1 | ||
| Rename Class com.navercorp.pinpoint.profiler.plugin.interceptor.ScopedStaticInterceptor renamed to com.navercorp.pinpoint.profiler.plugin.interceptor.ScopedStaticAroundInterceptor | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.navercorp.pinpoint.bootstrap.instrument.ScopeDefinition.Type moved and renamed to com.navercorp.pinpoint.bootstrap.plugin.test.PluginTestVerifier.SpanType | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute scopeName : String to group : InterceptorGroup in class com.navercorp.pinpoint.profiler.plugin.interceptor.ScopedInterceptorFactory | From | To | |
| Rename Attribute fieldSnooperMap : Map<String,FieldAccessor> to fieldSnoopers : NameValueList<FieldAccessor> in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext | From | To | |
| Rename Attribute metadataAccessorMap : Map<String,MetadataAccessor> to metadataAccessors : NameValueList<MetadataAccessor> in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext | From | To | |
| Rename Attribute interceptorName : String to interceptorClassName : String in class com.navercorp.pinpoint.profiler.plugin.interceptor.AnnotatedInterceptorInjector | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type annotation : Annotation to annotation : Name in method public resolve(index int, type Class<?>, annotations Annotation[]) : Option<Object> in class com.navercorp.pinpoint.profiler.plugin.objectfactory.PinpointTypeResolver | From | To | |
| Extract Variable | 1 | ||
| Extract Variable builder : AnnotatedInterceptorInjectorBuilder in method public injectInterceptor(interceptorClassName String, constructorArguments Object...) : InterceptorBuilder from class com.navercorp.pinpoint.profiler.plugin.editor.DefaultClassEditorBuilder.DefaultMethodEditorBuilder | From | To | |
| Extract Method | 1 | ||
| Extract Method private findApiId(desc String) : int extracted from private findApiId(method Method) : int in class com.navercorp.pinpoint.test.PluginTestAgent | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type metadataAccessorMap : Map<String,MetadataAccessor> to metadataAccessors : NameValueList<MetadataAccessor> in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext | From | To | |
| Change Attribute Type scope : AttachmentScope<Object> to scope : Scope in class com.navercorp.pinpoint.profiler.modifier.connector.httpclient4.interceptor.AbstractHttpRequestExecuteWithDivergence | From | To | |
| Change Attribute Type scopeName : String to group : InterceptorGroup in class com.navercorp.pinpoint.profiler.plugin.interceptor.ScopedInterceptorFactory | From | To | |
| Change Attribute Type fieldSnooperMap : Map<String,FieldAccessor> to fieldSnoopers : NameValueList<FieldAccessor> in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContext | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter scopeFactory : ScopeFactory to scopeDefinition : ScopeDefinition in method public ThreadLocalScope(scopeDefinition ScopeDefinition) in class com.navercorp.pinpoint.profiler.util.ThreadLocalScope | From | To | |
| Rename Parameter providedArguments : Object[] to constructorArguments : Object[] in method public AnnotatedInterceptorInjector(pluginContext DefaultProfilerPluginContext, interceptorName String, constructorArguments Object[], groupName String, executionPoint ExecutionPoint) in class com.navercorp.pinpoint.profiler.plugin.interceptor.AnnotatedInterceptorInjector | From | To |