eaa1486724daeaa7433e69ec02cab61d1bd4a2f7
Files Diff
- Added: 5
- Removed: 1
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method private decodeSocketProperties(message ControlHandshakePacket) : Map<Object,Object> from class com.navercorp.pinpoint.rpc.server.PinpointServerSocket to public decodeHandshakePacket(message ControlHandshakePacket) : Map<Object,Object> from class com.navercorp.pinpoint.rpc.server.PinpointServerSocketHandshaker | From | To | |
| Move And Rename Method private sendHandshakeResponseMessage(requestId int, handShakeResponseCode HandshakeResponseCode, channel Channel) : void from class com.navercorp.pinpoint.rpc.server.PinpointServerSocket to private sendHandshakeResponse0(channel Channel, requestId int, handShakeResponseCode HandshakeResponseCode) : void from class com.navercorp.pinpoint.rpc.server.PinpointServerSocketHandshaker | From | To | |
| Rename Variable | 3 | ||
| Rename Variable properties : Map<String,Object> to handshakeData : Map<String,Object> in method public doHandshake() : void in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Rename Variable isSet : boolean to isFirst : boolean in method public messageReceived(ctx ChannelHandlerContext, e MessageEvent) : void in class com.navercorp.pinpoint.rpc.server.PinpointServerSocket | From | To | |
| Rename Variable properties : Map<Object,Object> to handshakeData : Map<Object,Object> in method public messageReceived(ctx ChannelHandlerContext, e MessageEvent) : void in class com.navercorp.pinpoint.rpc.server.PinpointServerSocket | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private handShakeFailFutureListener : ChannelFutureListener from class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler to private handShakeFailFutureListener : ChannelFutureListener from class com.navercorp.pinpoint.rpc.client.PinpointClientSocketHandshaker | From | To | |
| Extract Class | 1 | ||
| Extract Class com.navercorp.pinpoint.rpc.client.PinpointClientSocketHandshaker from class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.navercorp.pinpoint.rpc.server.MessageListenerTest.SimpleListener moved and renamed to com.navercorp.pinpoint.rpc.client.ClientMessageListenerTest.AlwaysHandshakeSuccessListener | From | To | |
| Move Class | 1 | ||
| Move Class com.navercorp.pinpoint.rpc.server.MessageListenerTest.EchoMessageListener moved to com.navercorp.pinpoint.rpc.client.ClientMessageListenerTest.EchoMessageListener | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute enableWorkerPacketDelay : long to handshakeRetryInterval : long in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To | |
| Extract Interface | 1 | ||
| Extract Interface com.navercorp.pinpoint.rpc.server.handler.HandshakerHandler from classes [com.navercorp.pinpoint.rpc.server.ServerMessageListener] | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter enableWorkerPacketDelay : long to handshakeRetryInterval : long in method public PinpointSocketHandler(pinpointSocketFactory PinpointSocketFactory, pingDelay long, handshakeRetryInterval long, timeoutMillis long) in class com.navercorp.pinpoint.rpc.client.PinpointSocketHandler | From | To |