pinpoint f421ea22f09b6d9dca971322633a2e29b676030f

f421ea22f09b6d9dca971322633a2e29b676030f

Files Diff

Added: 5
Removed: 0
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	2
Extract Subclass com.navercorp.pinpoint.web.calltree.span.SpanCallTree from class com.navercorp.pinpoint.web.calltree.span.CallTree	From	To
Extract Subclass com.navercorp.pinpoint.web.calltree.span.SpanAsyncCallTree from class com.navercorp.pinpoint.web.calltree.span.CallTree	From	To
Change Parameter Type	5
Change Parameter Type spanAlignList : List<SpanAlign> to callTreeIterator : CallTreeIterator in method public SpanResult(completeType int, callTreeIterator CallTreeIterator) in class com.navercorp.pinpoint.web.service.SpanResult	From	To
Change Parameter Type spanAlignList : List<SpanAlign> to callTreeIterator : CallTreeIterator in method public createRecordSet(callTreeIterator CallTreeIterator, focusTimestamp long) : RecordSet in class com.navercorp.pinpoint.web.service.TransactionInfoServiceImpl	From	To
Change Parameter Type tree : CallTree to tree : SpanCallTree in method private assertDepth(name String, tree SpanCallTree, result List<String>) : void in class com.navercorp.pinpoint.web.calltree.span.CallTreeTest	From	To
Change Parameter Type spanAlignList : List<SpanAlign> to callTreeIterator : CallTreeIterator in method private populateSpanRecord(callTreeIterator CallTreeIterator) : List<Record> in class com.navercorp.pinpoint.web.service.TransactionInfoServiceImpl.SpanAlignPopulate	From	To
Change Parameter Type spanAligns : List<SpanAlign> to callTreeIterator : CallTreeIterator in method public createRecordSet(callTreeIterator CallTreeIterator, focusTimestamp long) : RecordSet in class com.navercorp.pinpoint.web.service.TransactionInfoService	From	To
Push Down Attribute	4
Push Down Attribute private ROOT_DEPTH : int from class com.navercorp.pinpoint.web.calltree.span.CallTree to private ROOT_DEPTH : int from class com.navercorp.pinpoint.web.calltree.span.SpanCallTree	From	To
Push Down Attribute private root : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.CallTree to private root : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.SpanCallTree	From	To
Push Down Attribute private MIN_DEPTH : int from class com.navercorp.pinpoint.web.calltree.span.CallTree to private MIN_DEPTH : int from class com.navercorp.pinpoint.web.calltree.span.SpanCallTree	From	To
Push Down Attribute private LEVEL_DEPTH : int from class com.navercorp.pinpoint.web.calltree.span.CallTree to private LEVEL_DEPTH : int from class com.navercorp.pinpoint.web.calltree.span.SpanCallTree	From	To
Change Variable Type	4
Change Variable Type spanAligns : List<SpanAlign> to callTreeIterator : CallTreeIterator in method public transactionInfo(traceIdParam String, focusTimestamp long, viewVersion int, response HttpServletResponse) : ModelAndView in class com.navercorp.pinpoint.web.controller.BusinessTransactionController	From	To
Change Variable Type sort : List<SpanAlign> to callTree : CallTree in method private order(spans List<SpanBo>, selectedSpanHint long) : SpanResult in class com.navercorp.pinpoint.web.service.SpanServiceImpl	From	To
Change Variable Type cursor : CallTreeCursor to iterator : CallTreeIterator in method private assertDepth(name String, tree SpanCallTree, result List<String>) : void in class com.navercorp.pinpoint.web.calltree.span.CallTreeTest	From	To
Change Variable Type parent : SpanDepth to parent : CallTreeNode in method private populateSpanRecord(callTreeIterator CallTreeIterator) : List<Record> in class com.navercorp.pinpoint.web.service.TransactionInfoServiceImpl.SpanAlignPopulate	From	To
Rename Method	2
Rename Method private makeSpanEventBo(async boolean, sequence short, depth int, nextAsyncId int, asyncId int) : SpanEventBo renamed to private makeSpanAlign(async boolean, sequence short, nextAsyncId int, asyncId int) : SpanAlign in class com.navercorp.pinpoint.web.calltree.span.CallTreeTest	From	To
Rename Method public getData() : SpanAlign renamed to public getValue() : SpanAlign in class com.navercorp.pinpoint.web.calltree.span.CallTreeNode	From	To
Push Down Method	7
Push Down Method package findUpperLevelLastSibling(level int, node CallTreeNode) : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.CallTree to package findUpperLevelLastSibling(level int, node CallTreeNode) : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.SpanCallTree	From	To
Push Down Method public add(depth int, spanAlign SpanAlign) : void from class com.navercorp.pinpoint.web.calltree.span.CallTree to public add(depth int, spanAlign SpanAlign) : void from class com.navercorp.pinpoint.web.calltree.span.SpanAsyncCallTree	From	To
Push Down Method public getRoot() : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.CallTree to public getRoot() : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.SpanAsyncCallTree	From	To
Push Down Method public add(tree CallTree) : void from class com.navercorp.pinpoint.web.calltree.span.CallTree to public add(tree CallTree) : void from class com.navercorp.pinpoint.web.calltree.span.SpanAsyncCallTree	From	To
Push Down Method public CallTree(spanAlign SpanAlign) from class com.navercorp.pinpoint.web.calltree.span.CallTree to public SpanCallTree(spanAlign SpanAlign) from class com.navercorp.pinpoint.web.calltree.span.SpanCallTree	From	To
Push Down Method package findUpperLevel(level int, node CallTreeNode) : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.CallTree to package findUpperLevel(level int, node CallTreeNode) : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.SpanCallTree	From	To
Push Down Method package findLastSibling(node CallTreeNode) : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.CallTree to package findLastSibling(node CallTreeNode) : CallTreeNode from class com.navercorp.pinpoint.web.calltree.span.SpanCallTree	From	To
Rename Variable	4
Rename Variable spanAligns : List<SpanAlign> to callTreeIterator : CallTreeIterator in method public transactionInfo(traceIdParam String, focusTimestamp long, viewVersion int, response HttpServletResponse) : ModelAndView in class com.navercorp.pinpoint.web.controller.BusinessTransactionController	From	To
Rename Variable sort : List<SpanAlign> to callTree : CallTree in method private order(spans List<SpanBo>, selectedSpanHint long) : SpanResult in class com.navercorp.pinpoint.web.service.SpanServiceImpl	From	To
Rename Variable cursor : CallTreeCursor to iterator : CallTreeIterator in method private assertDepth(name String, tree SpanCallTree, result List<String>) : void in class com.navercorp.pinpoint.web.calltree.span.CallTreeTest	From	To
Rename Variable spanBo : SpanBo to nextSpanBo : SpanBo in method private populate(span SpanBo, spanEventBoList List<SpanEventBo>, asyncSpanEventMap Map<Integer,List<SpanEventBo>>) : CallTree in class com.navercorp.pinpoint.web.calltree.span.SpanAligner2	From	To
Inline Method	1
Inline Method private populate(span SpanBo) : CallTree inlined to private populate(span SpanBo, spanEventBoList List<SpanEventBo>, asyncSpanEventMap Map<Integer,List<SpanEventBo>>) : CallTree in class com.navercorp.pinpoint.web.calltree.span.SpanAligner2	From	To
Change Return Type	2
Change Return Type SpanEventBo to SpanAlign in method private makeSpanAlign(async boolean, sequence short, nextAsyncId int, asyncId int) : SpanAlign in class com.navercorp.pinpoint.web.calltree.span.CallTreeTest	From	To
Change Return Type List<SpanAlign> to CallTree in method public sort() : CallTree in class com.navercorp.pinpoint.web.calltree.span.SpanAligner2	From	To
Rename Attribute	1
Rename Attribute spanAlignList : List<SpanAlign> to callTreeIterator : CallTreeIterator in class com.navercorp.pinpoint.web.service.SpanResult	From	To
Change Attribute Type	1
Change Attribute Type spanAlignList : List<SpanAlign> to callTreeIterator : CallTreeIterator in class com.navercorp.pinpoint.web.service.SpanResult	From	To
Extract And Move Method	1
Extract And Move Method public setId(id int) : void extracted from private populateSpanRecord(spanAlignList List<SpanAlign>) : List<Record> in class com.navercorp.pinpoint.web.service.TransactionInfoServiceImpl.SpanAlignPopulate & moved to class com.navercorp.pinpoint.web.calltree.span.CallTreeNode	From	To
Rename Parameter	5
Rename Parameter spanAlignList : List<SpanAlign> to callTreeIterator : CallTreeIterator in method private populateSpanRecord(callTreeIterator CallTreeIterator) : List<Record> in class com.navercorp.pinpoint.web.service.TransactionInfoServiceImpl.SpanAlignPopulate	From	To
Rename Parameter spanAligns : List<SpanAlign> to callTreeIterator : CallTreeIterator in method public createRecordSet(callTreeIterator CallTreeIterator, focusTimestamp long) : RecordSet in class com.navercorp.pinpoint.web.service.TransactionInfoService	From	To
Rename Parameter data : SpanAlign to value : SpanAlign in method public CallTreeNode(parent CallTreeNode, value SpanAlign) in class com.navercorp.pinpoint.web.calltree.span.CallTreeNode	From	To
Rename Parameter spanAlignList : List<SpanAlign> to callTreeIterator : CallTreeIterator in method public SpanResult(completeType int, callTreeIterator CallTreeIterator) in class com.navercorp.pinpoint.web.service.SpanResult	From	To
Rename Parameter spanAlignList : List<SpanAlign> to callTreeIterator : CallTreeIterator in method public createRecordSet(callTreeIterator CallTreeIterator, focusTimestamp long) : RecordSet in class com.navercorp.pinpoint.web.service.TransactionInfoServiceImpl	From	To

f421ea22f09b6d9dca971322633a2e29b676030f

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: