pinpoint f7e2583652295fc289885acd60d908b1ac197e29

f7e2583652295fc289885acd60d908b1ac197e29

Files Diff

Added: 68
Removed: 42
Renamed: 0
Modified: 79

Link to commit

Dependency Action
Added
	org.yaml:snakeyaml:1.23-p1
Updated
	From com.fasterxml.jackson.core:jackson-databind 2.6.6 To 2.9.7
	From com.fasterxml.jackson.core:jackson-core 2.6.6 To 2.9.7
	From com.fasterxml.jackson.core:jackson-annotations 2.9.7 To 2.6.6
	From com.fasterxml.jackson.core:jackson-annotations 2.6.6 To 2.9.7
	From com.fasterxml.jackson.core:jackson-databind 2.9.7 To 2.6.6
	From com.fasterxml.jackson.core:jackson-core 2.9.7 To 2.6.6
	From org.apache.httpcomponents:httpcore 4.5.6 To 4.4.10
	From org.apache.httpcomponents:httpcore 4.4.10 To 4.5.6

Refactorings reported:

Refactoring Name	Occurences
Merge Attribute	2
Merge Attribute [profilerConfig : ProfilerConfig, instrumentEngine : InstrumentEngine] to profilerPluginContextLoader : ProfilerPluginContextLoader in class com.navercorp.pinpoint.test.MockPluginContextLoadResultProvider	From	To
Merge Attribute [configuredApplicationType : ServiceType, dynamicTransformTrigger : DynamicTransformTrigger, pluginLoader : PluginLoader] to pluginClassLoader : ClassLoader in class com.navercorp.pinpoint.test.MockPluginContextLoadResultProvider	From	To
Change Parameter Type	9
Change Parameter Type provider : Class<?> to provider : TraceMetadataProvider in method public TraceMetadataSetupContextImpl(provider TraceMetadataProvider) in class com.navercorp.pinpoint.loader.trace.TraceMetadataLoader.TraceMetadataSetupContextImpl	From	To
Change Parameter Type key : AnnotationKey to code : int in method public ExactMatcher(code int) in class com.navercorp.pinpoint.common.trace.AnnotationKeyMatchers.ExactMatcher	From	To
Change Parameter Type annotationKeyRegistryService : AnnotationKeyRegistryService to annotationKeyRegistry : AnnotationKeyLocator in method private verifyAnnotationKeys(annotationKeys List<AnnotationKey>, annotationKeyRegistry AnnotationKeyLocator) : void in class com.navercorp.pinpoint.loader.trace.ServiceTypeInitializerTest	From	To
Change Parameter Type plugin : Plugin to plugin : Plugin<?> in method public PluginConfig(plugin Plugin<?>, pluginPackageFilter ClassNameFilter) in class com.navercorp.pinpoint.profiler.plugin.PluginConfig	From	To
Change Parameter Type provider : Class<?> to provider : TraceMetadataProvider in method public Pair(value T, provider TraceMetadataProvider) in class com.navercorp.pinpoint.loader.trace.TraceMetadataLoader.Pair	From	To
Change Parameter Type plugin : Plugin<ProfilerPlugin> to plugin : JarPlugin<ProfilerPlugin> in method private setupPlugin(globalContext ProfilerPluginGlobalContext, plugin JarPlugin<ProfilerPlugin>) : List<PluginSetupResult> in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContextLoader	From	To
Change Parameter Type providerClass : Class<?> to provider : TraceMetadataProvider in method private check(type ServiceType, provider TraceMetadataProvider) : void in class com.navercorp.pinpoint.loader.trace.TraceMetadataLoader.ServiceTypeChecker	From	To
Change Parameter Type providerClass : Class<?> to provider : TraceMetadataProvider in method private check(key AnnotationKey, provider TraceMetadataProvider) : void in class com.navercorp.pinpoint.loader.trace.TraceMetadataLoader.AnnotationKeyChecker	From	To
Change Parameter Type plugin : Plugin to plugin : Plugin<?> in method private getJarFile(plugin Plugin<?>) : JarFile in class com.navercorp.pinpoint.profiler.plugin.PluginConfig	From	To
Move Attribute	13
Move Attribute private logger : Logger from class com.navercorp.pinpoint.profiler.context.provider.plugin.JarPluginLoader to private logger : Logger from class com.navercorp.pinpoint.profiler.context.provider.plugin.TraceMetadataLoaderServiceProvider	From	To
Move Attribute private logger : Logger from class com.navercorp.pinpoint.profiler.plugin.DefaultPluginContextLoadResult to private logger : Logger from class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContextLoader.JarPluginComponents	From	To
Move Attribute private profilerConfig : ProfilerConfig from class com.navercorp.pinpoint.test.MockPluginContextLoadResultProvider to private profilerConfig : ProfilerConfig from class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader	From	To
Move Attribute private profilerConfig : ProfilerConfig from class com.navercorp.pinpoint.test.MockPluginContextLoadResult to private profilerConfig : ProfilerConfig from class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader	From	To
Move Attribute private configuredApplicationType : ServiceType from class com.navercorp.pinpoint.test.MockPluginContextLoadResultProvider to private configuredApplicationType : ServiceType from class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader	From	To
Move Attribute private configuredApplicationType : ServiceType from class com.navercorp.pinpoint.test.MockPluginContextLoadResult to private configuredApplicationType : ServiceType from class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader	From	To
Move Attribute private profilerConfig : ProfilerConfig from class com.navercorp.pinpoint.profiler.plugin.DefaultPluginContextLoadResult to private profilerConfig : ProfilerConfig from class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader	From	To
Move Attribute private configuredApplicationType : ServiceType from class com.navercorp.pinpoint.profiler.context.provider.PluginContextLoadResultProvider to private configuredApplicationType : ServiceType from class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader	From	To
Move Attribute private configuredApplicationType : ServiceType from class com.navercorp.pinpoint.profiler.plugin.DefaultPluginContextLoadResult to private configuredApplicationType : ServiceType from class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader	From	To
Move Attribute private commonLoggerFactory : CommonLoggerFactory from class com.navercorp.pinpoint.profiler.context.provider.plugin.AnnotationKeyRegistryServiceProvider to private commonLoggerFactory : CommonLoggerFactory from class com.navercorp.pinpoint.profiler.context.provider.plugin.TraceMetadataLoaderProvider	From	To
Move Attribute private commonLoggerFactory : CommonLoggerFactory from class com.navercorp.pinpoint.profiler.context.provider.plugin.TraceMetadataLoaderServiceProvider to private commonLoggerFactory : CommonLoggerFactory from class com.navercorp.pinpoint.profiler.context.provider.plugin.TraceMetadataLoaderProvider	From	To
Move Attribute private profilerConfig : ProfilerConfig from class com.navercorp.pinpoint.profiler.context.provider.PluginContextLoadResultProvider to private profilerConfig : ProfilerConfig from class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader	From	To
Move Attribute private commonLoggerFactory : CommonLoggerFactory from class com.navercorp.pinpoint.profiler.context.provider.plugin.ServiceTypeRegistryServiceProvider to private commonLoggerFactory : CommonLoggerFactory from class com.navercorp.pinpoint.profiler.context.provider.plugin.TraceMetadataLoaderProvider	From	To
Extract Class	4
Extract Class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader from class com.navercorp.pinpoint.profiler.plugin.DefaultPluginContextLoadResult	From	To
Extract Class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader from class com.navercorp.pinpoint.profiler.context.provider.PluginContextLoadResultProvider	From	To
Extract Class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader from class com.navercorp.pinpoint.test.MockPluginContextLoadResultProvider	From	To
Extract Class com.navercorp.pinpoint.test.MockProfilerPluginContextLoader from class com.navercorp.pinpoint.test.MockPluginContextLoadResult	From	To
Rename Class	2
Rename Class com.navercorp.pinpoint.test.TestProfilerPluginClassLoader renamed to com.navercorp.pinpoint.test.TestProfilerPluginClassInjector	From	To
Rename Class com.navercorp.pinpoint.profiler.context.provider.plugin.PluginLoaderProvider renamed to com.navercorp.pinpoint.profiler.context.provider.plugin.PluginSetupProvider	From	To
Move And Rename Class	2
Move And Rename Class com.navercorp.pinpoint.common.AnnotationKeyTest moved and renamed to com.navercorp.pinpoint.common.trace.AnnotationKeyUtilsTest	From	To
Move And Rename Class com.navercorp.pinpoint.profiler.context.provider.plugin.ProfilerPluginLoader moved and renamed to com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContextLoader	From	To
Move Class	12
Move Class com.navercorp.pinpoint.common.plugin.JarPlugin moved to com.navercorp.pinpoint.profiler.plugin.JarPlugin	From	To
Move Class com.navercorp.pinpoint.common.trace.AnnotationKeyRegistry moved to com.navercorp.pinpoint.loader.trace.AnnotationKeyRegistry	From	To
Move Class com.navercorp.pinpoint.common.trace.ServiceTypeRegistry moved to com.navercorp.pinpoint.loader.trace.ServiceTypeRegistry	From	To
Move Class com.navercorp.pinpoint.common.service.AnnotationKeyRegistryService moved to com.navercorp.pinpoint.loader.service.AnnotationKeyRegistryService	From	To
Move Class com.navercorp.pinpoint.common.ServiceTypeInitializerTest moved to com.navercorp.pinpoint.loader.trace.ServiceTypeInitializerTest	From	To
Move Class com.navercorp.pinpoint.common.trace.TraceMetadataLoader moved to com.navercorp.pinpoint.loader.trace.TraceMetadataLoader	From	To
Move Class com.navercorp.pinpoint.common.plugin.Plugin moved to com.navercorp.pinpoint.profiler.plugin.Plugin	From	To
Move Class com.navercorp.pinpoint.web.util.AnnotationKeyMatcherRegistry moved to com.navercorp.pinpoint.loader.trace.AnnotationKeyMatcherRegistry	From	To
Move Class com.navercorp.pinpoint.common.HistogramSchemaTest moved to com.navercorp.pinpoint.common.trace.HistogramSchemaTest	From	To
Move Class com.navercorp.pinpoint.common.service.ServiceTypeRegistryService moved to com.navercorp.pinpoint.loader.service.ServiceTypeRegistryService	From	To
Move Class com.navercorp.pinpoint.common.plugin.JarFileUtils moved to com.navercorp.pinpoint.profiler.util.JarFileUtils	From	To
Move Class com.navercorp.pinpoint.common.plugin.PluginJar moved to com.navercorp.pinpoint.profiler.plugin.PluginJar	From	To
Change Variable Type	4
Change Variable Type plugin : Plugin<ProfilerPlugin> to jarPlugin : JarPlugin<ProfilerPlugin> in method public load(profilerPlugins List<ProfilerPlugin>) : PluginsSetupResult in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContextLoader	From	To
Change Variable Type plugins : List<Plugin<ProfilerPlugin>> to profilerPlugins : List<ProfilerPlugin> in method private load() : PluginsSetupResult in class com.navercorp.pinpoint.test.MockPluginContextLoadResult	From	To
Change Variable Type annotationKeyRegistryService : AnnotationKeyRegistryService to annotationKeyRegistry : AnnotationKeyLocator in method public testWithPlugins() : void in class com.navercorp.pinpoint.loader.trace.ServiceTypeInitializerTest	From	To
Change Variable Type plugin : Plugin to plugin : Plugin<?> in method public testInjectClass() : void in class com.navercorp.pinpoint.profiler.instrument.classloading.JarProfilerPluginClassInjectorTest	From	To
Rename Method	3
Rename Method private loadProfilerPlugin(globalContext ProfilerPluginGlobalContext, plugin Plugin<ProfilerPlugin>) : List<PluginSetupResult> renamed to private setupPlugin(globalContext ProfilerPluginGlobalContext, plugin JarPlugin<ProfilerPlugin>) : List<PluginSetupResult> in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContextLoader	From	To
Rename Method public getPluginJar() : URL renamed to public getPluginUrl() : URL in class com.navercorp.pinpoint.profiler.plugin.PluginConfig	From	To
Rename Method private getProfilerPluginContextList() : List<PluginSetupResult> renamed to private getPluginsSetupResult() : PluginsSetupResult in class com.navercorp.pinpoint.test.MockPluginContextLoadResult	From	To
Rename Variable	3
Rename Variable plugins : List<Plugin<ProfilerPlugin>> to profilerPlugins : List<ProfilerPlugin> in method private load() : PluginsSetupResult in class com.navercorp.pinpoint.test.MockPluginContextLoadResult	From	To
Rename Variable annotationKeyRegistryService : AnnotationKeyRegistryService to annotationKeyRegistry : AnnotationKeyLocator in method public testWithPlugins() : void in class com.navercorp.pinpoint.loader.trace.ServiceTypeInitializerTest	From	To
Rename Variable plugin : Plugin<ProfilerPlugin> to jarPlugin : JarPlugin<ProfilerPlugin> in method public load(profilerPlugins List<ProfilerPlugin>) : PluginsSetupResult in class com.navercorp.pinpoint.profiler.plugin.DefaultProfilerPluginContextLoader	From	To
Change Return Type	5
Change Return Type String to List<String> in method public getPluginPackages() : List<String> in class com.navercorp.pinpoint.profiler.plugin.PluginJar	From	To
Change Return Type List<PluginSetupResult> to PluginsSetupResult in method private getPluginsSetupResult() : PluginsSetupResult in class com.navercorp.pinpoint.test.MockPluginContextLoadResult	From	To
Change Return Type Plugin to Plugin<?> in method private getMockPlugin(className String) : Plugin<?> in class com.navercorp.pinpoint.profiler.instrument.classloading.JarProfilerPluginClassInjectorTest	From	To
Change Return Type PluginLoader to PluginSetup in method public get() : PluginSetup in class com.navercorp.pinpoint.profiler.context.provider.plugin.PluginSetupProvider	From	To
Change Return Type List<PluginSetupResult> to PluginsSetupResult in method private load() : PluginsSetupResult in class com.navercorp.pinpoint.test.MockPluginContextLoadResult	From	To
Replace Variable With Attribute	4
Replace Variable With Attribute annotationKeyRegistryService : AnnotationKeyRegistryService to mockAnnotationKeyRegistryService : AnnotationKeyRegistryService in method private newRecordFactory() : RecordFactory in class com.navercorp.pinpoint.web.vo.callstacks.RecordFactoryTest	From	To
Replace Variable With Attribute annotationKeyMatcherService : AnnotationKeyMatcherService to mockAnnotationKeyMatcherService : AnnotationKeyMatcherService in method private newRecordFactory() : RecordFactory in class com.navercorp.pinpoint.web.vo.callstacks.RecordFactoryTest	From	To
Replace Variable With Attribute proxyRequestTypeRegistryService : ProxyRequestTypeRegistryService to mockProxyRequestTypeRegistryService : ProxyRequestTypeRegistryService in method private newRecordFactory() : RecordFactory in class com.navercorp.pinpoint.web.vo.callstacks.RecordFactoryTest	From	To
Replace Variable With Attribute serviceTypeRegistryService : ServiceTypeRegistryService to mockServiceTypeRegistryService : ServiceTypeRegistryService in method private newRecordFactory() : RecordFactory in class com.navercorp.pinpoint.web.vo.callstacks.RecordFactoryTest	From	To
Rename Attribute	1
Rename Attribute registry : AnnotationKeyMatcherRegistry to annotationKeyMatcherLocator : AnnotationKeyMatcherLocator in class com.navercorp.pinpoint.web.service.DefaultAnnotationKeyMatcherService	From	To
Extract Interface	3
Extract Interface com.navercorp.pinpoint.common.trace.ServiceTypeLocator from classes [com.navercorp.pinpoint.loader.trace.ServiceTypeRegistry]	From	To
Extract Interface com.navercorp.pinpoint.common.trace.AnnotationKeyMatcherLocator from classes [com.navercorp.pinpoint.loader.trace.AnnotationKeyMatcherRegistry]	From	To
Extract Interface com.navercorp.pinpoint.common.trace.AnnotationKeyLocator from classes [com.navercorp.pinpoint.loader.trace.AnnotationKeyRegistry]	From	To
Change Attribute Type	6
Change Attribute Type provider : Class<?> to provider : TraceMetadataProvider in class com.navercorp.pinpoint.loader.trace.TraceMetadataLoader.TraceMetadataSetupContextImpl	From	To
Change Attribute Type lazy : List<PluginSetupResult> to lazy : PluginsSetupResult in class com.navercorp.pinpoint.test.MockPluginContextLoadResult	From	To
Change Attribute Type registry : AnnotationKeyMatcherRegistry to annotationKeyMatcherLocator : AnnotationKeyMatcherLocator in class com.navercorp.pinpoint.web.service.DefaultAnnotationKeyMatcherService	From	To
Change Attribute Type provider : Class<?> to provider : TraceMetadataProvider in class com.navercorp.pinpoint.loader.trace.TraceMetadataLoader.Pair	From	To
Change Attribute Type plugin : Plugin to plugin : Plugin<?> in class com.navercorp.pinpoint.profiler.plugin.PluginConfig	From	To
Change Attribute Type pluginPackages : String to pluginPackages : List<String> in class com.navercorp.pinpoint.profiler.plugin.PluginJar	From	To
Rename Parameter	4
Rename Parameter providerClass : Class<?> to provider : TraceMetadataProvider in method private check(type ServiceType, provider TraceMetadataProvider) : void in class com.navercorp.pinpoint.loader.trace.TraceMetadataLoader.ServiceTypeChecker	From	To
Rename Parameter providerClass : Class<?> to provider : TraceMetadataProvider in method private check(key AnnotationKey, provider TraceMetadataProvider) : void in class com.navercorp.pinpoint.loader.trace.TraceMetadataLoader.AnnotationKeyChecker	From	To
Rename Parameter key : AnnotationKey to code : int in method public ExactMatcher(code int) in class com.navercorp.pinpoint.common.trace.AnnotationKeyMatchers.ExactMatcher	From	To
Rename Parameter annotationKeyRegistryService : AnnotationKeyRegistryService to annotationKeyRegistry : AnnotationKeyLocator in method private verifyAnnotationKeys(annotationKeys List<AnnotationKey>, annotationKeyRegistry AnnotationKeyLocator) : void in class com.navercorp.pinpoint.loader.trace.ServiceTypeInitializerTest	From	To

f7e2583652295fc289885acd60d908b1ac197e29

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: