pinpoint fbb64324d46dbdaf950d7e62dcf677025d73b690

fbb64324d46dbdaf950d7e62dcf677025d73b690

Files Diff

Added: 41
Removed: 8
Renamed: 0
Modified: 86

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public initialize(createTraceObject boolean) : void from class com.navercorp.pinpoint.test.MockAgent to public cleanUp(detachTraceObject boolean) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method	15
Move Method private verifyAnnotations(actualAnnotations List<TAnnotation>, annotations ExpectedAnnotation...) : void from class com.navercorp.pinpoint.test.MockAgent to private verifyAnnotations(actualAnnotations List<TAnnotation>, annotations ExpectedAnnotation...) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method public verifyApi(serviceType ServiceType, method Method, params Object...) : void from class com.navercorp.pinpoint.test.MockAgent to public verifyApi(serviceType ServiceType, method Method, params Object...) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method public cleanUp(detachTraceObject boolean) : void from class com.navercorp.pinpoint.test.MockAgent to public cleanUp(detachTraceObject boolean) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method private getTBaseRecorder() : TBaseRecorder from class com.navercorp.pinpoint.test.MockAgent to private getTBaseRecorder() : TBaseRecorder from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method public verifyServerType(serviceType ServiceType) : void from class com.navercorp.pinpoint.test.MockAgent to public verifyServerType(serviceType ServiceType) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method public verifySpanEvent(serviceType ServiceType, annotations ExpectedAnnotation...) : void from class com.navercorp.pinpoint.test.MockAgent to public verifySpanEvent(serviceType ServiceType, annotations ExpectedAnnotation...) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method public printApis(out PrintStream) : void from class com.navercorp.pinpoint.test.MockAgent to public printApis(out PrintStream) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method public invokeShouldTraceExceptions() : void from class com.navercorp.pinpoint.profiler.modifier.tomcat.StandardHostValveInvokeModifierTest to public invokeShouldTraceExceptions() : void from class com.navercorp.pinpoint.plugin.tomcat.StandardHostValveInvokeModifierTest	From	To
Move Method public setUp() : void from class com.navercorp.pinpoint.profiler.modifier.tomcat.StandardHostValveInvokeModifierTest to public setUp() : void from class com.navercorp.pinpoint.plugin.tomcat.StandardHostValveInvokeModifierTest	From	To
Move Method public printSpans(out PrintStream) : void from class com.navercorp.pinpoint.test.MockAgent to public printSpans(out PrintStream) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method public verifySpanEvent(serviceType ServiceType, apiId Integer, annotations ExpectedAnnotation...) : void from class com.navercorp.pinpoint.test.MockAgent to public verifySpanEvent(serviceType ServiceType, apiId Integer, annotations ExpectedAnnotation...) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method public verifySpanCount(expected int) : void from class com.navercorp.pinpoint.test.MockAgent to public verifySpanCount(expected int) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Move Method public invokeShouldContinueTracingFromRequest() : void from class com.navercorp.pinpoint.profiler.modifier.tomcat.StandardHostValveInvokeModifierTest to public invokeShouldContinueTracingFromRequest() : void from class com.navercorp.pinpoint.plugin.tomcat.StandardHostValveInvokeModifierTest	From	To
Move Method public invokeShouldBeTraced() : void from class com.navercorp.pinpoint.profiler.modifier.tomcat.StandardHostValveInvokeModifierTest to public invokeShouldBeTraced() : void from class com.navercorp.pinpoint.plugin.tomcat.StandardHostValveInvokeModifierTest	From	To
Move Method public verifySpan(serviceType ServiceType, annotations ExpectedAnnotation...) : void from class com.navercorp.pinpoint.test.MockAgent to public verifySpan(serviceType ServiceType, annotations ExpectedAnnotation...) : void from class com.navercorp.pinpoint.test.PluginTestAgent	From	To
Inline Method	1
Inline Method private applicationHomePath() : String inlined to public resolve() : boolean in class com.navercorp.pinpoint.profiler.util.ApplicationServerTypeResolver	From	To
Rename Variable	2
Rename Variable targetMethod : MethodInfo to targetConstructor : MethodInfo in method public edit(classLoader ClassLoader, target InstrumentClass) : void in class com.navercorp.pinpoint.profiler.plugin.editor.ConstructorEditor	From	To
Rename Variable path : String to serverType : String in method public resolve() : boolean in class com.navercorp.pinpoint.profiler.util.ApplicationServerTypeResolver	From	To
Move Attribute	2
Move Attribute private SERVICE_TYPE : ServiceType from class com.navercorp.pinpoint.profiler.modifier.tomcat.StandardHostValveInvokeModifierTest to private SERVICE_TYPE : ServiceType from class com.navercorp.pinpoint.plugin.tomcat.StandardHostValveInvokeModifierTest	From	To
Move Attribute public TOMCAT : ServiceType from class com.navercorp.pinpoint.common.ServiceType to public TOMCAT : ServiceType from class com.navercorp.pinpoint.plugin.tomcat.TomcatConstants	From	To
Extract Class	1
Extract Class com.navercorp.pinpoint.plugin.tomcat.StandardHostValveInvokeModifierTest from class com.navercorp.pinpoint.profiler.modifier.tomcat.StandardHostValveInvokeModifierTest	From	To
Move Class	4
Move Class com.navercorp.pinpoint.profiler.modifier.tomcat.InvokeMethodInterceptorTest moved to com.navercorp.pinpoint.plugin.tomcat.InvokeMethodInterceptorTest	From	To
Move Class com.navercorp.pinpoint.profiler.modifier.tomcat.StandardServiceModifierTest moved to com.navercorp.pinpoint.plugin.tomcat.StandardServiceModifierTest	From	To
Move Class com.navercorp.pinpoint.profiler.modifier.tomcat.aspect.RequestFacadeAspectTest moved to com.navercorp.pinpoint.plugin.tomcat.aspect.RequestFacadeAspectTest	From	To
Move Class com.navercorp.pinpoint.bootstrap.plugin.editor.ClassRecipe moved to com.navercorp.pinpoint.profiler.plugin.editor.ClassRecipe	From	To
Parameterize Variable	1
Parameterize Variable file : File to libDir : File in method private addJars(libDir File, libraries List<String>) : void in class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite	From	To
Extract Superclass	1
Extract Superclass com.navercorp.pinpoint.plugin.tomcat.aspect.RequestFacadeAspect from classes [com.navercorp.pinpoint.plugin.tomcat.aspect.RequestFacadeAspectTest.RequestFacadeAspectMock]	From	To
Change Variable Type	1
Change Variable Type lib : Library to lib : TestRoot in method public PinpointPluginTestSuite(testClass Class<?>) in class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite	From	To
Extract Method	2
Extract Method private addJars(libDir File, libraries List<String>) : void extracted from private addRunnersWithLibraryPath(testClass Class<?>, testClassLocation String) : void in class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite	From	To
Rename Parameter	2
Rename Parameter testName : String to testId : String in method private addRunner(testClass Class<?>, testId String, libraries List<String>) : void in class com.navercorp.pinpoint.test.plugin.PinpointPluginTestSuite	From	To
Rename Parameter createTraceObject : boolean to detachTraceObject : boolean in method public cleanUp(detachTraceObject boolean) : void in class com.navercorp.pinpoint.test.PluginTestAgent	From	To

fbb64324d46dbdaf950d7e62dcf677025d73b690

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: