02029adf66fd6482e43fe98c2c12935db34ef49f
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private createShardsSorted(storageManager StorageManager, columnIds List<Long>, columnTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>, count int, length int) : List<ShardInfo> renamed to private createSortedShards(storageManager StorageManager, columnIds List<Long>, columnTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>, shardCount int) : List<ShardInfo> in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type uuids : Set<UUID> to uuids : List<UUID> in method private getMaterializedRows(uuids List<UUID>, columnIds List<Long>, columnTypes List<Type>) : MaterializedResult in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Change Parameter Type outputUuids : Set<UUID> to outputUuids : List<UUID> in method private assertShardEqualsSorted(inputUuids Set<UUID>, outputUuids List<UUID>, columnIds List<Long>, columnTypes List<Type>, sortIndexes List<Integer>, sortOrders List<SortOrder>) : void in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Rename Variable | 5 | ||
| Rename Variable builder : ImmutableList.Builder<Page> to pages : ImmutableList.Builder<Page> in method private getPages(uuids Set<UUID>, columnIds List<Long>, columnTypes List<Type>) : List<Page> in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Rename Variable builder : MaterializedResult.Builder to rows : MaterializedResult.Builder in method private getMaterializedRows(uuids List<UUID>, columnIds List<Long>, columnTypes List<Type>) : MaterializedResult in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Rename Variable index : int to channel : int in method public compareTo(other SortedRowSource) : int in class com.facebook.presto.raptor.storage.ShardCompactor.SortedRowSource | From | To | |
| Rename Variable numShards : int to shardNum : int in method private createSortedShards(storageManager StorageManager, columnIds List<Long>, columnTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>, shardCount int) : List<ShardInfo> in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Rename Variable columnInfoBuilder : ImmutableList.Builder<ColumnInfo> to columnInfos : ImmutableList.Builder<ColumnInfo> in method private getColumnInfo(columnIds List<Long>, columnTypes List<Type>) : List<ColumnInfo> in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type outputUuids : Set<UUID> to outputUuids : List<UUID> in method public testShardCompactorSorted() : void in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Extract Method | 2 | ||
| Extract Method private createSortedShard(columnTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>, sink StoragePageSink) : void extracted from private createShardsSorted(storageManager StorageManager, columnIds List<Long>, columnTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>, count int, length int) : List<ShardInfo> in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Extract Method public createOrcStorageManager(dbi IDBI, temporary File, maxShardRows int) : OrcStorageManager extracted from public createOrcStorageManager(dbi IDBI, temporary File) : OrcStorageManager in class com.facebook.presto.raptor.storage.TestOrcStorageManager | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter count : int to shardCount : int in method private createSortedShards(storageManager StorageManager, columnIds List<Long>, columnTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>, shardCount int) : List<ShardInfo> in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To | |
| Rename Parameter count : int to shardCount : int in method private createShards(storageManager StorageManager, columnIds List<Long>, columnTypes List<Type>, shardCount int) : List<ShardInfo> in class com.facebook.presto.raptor.storage.TestShardCompactor | From | To |