0b27478c7b6c11260b65161ac54c3f33ba76ef20
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Move And Inline Method | 3 | ||
Move And Inline Method public targetPathRoot(locationHandle LocationHandle) : Path moved from class com.facebook.presto.hive.HiveLocationService to class com.facebook.presto.hive.AbstractTestHiveClient & inlined to protected getTargetPathRoot(insertTableHandle ConnectorInsertTableHandle) : Path | From | To | |
Move And Inline Method public writePathRoot(locationHandle LocationHandle) : Optional<Path> moved from class com.facebook.presto.hive.HiveLocationService to class com.facebook.presto.hive.AbstractTestHiveClient & inlined to protected getStagingPathRoot(outputTableHandle ConnectorOutputTableHandle) : Path | From | To | |
Move And Inline Method public writePathRoot(locationHandle LocationHandle) : Optional<Path> moved from class com.facebook.presto.hive.HiveLocationService to class com.facebook.presto.hive.AbstractTestHiveClient & inlined to protected getStagingPathRoot(insertTableHandle ConnectorInsertTableHandle) : Path | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type writePath : Optional<Path> to writePath : Path in method public LocationHandle(targetPath Path, writePath Path, isExistingTable boolean, writeMode WriteMode) in class com.facebook.presto.hive.LocationHandle | From | To | |
Rename Variable | 3 | ||
Rename Variable writePathRoot : Optional<Path> to writeInfo : WriteInfo in method public beginInsert(session ConnectorSession, tableHandle ConnectorTableHandle) : HiveInsertTableHandle in class com.facebook.presto.hive.HiveMetadata | From | To | |
Rename Variable targetPathRoot : Path to writeInfo : WriteInfo in method public beginCreateTable(session ConnectorSession, tableMetadata ConnectorTableMetadata, layout Optional<ConnectorNewTableLayout>) : HiveOutputTableHandle in class com.facebook.presto.hive.HiveMetadata | From | To | |
Rename Variable targetPath : Path to writeInfo : WriteInfo in method public finishCreateTable(session ConnectorSession, tableHandle ConnectorOutputTableHandle, fragments Collection<Slice>) : Optional<ConnectorOutputMetadata> in class com.facebook.presto.hive.HiveMetadata | From | To | |
Change Return Type | 2 | ||
Change Return Type Optional<Path> to Path in method package getWritePath() : Path in class com.facebook.presto.hive.LocationHandle | From | To | |
Change Return Type Optional<String> to String in method public getJsonSerializableWritePath() : String in class com.facebook.presto.hive.LocationHandle | From | To | |
Merge Variable | 2 | ||
Merge Variable [target : Path, write : Path] to writeInfo : WriteInfo in method public createWriter(partitionColumns Page, position int, bucketNumber OptionalInt) : HiveWriter in class com.facebook.presto.hive.HiveWriterFactory | From | To | |
Merge Variable [mode : WriteMode, writePathRoot : Path] to writeInfo : WriteInfo in method public beginCreateTable(session ConnectorSession, tableMetadata ConnectorTableMetadata, layout Optional<ConnectorNewTableLayout>) : HiveOutputTableHandle in class com.facebook.presto.hive.HiveMetadata | From | To | |
Change Variable Type | 3 | ||
Change Variable Type writePathRoot : Optional<Path> to writeInfo : WriteInfo in method public beginInsert(session ConnectorSession, tableHandle ConnectorTableHandle) : HiveInsertTableHandle in class com.facebook.presto.hive.HiveMetadata | From | To | |
Change Variable Type targetPathRoot : Path to writeInfo : WriteInfo in method public beginCreateTable(session ConnectorSession, tableMetadata ConnectorTableMetadata, layout Optional<ConnectorNewTableLayout>) : HiveOutputTableHandle in class com.facebook.presto.hive.HiveMetadata | From | To | |
Change Variable Type targetPath : Path to writeInfo : WriteInfo in method public finishCreateTable(session ConnectorSession, tableHandle ConnectorOutputTableHandle, fragments Collection<Slice>) : Optional<ConnectorOutputMetadata> in class com.facebook.presto.hive.HiveMetadata | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type writePath : Optional<Path> to writePath : Path in class com.facebook.presto.hive.LocationHandle | From | To |