presto 1362aba8753425daf3c454548da4e3a93ed8d811

1362aba8753425daf3c454548da4e3a93ed8d811

Files Diff

Added: 9
Removed: 1
Renamed: 0
Modified: 35

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method private generateTryMethods(containerClassDefinition ClassDefinition, callSiteBinder CallSiteBinder, cachedInstanceBinder CachedInstanceBinder, projection RowExpression, methodPrefix String) : PreGeneratedExpressions renamed to private generateMethodsForLambdaAndTry(containerClassDefinition ClassDefinition, callSiteBinder CallSiteBinder, cachedInstanceBinder CachedInstanceBinder, projection RowExpression, methodPrefix String) : PreGeneratedExpressions in class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Rename Method private generateTryMethods(containerClassDefinition ClassDefinition, callSiteBinder CallSiteBinder, cachedInstanceBinder CachedInstanceBinder, projection RowExpression, methodPrefix String) : PreGeneratedExpressions renamed to private generateMethodsForLambdaAndTry(containerClassDefinition ClassDefinition, callSiteBinder CallSiteBinder, cachedInstanceBinder CachedInstanceBinder, projection RowExpression, methodPrefix String) : PreGeneratedExpressions in class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Rename Method private generateTryMethods(containerClassDefinition ClassDefinition, callSiteBinder CallSiteBinder, cachedInstanceBinder CachedInstanceBinder, leftBlocksSize int, filter RowExpression) : PreGeneratedExpressions renamed to private generateMethodsForLambdaAndTry(containerClassDefinition ClassDefinition, callSiteBinder CallSiteBinder, cachedInstanceBinder CachedInstanceBinder, leftBlocksSize int, filter RowExpression) : PreGeneratedExpressions in class com.facebook.presto.sql.gen.JoinFilterFunctionCompiler	From	To
Change Parameter Type	3
Change Parameter Type arguments : List<String> to arguments : List<LambdaArgumentDeclaration> in method private LambdaExpression(location Optional<NodeLocation>, arguments List<LambdaArgumentDeclaration>, body Expression) in class com.facebook.presto.sql.tree.LambdaExpression	From	To
Change Parameter Type arguments : List<String> to arguments : List<LambdaArgumentDeclaration> in method public LambdaExpression(arguments List<LambdaArgumentDeclaration>, body Expression) in class com.facebook.presto.sql.tree.LambdaExpression	From	To
Change Parameter Type arguments : List<String> to arguments : List<LambdaArgumentDeclaration> in method public LambdaExpression(location NodeLocation, arguments List<LambdaArgumentDeclaration>, body Expression) in class com.facebook.presto.sql.tree.LambdaExpression	From	To
Rename Variable	3
Rename Variable tryExpressions : List<RowExpression> to lambdaAndTryExpressions : List<RowExpression> in method private generateMethodsForLambdaAndTry(containerClassDefinition ClassDefinition, callSiteBinder CallSiteBinder, cachedInstanceBinder CachedInstanceBinder, projection RowExpression, methodPrefix String) : PreGeneratedExpressions in class com.facebook.presto.sql.gen.PageProcessorCompiler	From	To
Rename Variable tryExpressions : List<RowExpression> to lambdaAndTryExpressions : List<RowExpression> in method private generateMethodsForLambdaAndTry(containerClassDefinition ClassDefinition, callSiteBinder CallSiteBinder, cachedInstanceBinder CachedInstanceBinder, projection RowExpression, methodPrefix String) : PreGeneratedExpressions in class com.facebook.presto.sql.gen.CursorProcessorCompiler	From	To
Rename Variable tryExpressions : List<RowExpression> to lambdaAndTryExpressions : List<RowExpression> in method private generateMethodsForLambdaAndTry(containerClassDefinition ClassDefinition, callSiteBinder CallSiteBinder, cachedInstanceBinder CachedInstanceBinder, leftBlocksSize int, filter RowExpression) : PreGeneratedExpressions in class com.facebook.presto.sql.gen.JoinFilterFunctionCompiler	From	To
Change Return Type	2
Change Return Type void to boolean in method private appendTypeRelationshipConstraintSolver(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, formalTypeSignature TypeSignature, actualTypeSignatureProvider TypeSignatureProvider, allowCoercion boolean) : boolean in class com.facebook.presto.metadata.SignatureBinder	From	To
Change Return Type List<String> to List<LambdaArgumentDeclaration> in method public getArguments() : List<LambdaArgumentDeclaration> in class com.facebook.presto.sql.tree.LambdaExpression	From	To
Change Variable Type	1
Change Variable Type arguments : List<String> to arguments : List<LambdaArgumentDeclaration> in method public visitLambda(context SqlBaseParser.LambdaContext) : Node in class com.facebook.presto.sql.parser.AstBuilder	From	To
Extract Variable	1
Extract Variable argumentTypes : ImmutableList<TypeSignatureProvider> in method protected visitFunctionCall(node FunctionCall, context StackableAstVisitorContext<Context>) : Type from class com.facebook.presto.sql.analyzer.ExpressionAnalyzer.Visitor	From	To
Change Attribute Type	1
Change Attribute Type arguments : List<String> to arguments : List<LambdaArgumentDeclaration> in class com.facebook.presto.sql.tree.LambdaExpression	From	To
Extract Method	1
Extract Method private coerceType(expression Expression, actualType Type, expectedType Type, message String) : void extracted from private coerceType(context StackableAstVisitorContext<Context>, expression Expression, expectedType Type, message String) : void in class com.facebook.presto.sql.analyzer.ExpressionAnalyzer.Visitor	From	To

1362aba8753425daf3c454548da4e3a93ed8d811

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: