1376164ce3de09c555d9e370bbacf5cf293fe9a5
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 100
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public test() : void renamed to private testSetSession(expression Expression, expectedValue String) : void in class com.facebook.presto.execution.TestSetSessionTask | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type value : String to value : Expression in method public SetSession(name QualifiedName, value Expression) in class com.facebook.presto.sql.tree.SetSession | From | To | |
| Move Method | 1 | ||
| Move Method private evaluateConstantExpression(expression Expression) : Object from class com.facebook.presto.sql.planner.RelationPlanner to public evaluateConstantExpression(expression Expression, coercions IdentityHashMap<Expression,Type>, metadata Metadata, session Session) : Object from class com.facebook.presto.sql.planner.ExpressionInterpreter | From | To | |
| Rename Variable | 1 | ||
| Rename Variable entry : Entry<String,Map<String,String>> to sessionProperty : SessionPropertyValue in method protected visitShowSession(node ShowSession, context AnalysisContext) : TupleDescriptor in class com.facebook.presto.sql.analyzer.StatementAnalyzer | From | To | |
| Change Return Type | 1 | ||
| Change Return Type String to Expression in method public getValue() : Expression in class com.facebook.presto.sql.tree.SetSession | From | To | |
| Extract Attribute | 2 | ||
| Extract Attribute private metadata : MetadataManager in class com.facebook.presto.execution.TestResetSessionTask | From | To | |
| Extract Attribute private metadata : MetadataManager in class com.facebook.presto.execution.TestSetSessionTask | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute session : Session to TEST_SESSION : Session in method public testBasic() : void in class com.facebook.presto.execution.TestQueryQueueRule | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type entry : Entry<String,Map<String,String>> to sessionProperty : SessionPropertyValue in method protected visitShowSession(node ShowSession, context AnalysisContext) : TupleDescriptor in class com.facebook.presto.sql.analyzer.StatementAnalyzer | From | To | |
| Extract Variable | 2 | ||
| Extract Variable fullPropertyName : String in method private parseSessionHeader(header String, sessionPropertiesByCatalog Multimap<String,Entry<String,String>>, sessionPropertyManager SessionPropertyManager) : void from class com.facebook.presto.server.ResourceUtil | From | To | |
| Extract Variable name : String in method public execute(statement SetSession, session Session, metadata Metadata, stateMachine QueryStateMachine) : void from class com.facebook.presto.execution.SetSessionTask | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type properties : Map<String,String> to properties : Map<String,SessionPropertyMetadata<?>> in class com.facebook.presto.testing.TestingConnectorSession | From | To | |
| Change Attribute Type value : String to value : Expression in class com.facebook.presto.sql.tree.SetSession | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public getHashPartitionCount(session Session) : int extracted from public createQueryExecution(queryId QueryId, query String, session Session, statement Statement) : SqlQueryExecution in class com.facebook.presto.execution.SqlQueryExecution.SqlQueryExecutionFactory & moved to class com.facebook.presto.SystemSessionProperties | From | To |