13e1d0bc303af57738fa83becb862b621c21012a
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 46
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [COUNT_CALL : FunctionCall, COUNT : String] to functionResolution : StandardFunctionResolution in class com.facebook.presto.sql.planner.iterative.rule.TransformExistsApplyToLateralNode | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type functionManager : FunctionManager to functionResolution : StandardFunctionResolution in method public Rewriter(functionResolution StandardFunctionResolution, session Session, idAllocator PlanNodeIdAllocator, types TypeProvider, symbolAllocator SymbolAllocator) in class com.facebook.presto.sql.planner.optimizations.TransformQuantifiedComparisonApplyToLateralJoin.Rewriter | From | To | |
| Rename Variable | 4 | ||
| Rename Variable aggregation : FunctionCall to call : FunctionCall in method private addAggregation(output Symbol, expression Expression, inputTypes List<Type>, mask Optional<Symbol>) : AggregationBuilder in class com.facebook.presto.sql.planner.iterative.rule.test.PlanBuilder.AggregationBuilder | From | To | |
| Rename Variable arguments : ImmutableList.Builder<Expression> to argumentsBuilder : ImmutableList.Builder<Expression> in method private createNonDistinctAggregation(aggregateInfo AggregateInfo, distinctSymbol Symbol, duplicatedDistinctSymbol Symbol, groupByKeys Set<Symbol>, groupIdNode GroupIdNode, originalNode MarkDistinctNode, aggregationOutputSymbolsMapBuilder ImmutableMap.Builder<Symbol,Symbol>) : AggregationNode in class com.facebook.presto.sql.planner.optimizations.OptimizeMixedDistinctAggregations.Optimizer | From | To | |
| Rename Variable scalarAggregationSourceTypeSignatures : List<TypeSignature> to scalarAggregationSourceType : Type in method private createAggregationNode(scalarAggregation AggregationNode, leftOuterJoin JoinNode, nonNullableAggregationSourceSymbol Symbol) : Optional<AggregationNode> in class com.facebook.presto.sql.planner.optimizations.ScalarAggregationToJoinRewriter | From | To | |
| Rename Variable functionCall : FunctionCall to aggregation : Aggregation in method private createNonDistinctAggregation(aggregateInfo AggregateInfo, distinctSymbol Symbol, duplicatedDistinctSymbol Symbol, groupByKeys Set<Symbol>, groupIdNode GroupIdNode, originalNode MarkDistinctNode, aggregationOutputSymbolsMapBuilder ImmutableMap.Builder<Symbol,Symbol>) : AggregationNode in class com.facebook.presto.sql.planner.optimizations.OptimizeMixedDistinctAggregations.Optimizer | From | To | |
| Inline Method | 1 | ||
| Inline Method private getType(expression Expression) : Type inlined to public rewriteAtTimeZone(node AtTimeZone, context Void, treeRewriter ExpressionTreeRewriter<Void>) : Expression in class com.facebook.presto.sql.planner.DesugarAtTimeZoneRewriter.Visitor | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private functionManager : FunctionManager from class com.facebook.presto.sql.planner.iterative.rule.SimplifyCountOverConstant to private functionManager : FunctionManager from class com.facebook.presto.sql.planner.iterative.rule.PushAggregationThroughOuterJoin | From | To | |
| Move Attribute private functionManager : FunctionManager from class com.facebook.presto.sql.planner.iterative.rule.TransformExistsApplyToLateralNode to private functionManager : FunctionManager from class com.facebook.presto.sql.planner.iterative.rule.PushAggregationThroughOuterJoin | From | To | |
| Move Attribute private functionManager : FunctionManager from class com.facebook.presto.sql.planner.iterative.rule.TransformCorrelatedInPredicateToJoin to private functionManager : FunctionManager from class com.facebook.presto.sql.planner.iterative.rule.PushAggregationThroughOuterJoin | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute functionManager : FunctionManager to functionResolution : StandardFunctionResolution in class com.facebook.presto.sql.planner.optimizations.TransformQuantifiedComparisonApplyToLateralJoin.Rewriter | From | To | |
| Rename Attribute call : FunctionCall to filter : Optional<Expression> in class com.facebook.presto.sql.planner.plan.AggregationNode.Aggregation | From | To | |
| Rename Attribute functionManager : FunctionManager to functionResolution : StandardFunctionResolution in class com.facebook.presto.sql.planner.optimizations.TransformQuantifiedComparisonApplyToLateralJoin | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type scalarAggregationSourceTypeSignatures : List<TypeSignature> to scalarAggregationSourceType : Type in method private createAggregationNode(scalarAggregation AggregationNode, leftOuterJoin JoinNode, nonNullableAggregationSourceSymbol Symbol) : Optional<AggregationNode> in class com.facebook.presto.sql.planner.optimizations.ScalarAggregationToJoinRewriter | From | To | |
| Change Variable Type name : QualifiedName to name : String in method public apply(node AggregationNode, captures Captures, context Context) : Result in class com.facebook.presto.sql.planner.iterative.rule.RewriteSpatialPartitioningAggregation | From | To | |
| Change Variable Type orderBy : OrderBy to orderBy : OrderingScheme in method private buildAccumulatorFactory(source PhysicalOperation, aggregation Aggregation) : AccumulatorFactory in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Change Variable Type functionCall : FunctionCall to aggregation : Aggregation in method private createNonDistinctAggregation(aggregateInfo AggregateInfo, distinctSymbol Symbol, duplicatedDistinctSymbol Symbol, groupByKeys Set<Symbol>, groupIdNode GroupIdNode, originalNode MarkDistinctNode, aggregationOutputSymbolsMapBuilder ImmutableMap.Builder<Symbol,Symbol>) : AggregationNode in class com.facebook.presto.sql.planner.optimizations.OptimizeMixedDistinctAggregations.Optimizer | From | To | |
| Change Variable Type functionName : QualifiedName to functionName : String in method private split(node AggregationNode, context Context) : PlanNode in class com.facebook.presto.sql.planner.iterative.rule.PushPartialAggregationThroughExchange | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type functionManager : FunctionManager to functionResolution : StandardFunctionResolution in class com.facebook.presto.sql.planner.optimizations.TransformQuantifiedComparisonApplyToLateralJoin.Rewriter | From | To | |
| Change Attribute Type call : FunctionCall to filter : Optional<Expression> in class com.facebook.presto.sql.planner.plan.AggregationNode.Aggregation | From | To | |
| Change Attribute Type functionManager : FunctionManager to functionResolution : StandardFunctionResolution in class com.facebook.presto.sql.planner.optimizations.TransformQuantifiedComparisonApplyToLateralJoin | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter aggregation : AggregationNode to aggregationNode : AggregationNode in method private hasSpatialPartitioningAggregation(aggregationNode AggregationNode) : boolean in class com.facebook.presto.sql.planner.iterative.rule.RewriteSpatialPartitioningAggregation | From | To | |
| Rename Parameter functionManager : FunctionManager to functionResolution : StandardFunctionResolution in method public Rewriter(functionResolution StandardFunctionResolution, session Session, idAllocator PlanNodeIdAllocator, types TypeProvider, symbolAllocator SymbolAllocator) in class com.facebook.presto.sql.planner.optimizations.TransformQuantifiedComparisonApplyToLateralJoin.Rewriter | From | To |