18d97f3dcc8ebbd42ea1e25e975b8cf2df8dbbac
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public testRoundTrip() : void renamed to public testPartitionKeyColumn() : void in class com.facebook.presto.hive.TestHiveColumnHandle | From | To | |
| Rename Method public getNonPartitionKeyColumnHandles(connectorId String, table Table, forceIntegralToBigint boolean) : List<HiveColumnHandle> renamed to public getRegularColumnHandles(connectorId String, table Table, forceIntegralToBigint boolean) : List<HiveColumnHandle> in class com.facebook.presto.hive.HiveUtil | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type partitionKey : boolean to columnType : ColumnType in method public HiveColumnHandle(clientId String, name String, hiveType HiveType, typeSignature TypeSignature, hiveColumnIndex int, columnType ColumnType) in class com.facebook.presto.hive.HiveColumnHandle | From | To | |
| Rename Variable | 4 | ||
| Rename Variable expected : HiveColumnHandle to expectedRegularColumn : HiveColumnHandle in method public testPartitionKeyColumn() : void in class com.facebook.presto.hive.TestHiveColumnHandle | From | To | |
| Rename Variable isPartitionKey : boolean to isPrefilledColumn : boolean in method public ParquetHiveRecordCursor(hdfsEnvironment HdfsEnvironment, sessionUser String, configuration Configuration, path Path, start long, length long, splitSchema Properties, partitionKeys List<HivePartitionKey>, columns List<HiveColumnHandle>, useParquetColumnNames boolean, hiveStorageTimeZone DateTimeZone, typeManager TypeManager, predicatePushdownEnabled boolean, effectivePredicate TupleDomain<HiveColumnHandle>) in class com.facebook.presto.hive.parquet.ParquetHiveRecordCursor | From | To | |
| Rename Variable partitionKeyValue : String to columnValue : String in method public ParquetHiveRecordCursor(hdfsEnvironment HdfsEnvironment, sessionUser String, configuration Configuration, path Path, start long, length long, splitSchema Properties, partitionKeys List<HivePartitionKey>, columns List<HiveColumnHandle>, useParquetColumnNames boolean, hiveStorageTimeZone DateTimeZone, typeManager TypeManager, predicatePushdownEnabled boolean, effectivePredicate TupleDomain<HiveColumnHandle>) in class com.facebook.presto.hive.parquet.ParquetHiveRecordCursor | From | To | |
| Rename Variable nonPartitionColumnsSupported : boolean to regularColumnsSupported : boolean in method private columnTypeSupported(columns List<HiveColumnHandle>) : boolean in class com.facebook.presto.hive.parquet.ParquetPageSourceFactory | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute partitionKey : boolean to columnType : ColumnType in class com.facebook.presto.hive.HiveColumnHandle | From | To | |
| Rename Attribute isPartitionColumn : boolean[] to isPrefilledColumn : boolean[] in class com.facebook.presto.hive.GenericHiveRecordCursor | From | To | |
| Rename Attribute isPartitionColumn : boolean[] to isPrefilledColumn : boolean[] in class com.facebook.presto.hive.ColumnarBinaryHiveRecordCursor | From | To | |
| Rename Attribute isPartitionColumn : boolean[] to isPrefilledColumn : boolean[] in class com.facebook.presto.hive.ColumnarTextHiveRecordCursor | From | To | |
| Extract Method | 1 | ||
| Extract Method private testRoundTrip(expected HiveColumnHandle) : void extracted from public testRoundTrip() : void in class com.facebook.presto.hive.TestHiveColumnHandle | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type partitionKey : boolean to columnType : ColumnType in class com.facebook.presto.hive.HiveColumnHandle | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public getPrefilledColumnValue(columnHandle HiveColumnHandle, partitionKey HivePartitionKey, path Path) : String extracted from public ParquetHiveRecordCursor(hdfsEnvironment HdfsEnvironment, sessionUser String, configuration Configuration, path Path, start long, length long, splitSchema Properties, partitionKeys List<HivePartitionKey>, columns List<HiveColumnHandle>, useParquetColumnNames boolean, hiveStorageTimeZone DateTimeZone, typeManager TypeManager, predicatePushdownEnabled boolean, effectivePredicate TupleDomain<HiveColumnHandle>) in class com.facebook.presto.hive.parquet.ParquetHiveRecordCursor & moved to class com.facebook.presto.hive.HiveUtil | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter partitionKey : boolean to columnType : ColumnType in method public HiveColumnHandle(clientId String, name String, hiveType HiveType, typeSignature TypeSignature, hiveColumnIndex int, columnType ColumnType) in class com.facebook.presto.hive.HiveColumnHandle | From | To |