1b4d46351d214881c9fb499e06bb519a7f150b96
Files Diff
- Added: 9
- Removed: 0
- Renamed: 0
- Modified: 19
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private getRowsInternal(splitId PrestoThriftId, columnNames List<String>, maxBytes long, nextToken PrestoThriftId) : PrestoThriftPageResult renamed to private getRowsSync(splitId PrestoThriftId, outputColumns List<String>, maxBytes long, nextToken PrestoThriftNullableToken) : PrestoThriftPageResult in class com.facebook.presto.connector.thrift.server.ThriftTpchService | From | To | |
| Rename Method private getSplitsInternal(schemaTableName PrestoThriftSchemaTableName, maxSplitCount int, nextToken PrestoThriftId) : PrestoThriftSplitBatch renamed to private getSplitsSync(schemaTableName PrestoThriftSchemaTableName, maxSplitCount int, nextToken PrestoThriftNullableToken) : PrestoThriftSplitBatch in class com.facebook.presto.connector.thrift.server.ThriftTpchService | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type nextToken : PrestoThriftId to nextToken : PrestoThriftNullableToken in method private getSplitsSync(schemaTableName PrestoThriftSchemaTableName, maxSplitCount int, nextToken PrestoThriftNullableToken) : PrestoThriftSplitBatch in class com.facebook.presto.connector.thrift.server.ThriftTpchService | From | To | |
| Change Parameter Type nextToken : PrestoThriftId to nextToken : PrestoThriftNullableToken in method private getRowsSync(splitId PrestoThriftId, outputColumns List<String>, maxBytes long, nextToken PrestoThriftNullableToken) : PrestoThriftPageResult in class com.facebook.presto.connector.thrift.server.ThriftTpchService | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute dataExecutor : ListeningExecutorService to executor : ListeningExecutorService in class com.facebook.presto.connector.thrift.server.ThriftTpchService | From | To | |
| Extract Variable | 1 | ||
| Extract Variable service : ThriftTpchService in method private startThriftServers(thriftServers int, enableIndexJoin boolean) : List<ThriftServer> from class com.facebook.presto.connector.thrift.integration.ThriftQueryRunner | From | To | |
| Extract Method | 1 | ||
| Extract Method private getRowsInternal(pageSource ConnectorPageSource, tableName String, columnNames List<String>, nextToken PrestoThriftId) : PrestoThriftPageResult extracted from private getRowsInternal(splitId PrestoThriftId, columnNames List<String>, maxBytes long, nextToken PrestoThriftId) : PrestoThriftPageResult in class com.facebook.presto.connector.thrift.server.ThriftTpchService | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public normalSplit(schemaName String, tableName String, partNumber int, totalParts int) : SplitInfo extracted from private getSplitsInternal(schemaTableName PrestoThriftSchemaTableName, maxSplitCount int, nextToken PrestoThriftId) : PrestoThriftSplitBatch in class com.facebook.presto.connector.thrift.server.ThriftTpchService & moved to class com.facebook.presto.connector.thrift.server.SplitInfo | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter columnNames : List<String> to outputColumns : List<String> in method private getRowsSync(splitId PrestoThriftId, outputColumns List<String>, maxBytes long, nextToken PrestoThriftNullableToken) : PrestoThriftPageResult in class com.facebook.presto.connector.thrift.server.ThriftTpchService | From | To | |
| Rename Parameter columns : List<String> to outputColumns : List<String> in method public getRows(splitId PrestoThriftId, outputColumns List<String>, maxBytes long, nextToken PrestoThriftNullableToken) : ListenableFuture<PrestoThriftPageResult> in class com.facebook.presto.connector.thrift.server.ThriftTpchService | From | To |