1ce3a0bece889a7d9a5bc5cab0d308b9120e0c21
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public getLength() : long renamed to public getEnd() : long in class com.facebook.presto.hive.InternalHiveSplit | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type splits : Iterator<? extends InternalHiveSplit> to splits : List<? extends InternalHiveSplit> in method package addToQueue(splits List<? extends InternalHiveSplit>) : CompletableFuture<?> in class com.facebook.presto.hive.HiveSplitSource | From | To | |
| Change Parameter Type addresses : List<HostAddress> to blocks : List<InternalHiveBlock> in method public InternalHiveSplit(partitionName String, path String, start long, end long, fileSize long, schema Properties, partitionKeys List<HivePartitionKey>, blocks List<InternalHiveBlock>, bucketNumber OptionalInt, splittable boolean, forceLocalScheduling boolean, columnCoercions Map<Integer,HiveTypeName>) in class com.facebook.presto.hive.InternalHiveSplit | From | To | |
| Move Method | 1 | ||
| Move Method public getAddresses() : List<HostAddress> from class com.facebook.presto.hive.InternalHiveSplit to public getAddresses() : List<HostAddress> from class com.facebook.presto.hive.InternalHiveSplit.InternalHiveBlock | From | To | |
| Rename Variable | 2 | ||
| Rename Variable iteratorList : List<Iterator<InternalHiveSplit>> to splitList : List<InternalHiveSplit> in method private loadPartition(partition HivePartitionMetadata) : CompletableFuture<?> in class com.facebook.presto.hive.BackgroundHiveSplitLoader | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to CompletableFuture<?> in method private loadPartition(partition HivePartitionMetadata) : CompletableFuture<?> in class com.facebook.presto.hive.BackgroundHiveSplitLoader | From | To | |
| Change Return Type boolean to CompletableFuture<?> in method private addSplitsToSource(targetSplits InputSplit[], partitionName String, partitionKeys List<HivePartitionKey>, schema Properties, effectivePredicate TupleDomain<HiveColumnHandle>, columnCoercions Map<Integer,HiveTypeName>, pathDomain Optional<Domain>) : CompletableFuture<?> in class com.facebook.presto.hive.BackgroundHiveSplitLoader | From | To | |
| Move Attribute | 5 | ||
| Move Attribute private HOST_ADDRESS_INSTANCE_SIZE : int from class com.facebook.presto.hive.InternalHiveSplit to private HOST_ADDRESS_INSTANCE_SIZE : int from class com.facebook.presto.hive.InternalHiveSplit.InternalHiveBlock | From | To | |
| Move Attribute private remainingInitialSplits : AtomicInteger from class com.facebook.presto.hive.BackgroundHiveSplitLoader to private remainingInitialSplits : AtomicInteger from class com.facebook.presto.hive.HiveSplitSource | From | To | |
| Move Attribute private addresses : List<HostAddress> from class com.facebook.presto.hive.InternalHiveSplit to private addresses : List<HostAddress> from class com.facebook.presto.hive.InternalHiveSplit.InternalHiveBlock | From | To | |
| Move Attribute private maxSplitSize : DataSize from class com.facebook.presto.hive.BackgroundHiveSplitLoader to private maxSplitSize : DataSize from class com.facebook.presto.hive.HiveSplitSource | From | To | |
| Move Attribute private maxInitialSplitSize : DataSize from class com.facebook.presto.hive.BackgroundHiveSplitLoader to private maxInitialSplitSize : DataSize from class com.facebook.presto.hive.HiveSplitSource | From | To | |
| Extract Class | 1 | ||
| Extract Class com.facebook.presto.hive.InternalHiveSplit.InternalHiveBlock from class com.facebook.presto.hive.InternalHiveSplit | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute length : long to end : long in class com.facebook.presto.hive.InternalHiveSplit | From | To | |
| Rename Attribute addresses : List<HostAddress> to blocks : List<InternalHiveBlock> in class com.facebook.presto.hive.InternalHiveSplit | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type iteratorList : List<Iterator<InternalHiveSplit>> to splitList : List<InternalHiveSplit> in method private loadPartition(partition HivePartitionMetadata) : CompletableFuture<?> in class com.facebook.presto.hive.BackgroundHiveSplitLoader | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type addresses : List<HostAddress> to blocks : List<InternalHiveBlock> in class com.facebook.presto.hive.InternalHiveSplit | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter addresses : List<HostAddress> to blocks : List<InternalHiveBlock> in method public InternalHiveSplit(partitionName String, path String, start long, end long, fileSize long, schema Properties, partitionKeys List<HivePartitionKey>, blocks List<InternalHiveBlock>, bucketNumber OptionalInt, splittable boolean, forceLocalScheduling boolean, columnCoercions Map<Integer,HiveTypeName>) in class com.facebook.presto.hive.InternalHiveSplit | From | To | |
| Rename Parameter length : long to end : long in method public InternalHiveSplit(partitionName String, path String, start long, end long, fileSize long, schema Properties, partitionKeys List<HivePartitionKey>, blocks List<InternalHiveBlock>, bucketNumber OptionalInt, splittable boolean, forceLocalScheduling boolean, columnCoercions Map<Integer,HiveTypeName>) in class com.facebook.presto.hive.InternalHiveSplit | From | To |