presto 22e5423d88679bec88ddeb3168c7d77e3f1ec16a

22e5423d88679bec88ddeb3168c7d77e3f1ec16a

Files Diff

Added: 12
Removed: 8
Renamed: 0
Modified: 97

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	17
Change Parameter Type systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public ArbitraryOutputBuffer(taskInstanceId String, state StateMachine<BufferState>, maxBufferSize DataSize, systemMemoryUsageListener SystemMemoryUsageListener, notificationExecutor Executor) in class com.facebook.presto.execution.buffer.ArbitraryOutputBuffer	From	To
Change Parameter Type systemMemoryUsage : AggregatedMemoryContext to systemMemoryUsage : AbstractAggregatedMemoryContext in method public createRecordReader(includedColumns Map<Integer,Type>, predicate OrcPredicate, hiveStorageTimeZone DateTimeZone, systemMemoryUsage AbstractAggregatedMemoryContext) : OrcRecordReader in class com.facebook.presto.orc.OrcReader	From	To
Change Parameter Type systemMemoryContext : AggregatedMemoryContext to systemMemoryContext : AbstractAggregatedMemoryContext in method public OrcInputStream(orcDataSourceId OrcDataSourceId, sliceInput FixedLengthSliceInput, decompressor Optional<OrcDecompressor>, systemMemoryContext AbstractAggregatedMemoryContext) in class com.facebook.presto.orc.stream.OrcInputStream	From	To
Change Parameter Type systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in method public get(systemMemoryUsageListener SystemMemoryUsageListener) : ExchangeClient in class com.facebook.presto.operator.ExchangeClientFactory	From	To
Change Parameter Type systemMemoryUsage : AggregatedMemoryContext to systemMemoryUsage : AbstractAggregatedMemoryContext in method public OrcRecordReader(includedColumns Map<Integer,Type>, predicate OrcPredicate, numberOfRows long, fileStripes List<StripeInformation>, fileStats List<ColumnStatistics>, stripeStats List<StripeStatistics>, orcDataSource OrcDataSource, splitOffset long, splitLength long, types List<OrcType>, decompressor Optional<OrcDecompressor>, rowsInRowGroup int, hiveStorageTimeZone DateTimeZone, hiveWriterVersion HiveWriterVersion, metadataReader MetadataReader, maxMergeDistance DataSize, maxReadSize DataSize, maxBlockSize DataSize, userMetadata Map<String,Slice>, systemMemoryUsage AbstractAggregatedMemoryContext, writeValidation Optional<OrcWriteValidation>) in class com.facebook.presto.orc.OrcRecordReader	From	To
Change Parameter Type systemMemoryUsage : AggregatedMemoryContext to systemMemoryUsage : AbstractAggregatedMemoryContext in method public createRecordReader(includedColumns Map<Integer,Type>, predicate OrcPredicate, offset long, length long, hiveStorageTimeZone DateTimeZone, systemMemoryUsage AbstractAggregatedMemoryContext) : OrcRecordReader in class com.facebook.presto.orc.OrcReader	From	To
Change Parameter Type systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public OutputBufferMemoryManager(maxBufferedBytes long, systemMemoryUsageListener SystemMemoryUsageListener, notificationExecutor Executor) in class com.facebook.presto.execution.buffer.OutputBufferMemoryManager	From	To
Change Parameter Type systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in method public get(systemMemoryUsageListener SystemMemoryUsageListener) : ExchangeClient in class com.facebook.presto.operator.ExchangeClientSupplier	From	To
Change Parameter Type parentMemoryContext : AggregatedMemoryContext to parentMemoryContext : AbstractAggregatedMemoryContext in method public LocalMemoryContext(parentMemoryContext AbstractAggregatedMemoryContext) in class com.facebook.presto.memory.LocalMemoryContext	From	To
Change Parameter Type systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public PartitionedOutputBuffer(taskInstanceId String, state StateMachine<BufferState>, outputBuffers OutputBuffers, maxBufferSize DataSize, systemMemoryUsageListener SystemMemoryUsageListener, notificationExecutor Executor) in class com.facebook.presto.execution.buffer.PartitionedOutputBuffer	From	To
Change Parameter Type systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in method public get(systemMemoryUsageListener SystemMemoryUsageListener) : ExchangeClient in class com.facebook.presto.execution.TestSqlTaskManager.MockExchangeClientSupplier	From	To
Change Parameter Type systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in method public ExchangeClient(bufferCapacity DataSize, maxResponseSize DataSize, concurrentRequestMultiplier int, minErrorDuration Duration, maxErrorDuration Duration, httpClient HttpClient, scheduler ScheduledExecutorService, systemMemoryUsageListener SystemMemoryUsageListener, pageBufferClientCallbackExecutor Executor) in class com.facebook.presto.operator.ExchangeClient	From	To
Change Parameter Type systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public LazyOutputBuffer(taskId TaskId, taskInstanceId String, executor Executor, maxBufferSize DataSize, systemMemoryUsageListener SystemMemoryUsageListener) in class com.facebook.presto.execution.buffer.LazyOutputBuffer	From	To
Change Parameter Type systemMemoryUsage : AggregatedMemoryContext to systemMemoryUsage : AbstractAggregatedMemoryContext in method public readStripeFooter(stripe StripeInformation, systemMemoryUsage AbstractAggregatedMemoryContext) : StripeFooter in class com.facebook.presto.orc.StripeReader	From	To
Change Parameter Type systemMemoryUsage : AggregatedMemoryContext to systemMemoryUsage : AbstractAggregatedMemoryContext in method public readDiskRanges(stripeOffset long, diskRanges Map<StreamId,DiskRange>, systemMemoryUsage AbstractAggregatedMemoryContext) : Map<StreamId,OrcInputStream> in class com.facebook.presto.orc.StripeReader	From	To
Change Parameter Type localUserMemoryContext : LocalMemoryContext to operatorContext : OperatorContext in method private TopNBuilder(n int, sortTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>, operatorContext OperatorContext) in class com.facebook.presto.operator.TopNOperator.TopNBuilder	From	To
Change Parameter Type systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public BroadcastOutputBuffer(taskInstanceId String, state StateMachine<BufferState>, maxBufferSize DataSize, systemMemoryUsageListener SystemMemoryUsageListener, notificationExecutor Executor) in class com.facebook.presto.execution.buffer.BroadcastOutputBuffer	From	To
Rename Class	1
Rename Class com.facebook.presto.memory.SimpleLocalMemoryContext renamed to com.facebook.presto.memory.LocalMemoryContext	From	To
Move And Rename Class	1
Move And Rename Class com.facebook.presto.memory.LocalMemoryContext moved and renamed to com.facebook.presto.execution.SystemMemoryUsageListener	From	To
Move Class	1
Move Class com.facebook.presto.memory.AggregatedMemoryContext moved to com.facebook.presto.orc.memory.AggregatedMemoryContext	From	To
Change Variable Type	1
Change Variable Type transferredBytesMemoryContext : LocalMemoryContext to taskContext : TaskContext in method public transferMemoryToTaskContext(taskBytes long) : void in class com.facebook.presto.operator.OperatorContext	From	To
Split Attribute	4
Split Attribute pipelineMemoryContext : MemoryTrackingContext to [memoryReservation : AtomicLong, revocableMemoryReservation : AtomicLong, systemMemoryReservation : AtomicLong] in class com.facebook.presto.operator.PipelineContext	From	To
Split Attribute queryMemoryContext : MemoryTrackingContext to [reserved : long, revocableReserved : long] in class com.facebook.presto.memory.QueryContext	From	To
Split Attribute driverMemoryContext : MemoryTrackingContext to [memoryReservation : AtomicLong, peakMemoryReservation : AtomicLong, revocableMemoryReservation : AtomicLong] in class com.facebook.presto.operator.DriverContext	From	To
Split Attribute operatorMemoryContext : MemoryTrackingContext to [revocableMemoryReservation : long, memoryReservation : AtomicLong, systemMemoryContext : OperatorSystemMemoryContext] in class com.facebook.presto.operator.OperatorContext	From	To
Pull Up Method	2
Pull Up Method public newAggregatedMemoryContext() : AggregatedMemoryContext from class com.facebook.presto.memory.AggregatedMemoryContext to public newAggregatedMemoryContext() : AggregatedMemoryContext from class com.facebook.presto.hive.parquet.memory.AbstractAggregatedMemoryContext	From	To
Pull Up Method public newLocalMemoryContext() : LocalMemoryContext from class com.facebook.presto.memory.AggregatedMemoryContext to public newLocalMemoryContext() : LocalMemoryContext from class com.facebook.presto.hive.parquet.memory.AbstractAggregatedMemoryContext	From	To
Rename Variable	2
Rename Variable userMemory : long to currentMemory : long in method public getTaskStats() : TaskStats in class com.facebook.presto.operator.TaskContext	From	To
Rename Variable transferredBytesMemoryContext : LocalMemoryContext to taskContext : TaskContext in method public transferMemoryToTaskContext(taskBytes long) : void in class com.facebook.presto.operator.OperatorContext	From	To
Change Return Type	2
Change Return Type ListenableFuture<?> to void in method public setBytes(bytes long) : void in class com.facebook.presto.memory.LocalMemoryContext	From	To
Change Return Type ListenableFuture<?> to void in method protected updateBytes(bytes long) : void in class com.facebook.presto.orc.memory.AggregatedMemoryContext	From	To
Extract Superclass	3
Extract Superclass com.facebook.presto.memory.AbstractAggregatedMemoryContext from classes [com.facebook.presto.orc.memory.AggregatedMemoryContext]	From	To
Extract Superclass com.facebook.presto.hive.parquet.memory.AbstractAggregatedMemoryContext from classes [com.facebook.presto.orc.memory.AggregatedMemoryContext]	From	To
Extract Superclass com.facebook.presto.orc.memory.AbstractAggregatedMemoryContext from classes [com.facebook.presto.orc.memory.AggregatedMemoryContext]	From	To
Rename Attribute	5
Rename Attribute localUserMemoryContext : LocalMemoryContext to operatorContext : OperatorContext in class com.facebook.presto.operator.TopNOperator.TopNBuilder	From	To
Rename Attribute systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in class com.facebook.presto.execution.buffer.OutputBufferMemoryManager	From	To
Rename Attribute aggregatedMemoryContext : AggregatedMemoryContext to memoryContext : AggregatedMemoryContext in class com.facebook.presto.spiller.GenericSpiller	From	To
Rename Attribute systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in class com.facebook.presto.execution.buffer.LazyOutputBuffer	From	To
Rename Attribute systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in class com.facebook.presto.operator.ExchangeClient	From	To
Change Attribute Type	8
Change Attribute Type localUserMemoryContext : LocalMemoryContext to operatorContext : OperatorContext in class com.facebook.presto.operator.TopNOperator.TopNBuilder	From	To
Change Attribute Type memoryContext : AggregatedMemoryContext to memoryContext : SynchronizedAggregatedMemoryContext in class com.facebook.presto.spiller.GenericPartitioningSpiller	From	To
Change Attribute Type systemMemoryUsage : AggregatedMemoryContext to systemMemoryUsage : AbstractAggregatedMemoryContext in class com.facebook.presto.orc.OrcRecordReader	From	To
Change Attribute Type parentMemoryContext : AggregatedMemoryContext to parentMemoryContext : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.LocalMemoryContext	From	To
Change Attribute Type systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in class com.facebook.presto.execution.buffer.OutputBufferMemoryManager	From	To
Change Attribute Type parentMemoryContext : AggregatedMemoryContext to parentMemoryContext : AbstractAggregatedMemoryContext in class com.facebook.presto.orc.memory.AggregatedMemoryContext	From	To
Change Attribute Type systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in class com.facebook.presto.execution.buffer.LazyOutputBuffer	From	To
Change Attribute Type systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in class com.facebook.presto.operator.ExchangeClient	From	To
Rename Parameter	13
Rename Parameter systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public OutputBufferMemoryManager(maxBufferedBytes long, systemMemoryUsageListener SystemMemoryUsageListener, notificationExecutor Executor) in class com.facebook.presto.execution.buffer.OutputBufferMemoryManager	From	To
Rename Parameter systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in method public get(systemMemoryUsageListener SystemMemoryUsageListener) : ExchangeClient in class com.facebook.presto.operator.ExchangeClientSupplier	From	To
Rename Parameter systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public PartitionedOutputBuffer(taskInstanceId String, state StateMachine<BufferState>, outputBuffers OutputBuffers, maxBufferSize DataSize, systemMemoryUsageListener SystemMemoryUsageListener, notificationExecutor Executor) in class com.facebook.presto.execution.buffer.PartitionedOutputBuffer	From	To
Rename Parameter systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in method public get(systemMemoryUsageListener SystemMemoryUsageListener) : ExchangeClient in class com.facebook.presto.execution.TestSqlTaskManager.MockExchangeClientSupplier	From	To
Rename Parameter systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in method public ExchangeClient(bufferCapacity DataSize, maxResponseSize DataSize, concurrentRequestMultiplier int, minErrorDuration Duration, maxErrorDuration Duration, httpClient HttpClient, scheduler ScheduledExecutorService, systemMemoryUsageListener SystemMemoryUsageListener, pageBufferClientCallbackExecutor Executor) in class com.facebook.presto.operator.ExchangeClient	From	To
Rename Parameter systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public ArbitraryOutputBuffer(taskInstanceId String, state StateMachine<BufferState>, maxBufferSize DataSize, systemMemoryUsageListener SystemMemoryUsageListener, notificationExecutor Executor) in class com.facebook.presto.execution.buffer.ArbitraryOutputBuffer	From	To
Rename Parameter aggregatedMemoryContext : AggregatedMemoryContext to memoryContext : AggregatedMemoryContext in method public create(types List<Type>, localSpillContext SpillContext, memoryContext AggregatedMemoryContext) : Spiller in class com.facebook.presto.spiller.GenericSpillerFactory	From	To
Rename Parameter aggregatedMemoryContext : AggregatedMemoryContext to memoryContext : AggregatedMemoryContext in method public GenericSpiller(types List<Type>, spillContext SpillContext, memoryContext AggregatedMemoryContext, singleStreamSpillerFactory SingleStreamSpillerFactory) in class com.facebook.presto.spiller.GenericSpiller	From	To
Rename Parameter systemMemoryContext : LocalMemoryContext to systemMemoryUsageListener : SystemMemoryUsageListener in method public get(systemMemoryUsageListener SystemMemoryUsageListener) : ExchangeClient in class com.facebook.presto.operator.ExchangeClientFactory	From	To
Rename Parameter localUserMemoryContext : LocalMemoryContext to operatorContext : OperatorContext in method private TopNBuilder(n int, sortTypes List<Type>, sortChannels List<Integer>, sortOrders List<SortOrder>, operatorContext OperatorContext) in class com.facebook.presto.operator.TopNOperator.TopNBuilder	From	To
Rename Parameter aggregatedMemoryContext : AggregatedMemoryContext to memoryContext : AggregatedMemoryContext in method public create(types List<Type>, localSpillContext SpillContext, memoryContext AggregatedMemoryContext) : Spiller in class com.facebook.presto.spiller.SpillerFactory	From	To
Rename Parameter systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public LazyOutputBuffer(taskId TaskId, taskInstanceId String, executor Executor, maxBufferSize DataSize, systemMemoryUsageListener SystemMemoryUsageListener) in class com.facebook.presto.execution.buffer.LazyOutputBuffer	From	To
Rename Parameter systemMemoryContextSupplier : Supplier<LocalMemoryContext> to systemMemoryUsageListener : SystemMemoryUsageListener in method public BroadcastOutputBuffer(taskInstanceId String, state StateMachine<BufferState>, maxBufferSize DataSize, systemMemoryUsageListener SystemMemoryUsageListener, notificationExecutor Executor) in class com.facebook.presto.execution.buffer.BroadcastOutputBuffer	From	To

22e5423d88679bec88ddeb3168c7d77e3f1ec16a

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: