presto 2790951f161fc694b116d6b637dc657ae9262354

2790951f161fc694b116d6b637dc657ae9262354

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 21

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method public getSearchExpression() : Expression renamed to public getSearchExpressions() : List<Expression> in class com.facebook.presto.sql.planner.SortExpressionContext	From	To
Change Parameter Type	9
Change Parameter Type searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public HashBuilderOperatorFactory(operatorId int, planNodeId PlanNodeId, types List<Type>, outputChannels List<Integer>, layout Map<Symbol,Integer>, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, outer boolean, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>, expectedPositions int, partitionCount int, pagesIndexFactory PagesIndex.Factory) in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory	From	To
Change Parameter Type searchFunction : JoinFilterFunction to searchFunctions : List<JoinFilterFunction> in method private SortedPositionLinks(positionLinks PositionLinks, sortedPositionLinks int[][], searchFunctions List<JoinFilterFunction>) in class com.facebook.presto.operator.SortedPositionLinks	From	To
Change Parameter Type searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>) : LookupSourceSupplier in class com.facebook.presto.operator.PagesIndex	From	To
Change Parameter Type searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>, outputChannels Optional<List<Integer>>) : LookupSourceSupplier in class com.facebook.presto.operator.PagesIndex	From	To
Change Parameter Type startingPosition : int to searchFunction : JoinFilterFunction in method private applySearchFunction(searchFunction JoinFilterFunction, links int[], linkOffset int, probePosition int, allProbeChannelsPage Page) : boolean in class com.facebook.presto.operator.SortedPositionLinks	From	To
Change Parameter Type startingPosition : int to searchFunction : JoinFilterFunction in method private findStartPositionForFunction(searchFunction JoinFilterFunction, links int[], startOffset int, probePosition int, allProbeChannelsPage Page) : int in class com.facebook.presto.operator.SortedPositionLinks	From	To
Change Parameter Type searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public HashBuilderOperator(operatorContext OperatorContext, lookupSourceFactory PartitionedLookupSourceFactory, partitionIndex int, outputChannels List<Integer>, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>, expectedPositions int, pagesIndexFactory PagesIndex.Factory) in class com.facebook.presto.operator.HashBuilderOperator	From	To
Change Parameter Type searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public createLookupSourceSupplier(session Session, addresses LongArrayList, channels List<List<Block>>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>) : LookupSourceSupplier in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory	From	To
Change Parameter Type searchExpression : Expression to searchExpressions : List<Expression> in method private assertGetSortExpression(expression Expression, expectedSymbol String, searchExpressions List<Expression>) : void in class com.facebook.presto.sql.planner.TestSortExpressionExtractor	From	To
Rename Variable	2
Rename Variable left : int to currentStartOffset : int in method public start(startingPosition int, probePosition int, allProbeChannelsPage Page) : int in class com.facebook.presto.operator.SortedPositionLinks	From	To
Rename Variable searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method private createLookupSourceFactory(node JoinNode, buildNode PlanNode, buildSymbols List<Symbol>, buildHashSymbol Optional<Symbol>, probeLayout Map<Symbol,Integer>, context LocalExecutionPlanContext) : LookupSourceFactory in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor	From	To
Change Return Type	1
Change Return Type Expression to List<Expression> in method public getSearchExpressions() : List<Expression> in class com.facebook.presto.sql.planner.SortExpressionContext	From	To
Parameterize Variable	1
Parameterize Variable right : int to links : int[] in method private findStartPositionForFunction(searchFunction JoinFilterFunction, links int[], startOffset int, probePosition int, allProbeChannelsPage Page) : int in class com.facebook.presto.operator.SortedPositionLinks	From	To
Rename Attribute	3
Rename Attribute searchExpression : Expression to searchExpressions : List<Expression> in class com.facebook.presto.sql.planner.SortExpressionContext	From	To
Rename Attribute searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in class com.facebook.presto.operator.HashBuilderOperator	From	To
Rename Attribute searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory	From	To
Change Variable Type	2
Change Variable Type searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method private createLookupSourceFactory(node JoinNode, buildNode PlanNode, buildSymbols List<Symbol>, buildHashSymbol Optional<Symbol>, probeLayout Map<Symbol,Integer>, context LocalExecutionPlanContext) : LookupSourceFactory in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor	From	To
Change Variable Type right : int to links : int[] in method private findStartPositionForFunction(searchFunction JoinFilterFunction, links int[], startOffset int, probePosition int, allProbeChannelsPage Page) : int in class com.facebook.presto.operator.SortedPositionLinks	From	To
Extract Method	2
Extract Method private applySearchFunction(searchFunction JoinFilterFunction, links int[], linkOffset int, probePosition int, allProbeChannelsPage Page) : boolean extracted from public start(startingPosition int, probePosition int, allProbeChannelsPage Page) : int in class com.facebook.presto.operator.SortedPositionLinks	From	To
Extract Method private findStartPositionForFunction(searchFunction JoinFilterFunction, links int[], startOffset int, probePosition int, allProbeChannelsPage Page) : int extracted from public start(startingPosition int, probePosition int, allProbeChannelsPage Page) : int in class com.facebook.presto.operator.SortedPositionLinks	From	To
Change Attribute Type	3
Change Attribute Type searchExpression : Expression to searchExpressions : List<Expression> in class com.facebook.presto.sql.planner.SortExpressionContext	From	To
Change Attribute Type searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in class com.facebook.presto.operator.HashBuilderOperator	From	To
Change Attribute Type searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory	From	To
Rename Parameter	12
Rename Parameter searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>) : LookupSourceSupplier in class com.facebook.presto.operator.PagesIndex	From	To
Rename Parameter rightPosition : int to probePosition : int in method private applySearchFunction(searchFunction JoinFilterFunction, buildPosition long, probePosition int, allProbeChannelsPage Page) : boolean in class com.facebook.presto.operator.SortedPositionLinks	From	To
Rename Parameter startingPosition : int to searchFunction : JoinFilterFunction in method private applySearchFunction(searchFunction JoinFilterFunction, links int[], linkOffset int, probePosition int, allProbeChannelsPage Page) : boolean in class com.facebook.presto.operator.SortedPositionLinks	From	To
Rename Parameter startingPosition : int to searchFunction : JoinFilterFunction in method private findStartPositionForFunction(searchFunction JoinFilterFunction, links int[], startOffset int, probePosition int, allProbeChannelsPage Page) : int in class com.facebook.presto.operator.SortedPositionLinks	From	To
Rename Parameter searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public HashBuilderOperatorFactory(operatorId int, planNodeId PlanNodeId, types List<Type>, outputChannels List<Integer>, layout Map<Symbol,Integer>, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, outer boolean, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>, expectedPositions int, partitionCount int, pagesIndexFactory PagesIndex.Factory) in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory	From	To
Rename Parameter leftPosition : long to buildPosition : long in method private applySearchFunction(searchFunction JoinFilterFunction, buildPosition long, probePosition int, allProbeChannelsPage Page) : boolean in class com.facebook.presto.operator.SortedPositionLinks	From	To
Rename Parameter searchFunction : JoinFilterFunction to searchFunctions : List<JoinFilterFunction> in method private SortedPositionLinks(positionLinks PositionLinks, sortedPositionLinks int[][], searchFunctions List<JoinFilterFunction>) in class com.facebook.presto.operator.SortedPositionLinks	From	To
Rename Parameter searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>, outputChannels Optional<List<Integer>>) : LookupSourceSupplier in class com.facebook.presto.operator.PagesIndex	From	To
Rename Parameter searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public HashBuilderOperator(operatorContext OperatorContext, lookupSourceFactory PartitionedLookupSourceFactory, partitionIndex int, outputChannels List<Integer>, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>, expectedPositions int, pagesIndexFactory PagesIndex.Factory) in class com.facebook.presto.operator.HashBuilderOperator	From	To
Rename Parameter searchFunctionFactory : Optional<JoinFilterFunctionFactory> to searchFunctionFactories : List<JoinFilterFunctionFactory> in method public createLookupSourceSupplier(session Session, addresses LongArrayList, channels List<List<Block>>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, sortChannel Optional<Integer>, searchFunctionFactories List<JoinFilterFunctionFactory>) : LookupSourceSupplier in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory	From	To
Rename Parameter rightPage : Page to allProbeChannelsPage : Page in method private applySearchFunction(searchFunction JoinFilterFunction, buildPosition long, probePosition int, allProbeChannelsPage Page) : boolean in class com.facebook.presto.operator.SortedPositionLinks	From	To
Rename Parameter searchExpression : Expression to searchExpressions : List<Expression> in method private assertGetSortExpression(expression Expression, expectedSymbol String, searchExpressions List<Expression>) : void in class com.facebook.presto.sql.planner.TestSortExpressionExtractor	From	To

2790951f161fc694b116d6b637dc657ae9262354

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: