2849fdb47a8e2a5b546b4978875bf15c3eddf4fc
Files Diff
- Added: 16
- Removed: 0
- Renamed: 0
- Modified: 43
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Updated | |
| From io.airlift:stats 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:event 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:log-manager 0.121 To 0.122-SNAPSHOT | |
| From org.testng:testng 6.9.6 To 6.8.21 | |
| From io.airlift:dbpool 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:concurrent 0.121 To 0.122-SNAPSHOT | |
| From org.testng:testng 6.8.21 To 6.9.6 | |
| From io.airlift:trace-token 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:units 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:http-client 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:http-server 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:log 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:json 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:discovery 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:configuration 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:jmx 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:jaxrs 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:testing 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:bootstrap 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:jmx-http 0.121 To 0.122-SNAPSHOT | |
| From io.airlift:node 0.121 To 0.122-SNAPSHOT |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public addSystemTablesMetadata(connectorId String, catalogName String, metadata ConnectorMetadata) : void renamed to public registerSystemTablesCatalog(connectorId String, catalogName String) : void in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Rename Method public addConnectorMetadata(connectorId String, catalogName String, connectorMetadata ConnectorMetadata) : void renamed to public registerConnectorCatalog(connectorId String, catalogName String) : void in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Rename Method public addInformationSchemaMetadata(connectorId String, catalogName String, metadata ConnectorMetadata) : void renamed to public registerInformationSchemaCatalog(connectorId String, catalogName String) : void in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type analyzer : Analyzer to session : Session in method private assertFails(session Session, error SemanticErrorCode, query String) : void in class com.facebook.presto.sql.analyzer.TestAnalyzer | From | To | |
| Change Parameter Type connector : Connector to connector : TransactionalConnector in method private addCatalogConnector(catalogName String, connectorId String, connector TransactionalConnector) : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Change Parameter Type analyzer : Analyzer to session : Session in method private assertMissingInformationSchema(session Session, query String) : void in class com.facebook.presto.sql.analyzer.TestAnalyzer | From | To | |
| Change Parameter Type connector : Connector to connector : TransactionalConnector in method private addConnectorInternal(type ConnectorType, catalogName String, connectorId String, connector TransactionalConnector) : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Rename Variable | 2 | ||
| Rename Variable metadata : ConnectorEntry to connectorEntry : ConnectorEntry in method public getViews(session Session, prefix QualifiedTablePrefix) : Map<QualifiedObjectName,ViewDefinition> in class com.facebook.presto.metadata.MetadataManager | From | To | |
| Rename Variable analyzer : Analyzer to session : Session in method public testInvalidShowTables() : void in class com.facebook.presto.sql.analyzer.TestAnalyzer | From | To | |
| Inline Method | 1 | ||
| Inline Method private createExecution(statement Statement, session Session, stateMachine QueryStateMachine) : DataDefinitionExecution<?> inlined to public createQueryExecution(queryId QueryId, query String, session Session, statement Statement) : DataDefinitionExecution<?> in class com.facebook.presto.execution.DataDefinitionExecution.DataDefinitionExecutionFactory | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type connector : Connector to connector : TransactionalConnector in method public stop() : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Change Variable Type entry : Map.Entry<String,Connector> to entry : Map.Entry<String,TransactionalConnector> in method public stop() : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Change Variable Type existingConnectorFactory : ConnectorFactory to existingConnectorFactory : TransactionalConnectorFactory in method public addConnectorFactory(connectorFactory TransactionalConnectorFactory) : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Change Variable Type analyzer : Analyzer to session : Session in method public testInvalidShowTables() : void in class com.facebook.presto.sql.analyzer.TestAnalyzer | From | To | |
| Change Variable Type connectorFactory : ConnectorFactory to connectorFactory : TransactionalConnectorFactory in method public createConnection(catalogName String, connectorName String, properties Map<String,String>) : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Change Variable Type connector : Connector to connector : TransactionalConnector in method public createConnection(catalogName String, connectorFactory TransactionalConnectorFactory, properties Map<String,String>) : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Extract Method | 4 | ||
| Extract Method private analyze(clientSession Session, query String) : void extracted from private assertFails(analyzer Analyzer, error SemanticErrorCode, query String) : void in class com.facebook.presto.sql.analyzer.TestAnalyzer | From | To | |
| Extract Method public addConnectorFactory(connectorFactory TransactionalConnectorFactory) : void extracted from public addConnectorFactory(connectorFactory ConnectorFactory) : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Extract Method private executeInternal(session Session, sql String) : MaterializedResult extracted from public execute(session Session, sql String) : MaterializedResult in class com.facebook.presto.testing.LocalQueryRunner | From | To | |
| Extract Method public createConnection(catalogName String, connectorFactory TransactionalConnectorFactory, properties Map<String,String>) : void extracted from public createConnection(catalogName String, connectorFactory ConnectorFactory, properties Map<String,String>) : void in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type connectors : ConcurrentMap<String,Connector> to connectors : ConcurrentMap<String,TransactionalConnector> in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Change Attribute Type connectorFactories : ConcurrentMap<String,ConnectorFactory> to connectorFactories : ConcurrentMap<String,TransactionalConnectorFactory> in class com.facebook.presto.connector.ConnectorManager | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public transitionToFinishing() : boolean extracted from public start() : void in class com.facebook.presto.execution.DataDefinitionExecution & moved to class com.facebook.presto.execution.QueryStateMachine | From | To | |
| Extract And Move Method public failed(queryId QueryId, query String, session Session, self URI, transactionManager TransactionManager, executor Executor, throwable Throwable) : QueryStateMachine extracted from public FailedQueryExecution(queryId QueryId, query String, session Session, self URI, executor Executor, cause Throwable) in class com.facebook.presto.execution.FailedQueryExecution & moved to class com.facebook.presto.execution.QueryStateMachine | From | To | |
| Extract And Move Method public transitionToFinishing() : boolean extracted from public SqlQueryScheduler(queryStateMachine QueryStateMachine, locationFactory LocationFactory, plan StageExecutionPlan, nodeScheduler NodeScheduler, remoteTaskFactory RemoteTaskFactory, session Session, splitBatchSize int, executor ExecutorService, rootOutputBuffers OutputBuffers, nodeTaskMap NodeTaskMap, executionPolicy ExecutionPolicy) in class com.facebook.presto.execution.scheduler.SqlQueryScheduler & moved to class com.facebook.presto.execution.QueryStateMachine | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter analyzer : Analyzer to session : Session in method private assertFails(session Session, error SemanticErrorCode, query String) : void in class com.facebook.presto.sql.analyzer.TestAnalyzer | From | To | |
| Rename Parameter analyzer : Analyzer to session : Session in method private assertMissingInformationSchema(session Session, query String) : void in class com.facebook.presto.sql.analyzer.TestAnalyzer | From | To |