2afa5749b6955c4b5efa13b4f5296df893b05f82
Files Diff
- Added: 6
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public getColumns() : List<JmxColumnHandle> renamed to public getColumnHandles() : List<JmxColumnHandle> in class com.facebook.presto.connector.jmx.JmxTableHandle | From | To | |
| Rename Variable | 2 | ||
| Rename Variable columns : ImmutableList.Builder<JmxColumnHandle> to builder : ImmutableList.Builder<JmxColumnHandle> in method private getJmxHistoryTableHandle(tableName SchemaTableName) : JmxTableHandle in class com.facebook.presto.connector.jmx.JmxMetadata | From | To | |
| Rename Variable jmxColumnHandle : JmxColumnHandle to jmxColumn : JmxColumnHandle in method public getLiveRow(tableHandle JmxTableHandle, columns List<? extends ColumnHandle>, entryTimestamp long) : List<Object> in class com.facebook.presto.connector.jmx.JmxRecordSetProvider | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Map<String,Object> to ImmutableMap<String,Optional<Object>> in method private getAttributes(uniqueColumnNames Set<String>, tableHandle JmxTableHandle) : ImmutableMap<String,Optional<Object>> in class com.facebook.presto.connector.jmx.JmxRecordSetProvider | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute public NODE_COLUMN_NAME : String in class com.facebook.presto.connector.jmx.JmxMetadata | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute columns : List<JmxColumnHandle> to columnHandles : List<JmxColumnHandle> in class com.facebook.presto.connector.jmx.JmxTableHandle | From | To | |
| Rename Attribute SCHEMA_NAME : String to JMX_SCHEMA_NAME : String in class com.facebook.presto.connector.jmx.JmxMetadata | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type attributes : Map<String,Object> to attributes : ImmutableMap<String,Optional<Object>> in method public getLiveRow(tableHandle JmxTableHandle, columns List<? extends ColumnHandle>, entryTimestamp long) : List<Object> in class com.facebook.presto.connector.jmx.JmxRecordSetProvider | From | To | |
| Extract Method | 7 | ||
| Extract Method private calculateSelectedColumns(columnHandles List<JmxColumnHandle>, selectedColumnNames Set<String>) : List<Integer> extracted from public getRecordSet(transaction ConnectorTransactionHandle, session ConnectorSession, split ConnectorSplit, columns List<? extends ColumnHandle>) : RecordSet in class com.facebook.presto.connector.jmx.JmxRecordSetProvider | From | To | |
| Extract Method private getJmxTableHandle(tableName SchemaTableName) : JmxTableHandle extracted from public getTableHandle(session ConnectorSession, tableName SchemaTableName) : JmxTableHandle in class com.facebook.presto.connector.jmx.JmxMetadata | From | To | |
| Extract Method private getLiveRow(tableHandle JmxTableHandle, columns List<? extends ColumnHandle>) : List<Object> extracted from public getRecordSet(transaction ConnectorTransactionHandle, session ConnectorSession, split ConnectorSplit, columns List<? extends ColumnHandle>) : RecordSet in class com.facebook.presto.connector.jmx.JmxRecordSetProvider | From | To | |
| Extract Method private getJmxHistoryTableHandle(tableName SchemaTableName) : JmxTableHandle extracted from public getTableHandle(session ConnectorSession, tableName SchemaTableName) : JmxTableHandle in class com.facebook.presto.connector.jmx.JmxMetadata | From | To | |
| Extract Method private getRecordSet(schemaTableName SchemaTableName) : RecordSet extracted from public testRecordSetProvider() : void in class com.facebook.presto.connector.jmx.TestJmxSplitManager | From | To | |
| Extract Method private listJmxTables() : List<SchemaTableName> extracted from public listTables(session ConnectorSession, schemaNameOrNull String) : List<SchemaTableName> in class com.facebook.presto.connector.jmx.JmxMetadata | From | To | |
| Extract Method public getTableHandle(tableName SchemaTableName) : JmxTableHandle extracted from public getTableHandle(session ConnectorSession, tableName SchemaTableName) : JmxTableHandle in class com.facebook.presto.connector.jmx.JmxMetadata | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter columns : List<JmxColumnHandle> to columnHandles : List<JmxColumnHandle> in method public JmxTableHandle(connectorId String, objectName String, columnHandles List<JmxColumnHandle>) in class com.facebook.presto.connector.jmx.JmxTableHandle | From | To | |
| Rename Parameter properties : Map<String,String> to config : Map<String,String> in method public create(connectorId String, config Map<String,String>) : Connector in class com.facebook.presto.connector.jmx.JmxConnectorFactory | From | To |