presto 2cc00e4a6162f1ef8cd3f5c032f98dc85c122fa0

2cc00e4a6162f1ef8cd3f5c032f98dc85c122fa0

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method public testGroupedJoin() : void renamed to public testGroupedExecution() : void in class com.facebook.presto.hive.TestHiveIntegrationSmokeTest	From	To
Move And Inline Method	1
Move And Inline Method public getNestedLoopJoinPagesBridge() : NestedLoopJoinPagesBridge moved from class com.facebook.presto.operator.NestedLoopBuildOperator.NestedLoopBuildOperatorFactory to class com.facebook.presto.operator.TestNestedLoopJoinOperator & inlined to private buildPageSource(taskContext TaskContext, buildPages RowPagesBuilder) : JoinBridgeDataManager<NestedLoopJoinPagesBridge>	From	To
Rename Variable	10
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testProbeMultiplePages() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testCrossJoinWithNullOnBothSides() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testBuildMultiplePages() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testEmptyProbePage() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testCrossJoinWithNullProbe() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testProbeAndBuildMultiplePages() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testEmptyBuildPage() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testCrossJoinWithNullBuild() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testNestedLoopJoin() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Rename Variable nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesSupplierManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method private createNestedLoopJoin(node JoinNode, context LocalExecutionPlanContext) : PhysicalOperation in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor	From	To
Change Return Type	3
Change Return Type NestedLoopJoinPagesBridge to JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method private buildPageSource(taskContext TaskContext, buildPages RowPagesBuilder) : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Return Type void to ListenableFuture<?> in method public setPages(nestedLoopJoinPages NestedLoopJoinPages) : ListenableFuture<?> in class com.facebook.presto.operator.NestedLoopJoinPagesSupplier	From	To
Change Return Type void to ListenableFuture<?> in method public setPages(nestedLoopJoinPages NestedLoopJoinPages) : ListenableFuture<?> in class com.facebook.presto.operator.NestedLoopJoinPagesBridge	From	To
Rename Attribute	2
Rename Attribute buildPagesSupplier : NestedLoopJoinPagesBridge to afterClose : Runnable in class com.facebook.presto.operator.NestedLoopJoinOperator	From	To
Rename Attribute transferredBytesMemoryContext : LocalMemoryContext to estimatedSize : DataSize in class com.facebook.presto.operator.NestedLoopJoinPages	From	To
Extract Variable	2
Extract Variable valuesOperator : Operator in method private buildPageSource(taskContext TaskContext, buildPages RowPagesBuilder) : JoinBridgeDataManager<NestedLoopJoinPagesBridge> from class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Extract Variable nestedLoopBuildOperator : Operator in method private buildPageSource(taskContext TaskContext, buildPages RowPagesBuilder) : JoinBridgeDataManager<NestedLoopJoinPagesBridge> from class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Variable Type	10
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testProbeAndBuildMultiplePages() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testEmptyBuildPage() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testNestedLoopJoin() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testCrossJoinWithNullBuild() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesSupplierManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method private createNestedLoopJoin(node JoinNode, context LocalExecutionPlanContext) : PhysicalOperation in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor	From	To
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testProbeMultiplePages() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testCrossJoinWithNullOnBothSides() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testBuildMultiplePages() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testEmptyProbePage() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Variable Type nestedLoopJoinPagesBridge : NestedLoopJoinPagesBridge to nestedLoopJoinPagesBridgeManager : JoinBridgeDataManager<NestedLoopJoinPagesBridge> in method public testCrossJoinWithNullProbe() : void in class com.facebook.presto.operator.TestNestedLoopJoinOperator	From	To
Change Attribute Type	2
Change Attribute Type buildPagesSupplier : NestedLoopJoinPagesBridge to afterClose : Runnable in class com.facebook.presto.operator.NestedLoopJoinOperator	From	To
Change Attribute Type transferredBytesMemoryContext : LocalMemoryContext to estimatedSize : DataSize in class com.facebook.presto.operator.NestedLoopJoinPages	From	To

2cc00e4a6162f1ef8cd3f5c032f98dc85c122fa0

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: