3030ab66d4c9610ec85efdc762180c663e953cde
Files Diff
- Added: 21
- Removed: 6
- Renamed: 0
- Modified: 19
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 3 | ||
| Move And Rename Method private validateSignature(signatureOld Optional<Signature>, signatureNew Signature) : void from class com.facebook.presto.operator.scalar.annotations.ScalarFromAnnotationsParser to public validateSignaturesCompatibility(signatureOld Optional<Signature>, signatureNew Signature) : void from class com.facebook.presto.operator.annotations.FunctionsParserHelper | From | To | |
| Move And Rename Method private parseDependency(annotation Annotation) : ImplementationDependency from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser to public createDependency(annotation Annotation, literalParameters Set<String>) : ImplementationDependency from class com.facebook.presto.operator.annotations.ImplementationDependency.Factory | From | To | |
| Move And Rename Method private isMetaParameter(annotation Annotation) : boolean from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser to public isImplementationDependencyAnnotation(annotation Annotation) : boolean from class com.facebook.presto.operator.annotations.ImplementationDependency | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type implementations : ScalarImplementations to implementations : ParametricImplementationsGroup<ScalarImplementation> in method public ParametricScalar(signature Signature, details ScalarHeader, implementations ParametricImplementationsGroup<ScalarImplementation>) in class com.facebook.presto.operator.scalar.ParametricScalar | From | To | |
| Change Parameter Type genericImplementations : List<ScalarImplementation> to genericImplementations : List<T> in method public ParametricImplementationsGroup(exactImplementations Map<Signature,T>, specializedImplementations List<T>, genericImplementations List<T>, signature Signature) in class com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Change Parameter Type specializedImplementations : List<ScalarImplementation> to specializedImplementations : List<T> in method public ParametricImplementationsGroup(exactImplementations Map<Signature,T>, specializedImplementations List<T>, genericImplementations List<T>, signature Signature) in class com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Change Parameter Type exactImplementations : Map<Signature,ScalarImplementation> to exactImplementations : Map<Signature,T> in method public ParametricImplementationsGroup(exactImplementations Map<Signature,T>, specializedImplementations List<T>, genericImplementations List<T>, signature Signature) in class com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Move Method | 6 | ||
| Move Method private isPrestoAnnotation(annotation Annotation) : boolean from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser to public isPrestoAnnotation(annotation Annotation) : boolean from class com.facebook.presto.operator.annotations.FunctionsParserHelper | From | To | |
| Move Method private findConstructors(clazz Class<?>) : Map<Set<TypeParameter>,Constructor<?>> from class com.facebook.presto.operator.scalar.annotations.ScalarFromAnnotationsParser to public findConstructors(clazz Class<?>) : Map<Set<TypeParameter>,Constructor<?>> from class com.facebook.presto.operator.annotations.FunctionsParserHelper | From | To | |
| Move Method private getDeclaredSpecializedTypeParameters(method Method) : Map<String,Class<?>> from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser to public getDeclaredSpecializedTypeParameters(method Method, typeParameters Set<TypeParameter>) : Map<String,Class<?>> from class com.facebook.presto.operator.annotations.FunctionsParserHelper | From | To | |
| Move Method private containsLegacyNullable(annotations Annotation[]) : boolean from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser to public containsLegacyNullable(annotations Annotation[]) : boolean from class com.facebook.presto.operator.annotations.FunctionsParserHelper | From | To | |
| Move Method private findPublicMethodsWithAnnotation(clazz Class<?>, annotationClasses Class<? extends Annotation>...) : Set<Method> from class com.facebook.presto.operator.scalar.annotations.ScalarFromAnnotationsParser to public findPublicMethodsWithAnnotation(clazz Class<?>, annotationClasses Class<? extends Annotation>...) : Set<Method> from class com.facebook.presto.operator.annotations.FunctionsParserHelper | From | To | |
| Move Method private createTypeVariableConstraints(typeParameters Iterable<TypeParameter>, dependencies List<ImplementationDependency>) : List<TypeVariableConstraint> from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser to public createTypeVariableConstraints(typeParameters Iterable<TypeParameter>, dependencies List<ImplementationDependency>) : List<TypeVariableConstraint> from class com.facebook.presto.operator.annotations.FunctionsParserHelper | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private COMPARABLE_TYPE_OPERATORS : Set<OperatorType> from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser to private COMPARABLE_TYPE_OPERATORS : Set<OperatorType> from class com.facebook.presto.operator.annotations.FunctionsParserHelper | From | To | |
| Move Attribute private ORDERABLE_TYPE_OPERATORS : Set<OperatorType> from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser to private ORDERABLE_TYPE_OPERATORS : Set<OperatorType> from class com.facebook.presto.operator.annotations.FunctionsParserHelper | From | To | |
| Extract Class | 2 | ||
| Extract Class com.facebook.presto.operator.annotations.FunctionsParserHelper from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser | From | To | |
| Extract Class com.facebook.presto.operator.annotations.FunctionsParserHelper from class com.facebook.presto.operator.scalar.annotations.ScalarFromAnnotationsParser | From | To | |
| Rename Class | 2 | ||
| Rename Class com.facebook.presto.operator.aggregation.MaxBy renamed to com.facebook.presto.operator.aggregation.MaxByAggregationFunction | From | To | |
| Rename Class com.facebook.presto.operator.aggregation.MinBy renamed to com.facebook.presto.operator.aggregation.MinByAggregationFunction | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class com.facebook.presto.operator.scalar.annotations.ScalarImplementations moved and renamed to com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Move Class | 5 | ||
| Move Class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.OperatorImplementationDependency moved to com.facebook.presto.operator.annotations.OperatorImplementationDependency | From | To | |
| Move Class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.FunctionImplementationDependency moved to com.facebook.presto.operator.annotations.FunctionImplementationDependency | From | To | |
| Move Class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.ScalarImplementationDependency moved to com.facebook.presto.operator.annotations.ScalarImplementationDependency | From | To | |
| Move Class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.TypeImplementationDependency moved to com.facebook.presto.operator.annotations.TypeImplementationDependency | From | To | |
| Move Class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.LiteralImplementationDependency moved to com.facebook.presto.operator.annotations.LiteralImplementationDependency | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type genericImplementations : ImmutableList.Builder<ScalarImplementation> to implementationsBuilder : ParametricImplementationsGroup.Builder<ScalarImplementation> in method private parseParametricScalar(scalar ScalarHeaderAndMethods, constructors Map<Set<TypeParameter>,Constructor<?>>) : SqlScalarFunction in class com.facebook.presto.operator.scalar.annotations.ScalarFromAnnotationsParser | From | To | |
| Change Variable Type annotation : Annotation to parameter : Parameter in method private parseArguments(method Method) : void in class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser | From | To | |
| Inline Variable | 1 | ||
| Inline Variable scalarFunctionImplementation : ScalarFunctionImplementation in method public resolve(boundVariables BoundVariables, typeManager TypeManager, functionRegistry FunctionRegistry) : MethodHandle from class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.ScalarImplementationDependency | From | To | |
| Rename Method | 1 | ||
| Rename Method public createByAnnotations(aggregationDefinition Class<?>) : List<SqlAggregationFunction> renamed to public createFunctionsByAnnotations(aggregationDefinition Class<?>) : List<SqlAggregationFunction> in class com.facebook.presto.metadata.SqlAggregationFunction | From | To | |
| Inline Method | 2 | ||
| Inline Method private checkTypeParameters(typeSignature TypeSignature, method Method, typeParameterNames Set<String>) : void inlined to private parseArguments(method Method) : void in class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser | From | To | |
| Rename Variable | 2 | ||
| Rename Variable genericImplementations : ImmutableList.Builder<ScalarImplementation> to implementationsBuilder : ParametricImplementationsGroup.Builder<ScalarImplementation> in method private parseParametricScalar(scalar ScalarHeaderAndMethods, constructors Map<Set<TypeParameter>,Constructor<?>>) : SqlScalarFunction in class com.facebook.presto.operator.scalar.annotations.ScalarFromAnnotationsParser | From | To | |
| Rename Variable annotation : Annotation to parameter : Parameter in method private parseArguments(method Method) : void in class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser | From | To | |
| Change Return Type | 3 | ||
| Change Return Type List<ScalarImplementation> to List<T> in method public getSpecializedImplementations() : List<T> in class com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Change Return Type List<ScalarImplementation> to List<T> in method public getGenericImplementations() : List<T> in class com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Change Return Type Map<Signature,ScalarImplementation> to Map<Signature,T> in method public getExactImplementations() : Map<Signature,T> in class com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Extract Interface | 1 | ||
| Extract Interface com.facebook.presto.operator.ParametricImplementation from classes [com.facebook.presto.operator.scalar.annotations.ScalarImplementation] | From | To | |
| Change Attribute Type | 7 | ||
| Change Attribute Type implementations : ScalarImplementations to implementations : ParametricImplementationsGroup<ScalarImplementation> in class com.facebook.presto.operator.scalar.ParametricScalar | From | To | |
| Change Attribute Type genericImplementations : List<ScalarImplementation> to genericImplementations : List<T> in class com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Change Attribute Type specializedImplementations : List<ScalarImplementation> to specializedImplementations : List<T> in class com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Change Attribute Type MIN_BY : MinBy to MIN_BY : MinByAggregationFunction in class com.facebook.presto.operator.aggregation.MinByAggregationFunction | From | To | |
| Change Attribute Type typeParameters : LinkedHashSet<TypeParameter> to typeParameters : Set<TypeParameter> in class com.facebook.presto.operator.scalar.annotations.ScalarImplementation.Parser | From | To | |
| Change Attribute Type MAX_BY : MaxBy to MAX_BY : MaxByAggregationFunction in class com.facebook.presto.operator.aggregation.MaxByAggregationFunction | From | To | |
| Change Attribute Type exactImplementations : Map<Signature,ScalarImplementation> to exactImplementations : Map<Signature,T> in class com.facebook.presto.operator.ParametricImplementationsGroup | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method package inputChannelParameterType(isNullable boolean, isBlock boolean, methodName String) : ParameterType extracted from public fromSqlType(sqlType Type, isBlock boolean, isNullable boolean, methodName String) : ParameterMetadata in class com.facebook.presto.operator.aggregation.AggregationMetadata.ParameterMetadata & moved to class com.facebook.presto.operator.aggregation.AggregationMetadata.ParameterMetadata.ParameterType | From | To |