321cd796968d9b1ba0877436f400bc13fe8a5ced
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 21
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private isRowNumberSignature(signature Signature) : boolean renamed to private isRowNumberMetadata(functionMetadata FunctionMetadata) : boolean in class com.facebook.presto.sql.planner.optimizations.WindowFilterPushDown.Rewriter | From | To | |
| Rename Method private checkSignature(symbol Symbol, signature Signature) : void renamed to private checkTypeSignature(symbol Symbol, actualTypeSignature TypeSignature) : void in class com.facebook.presto.sql.planner.sanity.TypeValidator.Visitor | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type signature : Signature to functionMetadata : FunctionMetadata in method private isRowNumberMetadata(functionMetadata FunctionMetadata) : boolean in class com.facebook.presto.sql.planner.optimizations.WindowFilterPushDown.Rewriter | From | To | |
| Change Parameter Type elementCastSignature : Signature to elementCastFunctionMetadata : FunctionMetadata in method private generateArrayCast(typeManager TypeManager, elementCastFunctionMetadata FunctionMetadata, elementCast ScalarFunctionImplementation) : Class<?> in class com.facebook.presto.operator.scalar.ArrayToArrayCast | From | To | |
| Change Parameter Type signature : Signature to actualTypeSignature : TypeSignature in method private checkTypeSignature(symbol Symbol, actualTypeSignature TypeSignature) : void in class com.facebook.presto.sql.planner.sanity.TypeValidator.Visitor | From | To | |
| Rename Variable | 4 | ||
| Rename Variable signature : Signature to functionHandle : FunctionHandle in method private checkWindowFunctions(functions Map<Symbol,WindowNode.Function>) : void in class com.facebook.presto.sql.planner.sanity.TypeValidator.Visitor | From | To | |
| Rename Variable signature : Signature to functionMetadata : FunctionMetadata in method protected visitFunctionCall(functionCall FunctionCall, analysis Analysis) : Void in class com.facebook.presto.sql.analyzer.WindowFunctionValidator | From | To | |
| Rename Variable functionSignature : Signature to functionMetadata : FunctionMetadata in method protected visitFunctionCall(node FunctionCall, context StackableAstVisitorContext<Context>) : Type in class com.facebook.presto.sql.analyzer.ExpressionAnalyzer.Visitor | From | To | |
| Rename Variable operatorSignature : Signature to operatorMetadata : FunctionMetadata in method private getOperator(context StackableAstVisitorContext<Context>, node Expression, operatorType OperatorType, arguments Expression...) : Type in class com.facebook.presto.sql.analyzer.ExpressionAnalyzer.Visitor | From | To | |
| Extract Variable | 4 | ||
| Extract Variable functionManager : FunctionManager in method public visitWindow(node WindowNode, context LocalExecutionPlanContext) : PhysicalOperation from class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Extract Variable functionManager : FunctionManager in method private buildAccumulatorFactory(source PhysicalOperation, aggregation Aggregation) : AccumulatorFactory from class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Extract Variable functionManager : FunctionManager in method public generateExpression(generatorContext BytecodeGeneratorContext, returnType Type, arguments List<RowExpression>, outputBlockVariable Optional<Variable>) : BytecodeNode from class com.facebook.presto.sql.gen.NullIfCodeGenerator | From | To | |
| Extract Variable functionManager : FunctionManager in method private createAggregation(functionName QualifiedName, input SymbolReference, inputType Type, outputType Type) : ColumnStatisticsAggregation from class com.facebook.presto.sql.planner.StatisticsAggregationPlanner | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type signature : Signature to functionHandle : FunctionHandle in method private checkWindowFunctions(functions Map<Symbol,WindowNode.Function>) : void in class com.facebook.presto.sql.planner.sanity.TypeValidator.Visitor | From | To | |
| Change Variable Type signature : Signature to functionMetadata : FunctionMetadata in method protected visitFunctionCall(functionCall FunctionCall, analysis Analysis) : Void in class com.facebook.presto.sql.analyzer.WindowFunctionValidator | From | To | |
| Change Variable Type functionSignature : Signature to functionMetadata : FunctionMetadata in method protected visitFunctionCall(node FunctionCall, context StackableAstVisitorContext<Context>) : Type in class com.facebook.presto.sql.analyzer.ExpressionAnalyzer.Visitor | From | To | |
| Change Variable Type operatorSignature : Signature to operatorMetadata : FunctionMetadata in method private getOperator(context StackableAstVisitorContext<Context>, node Expression, operatorType OperatorType, arguments Expression...) : Type in class com.facebook.presto.sql.analyzer.ExpressionAnalyzer.Visitor | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter signature : Signature to actualTypeSignature : TypeSignature in method private checkTypeSignature(symbol Symbol, actualTypeSignature TypeSignature) : void in class com.facebook.presto.sql.planner.sanity.TypeValidator.Visitor | From | To | |
| Rename Parameter elementCastSignature : Signature to elementCastFunctionMetadata : FunctionMetadata in method private generateArrayCast(typeManager TypeManager, elementCastFunctionMetadata FunctionMetadata, elementCast ScalarFunctionImplementation) : Class<?> in class com.facebook.presto.operator.scalar.ArrayToArrayCast | From | To | |
| Rename Parameter signature : Signature to functionMetadata : FunctionMetadata in method private isRowNumberMetadata(functionMetadata FunctionMetadata) : boolean in class com.facebook.presto.sql.planner.optimizations.WindowFilterPushDown.Rewriter | From | To |