364f50274d4b4b83d40930c0d2c4d0e57fb34589
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 20
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public getPartitionHashBucket(partitionCount int, position int, page Page) : int renamed to public getPartitionBucket(partitionCount int, position int, page Page) : int in class com.facebook.presto.operator.HashGenerator | From | To | |
| Rename Method public setHashPartitionedOutput(partitionKeys List<Symbol>, hash Optional<Symbol>) : FragmentProperties renamed to public setPartitionedOutput(partitionKeys Optional<List<Symbol>>, hash Optional<Symbol>) : FragmentProperties in class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties | From | To | |
| Pull Up Method | 3 | ||
| Pull Up Method public getPartitionCount() : int from class com.facebook.presto.HashPagePartitionFunction to public getPartitionCount() : int from class com.facebook.presto.PartitionedPagePartitionFunction | From | To | |
| Pull Up Method public createHashGenerator(hashChannel Optional<Integer>, partitioningChannels List<Integer>, types List<Type>) : HashGenerator from class com.facebook.presto.operator.HashGenerator to public createHashPartitionGenerator(hashChannel Optional<Integer>, partitioningChannels List<Integer>, types List<Type>) : PartitionGenerator from class com.facebook.presto.operator.PartitionGenerator | From | To | |
| Pull Up Method public getPartition() : int from class com.facebook.presto.HashPagePartitionFunction to public getPartition() : int from class com.facebook.presto.PartitionedPagePartitionFunction | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type partitionKeys : List<Symbol> to partitionKeys : Optional<List<Symbol>> in method public partitionedExchange(id PlanNodeId, child PlanNode, partitionKeys Optional<List<Symbol>>, hashSymbol Optional<Symbol>) : ExchangeNode in class com.facebook.presto.sql.planner.plan.ExchangeNode | From | To | |
| Change Parameter Type partitionKeys : List<Symbol> to partitionKeys : Optional<List<Symbol>> in method public setPartitionedOutput(partitionKeys Optional<List<Symbol>>, hash Optional<Symbol>) : FragmentProperties in class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties | From | To | |
| Change Parameter Type partitionBy : List<Symbol> to partitionBy : Optional<List<Symbol>> in method public PlanFragment(id PlanFragmentId, root PlanNode, symbols Map<Symbol,Type>, outputLayout List<Symbol>, distribution PlanDistribution, partitionedSource PlanNodeId, outputPartitioning OutputPartitioning, partitionBy Optional<List<Symbol>>, hash Optional<Symbol>) in class com.facebook.presto.sql.planner.PlanFragment | From | To | |
| Change Parameter Type partitionKeys : List<Symbol> to partitionKeys : Optional<List<Symbol>> in method public ExchangeNode(id PlanNodeId, type Type, partitionKeys Optional<List<Symbol>>, hashSymbol Optional<Symbol>, sources List<PlanNode>, outputs List<Symbol>, inputs List<List<Symbol>>) in class com.facebook.presto.sql.planner.plan.ExchangeNode | From | To | |
| Rename Variable | 1 | ||
| Rename Variable hashFunctions : List<HashPagePartitionFunction> to partitionFunctions : Collection<PagePartitionFunction> in method public PartitionFunction(sharedBuffer SharedBuffer, sourceTypes List<Type>, outputBuffers OutputBuffers) in class com.facebook.presto.operator.PartitionedOutputOperator.PartitionFunction | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute private partitionCount : int from class com.facebook.presto.HashPagePartitionFunction to protected partitionCount : int from class com.facebook.presto.PartitionedPagePartitionFunction | From | To | |
| Pull Up Attribute private partition : int from class com.facebook.presto.HashPagePartitionFunction to protected partition : int from class com.facebook.presto.PartitionedPagePartitionFunction | From | To | |
| Change Return Type | 5 | ||
| Change Return Type List<Symbol> to Optional<List<Symbol>> in method public getPartitionKeys() : Optional<List<Symbol>> in class com.facebook.presto.sql.planner.plan.ExchangeNode | From | To | |
| Change Return Type List<Symbol> to Optional<List<Symbol>> in method public getPartitionBy() : Optional<List<Symbol>> in class com.facebook.presto.sql.planner.PlanFragment | From | To | |
| Change Return Type List<Integer> to Optional<List<Integer>> in method private getPartitioningChannels(fragment PlanFragment) : Optional<List<Integer>> in class com.facebook.presto.execution.SqlStageExecution | From | To | |
| Change Return Type HashGenerator to PartitionGenerator in method public createHashPartitionGenerator(hashChannel Optional<Integer>, partitioningChannels List<Integer>, types List<Type>) : PartitionGenerator in class com.facebook.presto.operator.PartitionGenerator | From | To | |
| Change Return Type List<Symbol> to Optional<List<Symbol>> in method public getPartitionBy() : Optional<List<Symbol>> in class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.facebook.presto.PartitionedPagePartitionFunction from classes [com.facebook.presto.HashPagePartitionFunction] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute hashGenerator : HashGenerator to partitionGenerator : PartitionGenerator in class com.facebook.presto.operator.PartitionedOutputOperator.PartitionFunction | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type partitionFunction : HashPagePartitionFunction to partitionFunction : PagePartitionFunction in method public PartitionFunction(sharedBuffer SharedBuffer, sourceTypes List<Type>, outputBuffers OutputBuffers) in class com.facebook.presto.operator.PartitionedOutputOperator.PartitionFunction | From | To | |
| Change Variable Type hashFunctions : List<HashPagePartitionFunction> to partitionFunctions : Collection<PagePartitionFunction> in method public PartitionFunction(sharedBuffer SharedBuffer, sourceTypes List<Type>, outputBuffers OutputBuffers) in class com.facebook.presto.operator.PartitionedOutputOperator.PartitionFunction | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type partitionBy : List<Symbol> to partitionBy : Optional<List<Symbol>> in class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties | From | To | |
| Change Attribute Type hashGenerator : HashGenerator to partitionGenerator : PartitionGenerator in class com.facebook.presto.operator.PartitionedOutputOperator.PartitionFunction | From | To | |
| Change Attribute Type partitionKeys : List<Symbol> to partitionKeys : Optional<List<Symbol>> in class com.facebook.presto.sql.planner.plan.ExchangeNode | From | To | |
| Change Attribute Type partitionBy : List<Symbol> to partitionBy : Optional<List<Symbol>> in class com.facebook.presto.sql.planner.PlanFragment | From | To |