presto 3adfcc9b11f2fbbf47d0bcec75fbe35c0297e2e5

3adfcc9b11f2fbbf47d0bcec75fbe35c0297e2e5

Files Diff

Added: 5
Removed: 0
Renamed: 0
Modified: 66

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Extract Subclass	4
Extract Subclass com.facebook.presto.memory.DefaultQueryContext from class com.facebook.presto.memory.QueryContext	From	To
Extract Subclass com.facebook.presto.memory.LegacyQueryContext from class com.facebook.presto.memory.QueryContext	From	To
Extract Subclass com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext from class com.facebook.presto.memory.context.AggregatedMemoryContext	From	To
Extract Subclass com.facebook.presto.memory.context.AbstractAggregatedMemoryContext from class com.facebook.presto.memory.context.AggregatedMemoryContext	From	To
Change Parameter Type	2
Change Parameter Type queryContext : QueryContext to queryContext : DefaultQueryContext in method public createTaskContext(queryContext DefaultQueryContext, executor Executor, session Session) : TaskContext in class com.facebook.presto.testing.TestingTaskContext	From	To
Change Parameter Type queryContext : QueryContext to queryContext : DefaultQueryContext in method private createTaskContext(queryContext DefaultQueryContext, session Session, taskStateMachine TaskStateMachine) : TaskContext in class com.facebook.presto.testing.TestingTaskContext	From	To
Push Down Attribute	16
Push Down Attribute private systemMemoryPool : MemoryPool from class com.facebook.presto.memory.QueryContext to private systemMemoryPool : MemoryPool from class com.facebook.presto.memory.LegacyQueryContext	From	To
Push Down Attribute private maxSpill : long from class com.facebook.presto.memory.QueryContext to private maxSpill : long from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private queryId : QueryId from class com.facebook.presto.memory.QueryContext to private queryId : QueryId from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private closed : boolean from class com.facebook.presto.memory.context.AggregatedMemoryContext to private closed : boolean from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext	From	To
Push Down Attribute private spillSpaceTracker : SpillSpaceTracker from class com.facebook.presto.memory.QueryContext to private spillSpaceTracker : SpillSpaceTracker from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private GUARANTEED_MEMORY : long from class com.facebook.presto.memory.QueryContext to private GUARANTEED_MEMORY : long from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private notificationExecutor : Executor from class com.facebook.presto.memory.QueryContext to private notificationExecutor : Executor from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private gcMonitor : GcMonitor from class com.facebook.presto.memory.QueryContext to private gcMonitor : GcMonitor from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private usedBytes : long from class com.facebook.presto.memory.context.AggregatedMemoryContext to private usedBytes : long from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext	From	To
Push Down Attribute private yieldExecutor : ScheduledExecutorService from class com.facebook.presto.memory.QueryContext to private yieldExecutor : ScheduledExecutorService from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private queryMemoryContext : MemoryTrackingContext from class com.facebook.presto.memory.QueryContext to private queryMemoryContext : MemoryTrackingContext from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private maxMemory : long from class com.facebook.presto.memory.QueryContext to private maxMemory : long from class com.facebook.presto.memory.LegacyQueryContext	From	To
Push Down Attribute private spillUsed : long from class com.facebook.presto.memory.QueryContext to private spillUsed : long from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private taskContexts : Map<TaskId,TaskContext> from class com.facebook.presto.memory.QueryContext to private taskContexts : Map<TaskId,TaskContext> from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute private memoryPool : MemoryPool from class com.facebook.presto.memory.QueryContext to private memoryPool : MemoryPool from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Attribute package NOT_BLOCKED : ListenableFuture<?> from class com.facebook.presto.memory.context.AggregatedMemoryContext to package NOT_BLOCKED : ListenableFuture<?> from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext	From	To
Rename Class	1
Rename Class com.facebook.presto.operator.OperatorContext.DecoratedLocalMemoryContext renamed to com.facebook.presto.operator.OperatorContext.InternalLocalMemoryContext	From	To
Move Class	1
Move Class com.facebook.presto.memory.QueryContext.QueryMemoryReservationHandler moved to com.facebook.presto.memory.DefaultQueryContext.QueryMemoryReservationHandler	From	To
Change Variable Type	2
Change Variable Type parent : AggregatedMemoryContext to parent : AbstractAggregatedMemoryContext in method public transferMemory(to LocalMemoryContext) : void in class com.facebook.presto.memory.context.SimpleLocalMemoryContext	From	To
Change Variable Type parent : AggregatedMemoryContext to parent : AbstractAggregatedMemoryContext in method private checkMemoryContextState(target SimpleLocalMemoryContext) : void in class com.facebook.presto.memory.context.SimpleLocalMemoryContext	From	To
Extract Variable	1
Extract Variable taskUserMemory : long in method public getStageInfo(taskInfosSupplier Supplier<Iterable<TaskInfo>>, subStageInfosSupplier Supplier<Iterable<StageInfo>>) : StageInfo from class com.facebook.presto.execution.StageStateMachine	From	To
Extract Method	4
Extract Method private getQueryMemoryReservation(query QueryExecution) : long extracted from public process(queries Iterable<QueryExecution>) : void in class com.facebook.presto.memory.ClusterMemoryManager	From	To
Extract Method private configureLegacyMemoryPools(config NodeMemoryConfig, systemMemoryConfig ReservedSystemMemoryConfig, availableMemory long) : void extracted from public LocalMemoryManager(config NodeMemoryConfig, systemMemoryConfig ReservedSystemMemoryConfig) in class com.facebook.presto.memory.LocalMemoryManager	From	To
Extract Method private isBlockedOnMemory() : boolean extracted from public updateMemoryUsage(bytesAdded long) : void in class com.facebook.presto.execution.buffer.OutputBufferMemoryManager	From	To
Extract Method private configureMemoryPools(config NodeMemoryConfig, availableMemory long) : void extracted from public LocalMemoryManager(config NodeMemoryConfig, systemMemoryConfig ReservedSystemMemoryConfig) in class com.facebook.presto.memory.LocalMemoryManager	From	To
Rename Method	4
Rename Method public getNotFullFuture() : ListenableFuture<?> renamed to public getBufferBlockedFuture() : ListenableFuture<?> in class com.facebook.presto.execution.buffer.OutputBufferMemoryManager	From	To
Rename Method public getUserMemoryReservation() : long renamed to public getMemoryReservation() : long in class com.facebook.presto.memory.LowMemoryKiller.QueryMemoryInfo	From	To
Rename Method public exceededLocalLimit(maxMemory DataSize) : ExceededMemoryLimitException renamed to public exceededLocalUserMemoryLimit(maxMemory DataSize) : ExceededMemoryLimitException in class com.facebook.presto.ExceededMemoryLimitException	From	To
Rename Method package getQueryUserMemoryReservation(queryId QueryId) : long renamed to package getQueryMemoryReservation(queryId QueryId) : long in class com.facebook.presto.memory.MemoryPool	From	To
Push Down Method	26
Push Down Method public getTaskContextByTaskId(taskId TaskId) : TaskContext from class com.facebook.presto.memory.QueryContext to public getTaskContextByTaskId(taskId TaskId) : TaskContext from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method private tryUpdateUserMemory(delta long) : boolean from class com.facebook.presto.memory.QueryContext to private tryUpdateUserMemory(delta long) : boolean from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method private updateSystemMemory(delta long) : ListenableFuture<?> from class com.facebook.presto.memory.QueryContext to private updateSystemMemory(delta long) : ListenableFuture<?> from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method package abstract tryUpdateBytes(delta long) : boolean from class com.facebook.presto.memory.context.AggregatedMemoryContext to package abstract tryUpdateBytes(delta long) : boolean from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext	From	To
Push Down Method public acceptChildren(visitor QueryContextVisitor<C,R>, context C) : List<R> from class com.facebook.presto.memory.QueryContext to public acceptChildren(visitor QueryContextVisitor<C,R>, context C) : List<R> from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method package abstract updateBytes(bytes long) : ListenableFuture<?> from class com.facebook.presto.memory.context.AggregatedMemoryContext to package abstract updateBytes(bytes long) : ListenableFuture<?> from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext	From	To
Push Down Method package abstract closeContext() : void from class com.facebook.presto.memory.context.AggregatedMemoryContext to package abstract closeContext() : void from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext	From	To
Push Down Method public QueryContext(queryId QueryId, maxMemory DataSize, memoryPool MemoryPool, systemMemoryPool MemoryPool, gcMonitor GcMonitor, notificationExecutor Executor, yieldExecutor ScheduledExecutorService, maxSpill DataSize, spillSpaceTracker SpillSpaceTracker) from class com.facebook.presto.memory.QueryContext to public LegacyQueryContext(queryId QueryId, maxMemory DataSize, memoryPool MemoryPool, systemMemoryPool MemoryPool, gcMonitor GcMonitor, notificationExecutor Executor, yieldExecutor ScheduledExecutorService, maxSpill DataSize, spillSpaceTracker SpillSpaceTracker) from class com.facebook.presto.memory.LegacyQueryContext	From	To
Push Down Method public getMemoryPool() : MemoryPool from class com.facebook.presto.memory.QueryContext to public getMemoryPool() : MemoryPool from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method private updateUserMemory(delta long) : ListenableFuture<?> from class com.facebook.presto.memory.QueryContext to private updateUserMemory(delta long) : ListenableFuture<?> from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method public freeSpill(bytes long) : void from class com.facebook.presto.memory.QueryContext to public freeSpill(bytes long) : void from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method private updateRevocableMemory(delta long) : ListenableFuture<?> from class com.facebook.presto.memory.QueryContext to private updateRevocableMemory(delta long) : ListenableFuture<?> from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method package addExact(usedBytes long, bytes long) : long from class com.facebook.presto.memory.context.AggregatedMemoryContext to package addExact(usedBytes long, bytes long) : long from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext	From	To
Push Down Method public getBytes() : long from class com.facebook.presto.memory.context.AggregatedMemoryContext to public getBytes() : long from class com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext	From	To
Push Down Method public accept(visitor QueryContextVisitor<C,R>, context C) : R from class com.facebook.presto.memory.QueryContext to public accept(visitor QueryContextVisitor<C,R>, context C) : R from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method public newAggregatedMemoryContext() : AggregatedMemoryContext from class com.facebook.presto.memory.context.AggregatedMemoryContext to public newAggregatedMemoryContext() : AggregatedMemoryContext from class com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext	From	To
Push Down Method public setResourceOvercommit() : void from class com.facebook.presto.memory.QueryContext to public setResourceOvercommit() : void from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method public toString() : String from class com.facebook.presto.memory.context.AggregatedMemoryContext to public toString() : String from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext	From	To
Push Down Method package addBytes(bytes long) : void from class com.facebook.presto.memory.context.AggregatedMemoryContext to package addBytes(bytes long) : void from class com.facebook.presto.memory.context.AbstractAggregatedMemoryContext	From	To
Push Down Method public close() : void from class com.facebook.presto.memory.context.AggregatedMemoryContext to public close() : void from class com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext	From	To
Push Down Method public addTaskContext(taskStateMachine TaskStateMachine, session Session, verboseStats boolean, cpuTimerEnabled boolean) : TaskContext from class com.facebook.presto.memory.QueryContext to public addTaskContext(taskStateMachine TaskStateMachine, session Session, verboseStats boolean, cpuTimerEnabled boolean) : TaskContext from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method public newLocalMemoryContext() : LocalMemoryContext from class com.facebook.presto.memory.context.AggregatedMemoryContext to public newLocalMemoryContext() : LocalMemoryContext from class com.facebook.presto.operator.OperatorContext.InternalAggregatedMemoryContext	From	To
Push Down Method public setMemoryPool(pool MemoryPool) : void from class com.facebook.presto.memory.QueryContext to public setMemoryPool(pool MemoryPool) : void from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method private tryReserveMemoryNotSupported(bytes long) : boolean from class com.facebook.presto.memory.QueryContext to private tryReserveMemoryNotSupported(bytes long) : boolean from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method public reserveSpill(bytes long) : ListenableFuture<?> from class com.facebook.presto.memory.QueryContext to public reserveSpill(bytes long) : ListenableFuture<?> from class com.facebook.presto.memory.DefaultQueryContext	From	To
Push Down Method package getQueryMemoryContext() : MemoryTrackingContext from class com.facebook.presto.memory.QueryContext to package getQueryMemoryContext() : MemoryTrackingContext from class com.facebook.presto.memory.DefaultQueryContext	From	To
Inline Method	1
Inline Method private createDriverContext(memoryLimit long, systemMemoryLimit long) : DriverContext inlined to private createDriverContext(memoryLimit long) : DriverContext in class com.facebook.presto.operator.TestHashAggregationOperator	From	To
Rename Variable	3
Rename Variable currentMemory : long to currentUserMemory : long in method private updateMemoryUsage(taskStatus TaskStatus) : void in class com.facebook.presto.execution.SqlStageExecution.StageTaskListener	From	To
Rename Variable maxQueryMemoryPerNode : DataSize to maxQueryUserMemoryPerNode : DataSize in method public SqlTaskManager(planner LocalExecutionPlanner, locationFactory LocationFactory, taskExecutor TaskExecutor, queryMonitor QueryMonitor, nodeInfo NodeInfo, localMemoryManager LocalMemoryManager, taskManagementExecutor TaskManagementExecutor, config TaskManagerConfig, nodeMemoryConfig NodeMemoryConfig, localSpillManager LocalSpillManager, nodeSpillConfig NodeSpillConfig, gcMonitor GcMonitor) in class com.facebook.presto.execution.SqlTaskManager	From	To
Rename Variable maxHeap : long to availableMemory : long in method public LocalMemoryManager(config NodeMemoryConfig, systemMemoryConfig ReservedSystemMemoryConfig) in class com.facebook.presto.memory.LocalMemoryManager	From	To
Change Return Type	3
Change Return Type AggregatedMemoryContext to AbstractAggregatedMemoryContext in method package getParent() : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.RootAggregatedMemoryContext	From	To
Change Return Type AggregatedMemoryContext to AbstractAggregatedMemoryContext in method package getParent() : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.ChildAggregatedMemoryContext	From	To
Change Return Type AggregatedMemoryContext to AbstractAggregatedMemoryContext in method package getParent() : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.SimpleAggregatedMemoryContext	From	To
Parameterize Variable	2
Parameterize Variable maxHeap : long to availableMemory : long in method private configureLegacyMemoryPools(config NodeMemoryConfig, systemMemoryConfig ReservedSystemMemoryConfig, availableMemory long) : void in class com.facebook.presto.memory.LocalMemoryManager	From	To
Parameterize Variable maxHeap : long to availableMemory : long in method private configureMemoryPools(config NodeMemoryConfig, availableMemory long) : void in class com.facebook.presto.memory.LocalMemoryManager	From	To
Extract Superclass	1
Extract Superclass com.facebook.presto.memory.context.AbstractAggregatedMemoryContext from classes [com.facebook.presto.memory.context.ChildAggregatedMemoryContext, com.facebook.presto.memory.context.RootAggregatedMemoryContext, com.facebook.presto.memory.context.SimpleAggregatedMemoryContext]	From	To
Rename Attribute	2
Rename Attribute previousMemory : long to previousUserMemory : long in class com.facebook.presto.execution.SqlStageExecution.StageTaskListener	From	To
Rename Attribute userPool : MemoryPool to memoryPool : MemoryPool in class com.facebook.presto.memory.TestMemoryTracking	From	To
Change Attribute Type	3
Change Attribute Type parentMemoryContext : AggregatedMemoryContext to parentMemoryContext : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.SimpleLocalMemoryContext	From	To
Change Attribute Type queryContext : QueryContext to queryContext : DefaultQueryContext in class com.facebook.presto.memory.TestMemoryTracking	From	To
Change Attribute Type parentMemoryContext : AggregatedMemoryContext to parentMemoryContext : AbstractAggregatedMemoryContext in class com.facebook.presto.memory.context.ChildAggregatedMemoryContext	From	To
Rename Parameter	2
Rename Parameter expectedUserPoolMemory : long to expectedPoolMemory : long in method private assertLocalMemoryAllocations(memoryTrackingContext MemoryTrackingContext, expectedPoolMemory long, expectedContextUserMemory long, expectedContextSystemMemory long) : void in class com.facebook.presto.memory.TestMemoryTracking	From	To
Rename Parameter systemMemoryLimit : long to memoryLimit : long in method private createDriverContext(memoryLimit long) : DriverContext in class com.facebook.presto.operator.TestHashAggregationOperator	From	To

3adfcc9b11f2fbbf47d0bcec75fbe35c0297e2e5

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: