480c442fad5c237f8f19fe5e0f2df338eba06ff3
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method private matchAndBindTypeParameters(expectedArgumentSignature TypeSignature, actualArgumentType Type, variableBinder BoundVariables.Builder) : boolean renamed to private appendConstraintSolvers(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, formalTypeSignatures List<? extends TypeSignature>, actualTypes List<? extends Type>, allowCoercion boolean) : boolean in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Rename Method private isConcreteType(typeSignature TypeSignature) : boolean renamed to private typeVariablesOf(typeSignature TypeSignature) : Set<String> in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Rename Method public testResolveCalculatedTypes() : void renamed to public testBindLiteralForVarchar() : void in class com.facebook.presto.metadata.TestSignatureBinder | From | To | |
| Rename Method public testBindCalculatedLiteralParameter() : void renamed to public testBindLiteralForRepeatedVarchar() : void in class com.facebook.presto.metadata.TestSignatureBinder | From | To | |
| Rename Variable | 7 | ||
| Rename Variable expectedArgumentSignatures : List<TypeSignature> to formalTypeSignatures : List<TypeSignature> in method private appendConstraintSolversForArguments(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, actualTypes List<? extends Type>) : boolean in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Rename Variable typeParameterIndex : int to i : int in method private appendConstraintSolvers(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, formalTypeSignatures List<? extends TypeSignature>, actualTypes List<? extends Type>, allowCoercion boolean) : boolean in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Rename Variable variableBinder : BoundVariables.Builder to boundVariablesBuilder : BoundVariables.Builder in method private iterativeSolve(constraints List<TypeConstraintSolver>) : Optional<BoundVariables> in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Rename Variable expectedReturnTypeSignature : TypeSignature to formalReturnTypeSignature : TypeSignature in method private appendConstraintSolversForReturnValue(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, actualReturnType Type) : boolean in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Rename Variable typeSignatureParameter : TypeSignatureParameter to parameter : TypeSignatureParameter in method private typeVariablesOf(typeSignature TypeSignature) : Set<String> in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Change Return Type | 1 | ||
| Change Return Type boolean to Set<String> in method private typeVariablesOf(typeSignature TypeSignature) : Set<String> in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable expectedTypeParameters : List<TypeSignatureParameter> to formalTypeSignatures : List<? extends TypeSignature> in method private appendConstraintSolvers(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, formalTypeSignatures List<? extends TypeSignature>, actualTypes List<? extends Type>, allowCoercion boolean) : boolean in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Parameterize Variable actualTypeParameters : List<TypeSignatureParameter> to actualTypes : List<? extends Type> in method private appendConstraintSolvers(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, formalTypeSignatures List<? extends TypeSignature>, actualTypes List<? extends Type>, allowCoercion boolean) : boolean in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type expectedTypeParameters : List<TypeSignatureParameter> to formalTypeSignatures : List<? extends TypeSignature> in method private appendConstraintSolvers(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, formalTypeSignatures List<? extends TypeSignature>, actualTypes List<? extends Type>, allowCoercion boolean) : boolean in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Change Variable Type actualTypeParameters : List<TypeSignatureParameter> to actualTypes : List<? extends Type> in method private appendConstraintSolvers(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, formalTypeSignatures List<? extends TypeSignature>, actualTypes List<? extends Type>, allowCoercion boolean) : boolean in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Extract Method | 6 | ||
| Extract Method private appendConstraintSolversForArguments(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, actualTypes List<? extends Type>) : boolean extracted from public bindVariables(actualArgumentTypes List<? extends Type>, actualReturnType Type) : Optional<BoundVariables> in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Extract Method private appendConstraintSolversForReturnValue(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, actualReturnType Type) : boolean extracted from public bindVariables(actualArgumentTypes List<? extends Type>, actualReturnType Type) : Optional<BoundVariables> in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Extract Method private iterativeSolve(constraints List<TypeConstraintSolver>) : Optional<BoundVariables> extracted from public bindVariables(actualArgumentTypes List<? extends Type>, actualReturnType Type) : Optional<BoundVariables> in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Extract Method private iterativeSolve(constraints List<TypeConstraintSolver>) : Optional<BoundVariables> extracted from public bindVariables(actualArgumentTypes List<? extends Type>) : Optional<BoundVariables> in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Extract Method private appendConstraintSolversForArguments(resultBuilder ImmutableList.Builder<TypeConstraintSolver>, actualTypes List<? extends Type>) : boolean extracted from public bindVariables(actualArgumentTypes List<? extends Type>) : Optional<BoundVariables> in class com.facebook.presto.metadata.SignatureBinder | From | To | |
| Extract Method private isTypeWithLiteralParameters(typeSignature TypeSignature) : boolean extracted from public bindVariables(actualArgumentTypes List<? extends Type>, actualReturnType Type) : Optional<BoundVariables> in class com.facebook.presto.metadata.SignatureBinder | From | To |