4f0f9fae5611bbcb0632798a751adda0d9f40a62
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public createLookupSource(session Session, joinChannels List<Integer>) : LookupSource renamed to public createLookupSourceSupplier(session Session, joinChannels List<Integer>) : Supplier<LookupSource> in class com.facebook.presto.operator.PagesIndex | From | To | |
| Rename Method public createLookupSource(addresses LongArrayList, channels List<List<Block>>, hashChannel Optional<Integer>, joinFilterFunction Optional<JoinFilterFunction>) : LookupSource renamed to public createLookupSourceSupplier(session ConnectorSession, addresses LongArrayList, channels List<List<Block>>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : Supplier<LookupSource> in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory | From | To | |
| Rename Method public createLookupSource(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : LookupSource renamed to public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : Supplier<LookupSource> in class com.facebook.presto.operator.PagesIndex | From | To | |
| Rename Method public setLookupSource(lookupSource LookupSource, operatorContext OperatorContext) : void renamed to public setLookupSourceSupplier(lookupSourceSupplier Supplier<LookupSource>, operatorContext OperatorContext) : void in class com.facebook.presto.operator.SettableLookupSourceFactory | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type lookupSource : LookupSource to lookupSourceSupplier : Supplier<LookupSource> in method public setLookupSourceSupplier(lookupSourceSupplier Supplier<LookupSource>, operatorContext OperatorContext) : void in class com.facebook.presto.operator.SettableLookupSourceFactory | From | To | |
| Change Parameter Type lookupSourceClass : Class<? extends LookupSource> to joinHashSupplierClass : Class<? extends Supplier> in method public LookupSourceSupplierFactory(joinHashSupplierClass Class<? extends Supplier>, pagesHashStrategyFactory PagesHashStrategyFactory) in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory | From | To | |
| Change Parameter Type outer : boolean to outerPositionTracker : Optional<OuterPositionTracker> in method private PartitionedLookupSource(lookupSources List<? extends LookupSource>, hashChannelTypes List<Type>, outerPositionTracker Optional<OuterPositionTracker>) in class com.facebook.presto.operator.PartitionedLookupSource | From | To | |
| Rename Variable | 4 | ||
| Rename Variable lookupSourceClass : Class<? extends LookupSource> to joinHashSupplierClass : Class<? extends Supplier> in method private internalCompileLookupSourceFactory(types List<Type>, joinChannels List<Integer>) : LookupSourceSupplierFactory in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Rename Variable lookupSource : LookupSource to supplier : Supplier<LookupSource> in method public finish() : void in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Rename Variable lookupSource : LookupSource to partition : Supplier<LookupSource> in method public finish() : void in class com.facebook.presto.operator.ParallelHashBuildOperator | From | To | |
| Rename Variable lookupSourceFactoryFactory : LookupSourceFactory to lookupSourceSupplierFactory : LookupSourceSupplierFactory in method public testSingleChannel(hashEnabled boolean) : void in class com.facebook.presto.sql.gen.TestJoinProbeCompiler | From | To | |
| Change Return Type | 5 | ||
| Change Return Type LookupSource to Supplier<LookupSource> in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : Supplier<LookupSource> in class com.facebook.presto.operator.PagesIndex | From | To | |
| Change Return Type LookupSource to Supplier<LookupSource> in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>) : Supplier<LookupSource> in class com.facebook.presto.operator.PagesIndex | From | To | |
| Change Return Type LookupSource to Supplier<LookupSource> in method public createLookupSourceSupplier(session ConnectorSession, addresses LongArrayList, channels List<List<Block>>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : Supplier<LookupSource> in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory | From | To | |
| Change Return Type LookupSourceFactory to LookupSourceSupplierFactory in method private internalCompileLookupSourceFactory(types List<Type>, joinChannels List<Integer>) : LookupSourceSupplierFactory in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Change Return Type LookupSourceFactory to LookupSourceSupplierFactory in method public compileLookupSourceFactory(types List<? extends Type>, joinChannels List<Integer>) : LookupSourceSupplierFactory in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private visitedPositions : boolean[][] from class com.facebook.presto.operator.PartitionedLookupSource to private visitedPositions : boolean[][] from class com.facebook.presto.operator.PartitionedLookupSource.OuterPositionTracker | From | To | |
| Move Attribute private visitedPositions : boolean[] from class com.facebook.presto.operator.OuterLookupSource to private visitedPositions : boolean[] from class com.facebook.presto.operator.OuterLookupSource.OuterPositionTracker | From | To | |
| Extract Class | 2 | ||
| Extract Class com.facebook.presto.operator.OuterLookupSource.OuterPositionTracker from class com.facebook.presto.operator.OuterLookupSource | From | To | |
| Extract Class com.facebook.presto.operator.PartitionedLookupSource.OuterPositionTracker from class com.facebook.presto.operator.PartitionedLookupSource | From | To | |
| Rename Class | 1 | ||
| Rename Class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceFactory renamed to com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory | From | To | |
| Extract Variable | 1 | ||
| Extract Variable channels : List<List<Block>> in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : Supplier<LookupSource> from class com.facebook.presto.operator.PagesIndex | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type lookupSource : LookupSource to partition : Supplier<LookupSource> in method public finish() : void in class com.facebook.presto.operator.ParallelHashBuildOperator | From | To | |
| Change Variable Type lookupSource : LookupSource to supplier : Supplier<LookupSource> in method public finish() : void in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Change Variable Type lookupSourceFactory : LookupSourceFactory to lookupSourceFactory : LookupSourceSupplierFactory in method public createLookupSourceSupplier(session Session, joinChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>) : Supplier<LookupSource> in class com.facebook.presto.operator.PagesIndex | From | To | |
| Change Variable Type lookupSourceFactoryFactory : LookupSourceFactory to lookupSourceSupplierFactory : LookupSourceSupplierFactory in method public testSingleChannel(hashEnabled boolean) : void in class com.facebook.presto.sql.gen.TestJoinProbeCompiler | From | To | |
| Change Variable Type lookupSourceClass : Class<? extends LookupSource> to joinHashSupplierClass : Class<? extends Supplier> in method private internalCompileLookupSourceFactory(types List<Type>, joinChannels List<Integer>) : LookupSourceSupplierFactory in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type constructor : Constructor<? extends LookupSource> to constructor : Constructor<? extends Supplier> in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory | From | To | |
| Change Attribute Type partitions : LookupSource[] to partitions : Supplier<LookupSource>[] in class com.facebook.presto.operator.PartitionedLookupSourceFactory | From | To | |
| Change Attribute Type lookupSourceFactories : LoadingCache<CacheKey,LookupSourceFactory> to lookupSourceFactories : LoadingCache<CacheKey,LookupSourceSupplierFactory> in class com.facebook.presto.sql.gen.JoinCompiler | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public createOuterLookupSourceSupplier(lookupSourceSupplier Supplier<LookupSource>) : Supplier<LookupSource> extracted from public setLookupSource(lookupSource LookupSource, operatorContext OperatorContext) : void in class com.facebook.presto.operator.SettableLookupSourceFactory & moved to class com.facebook.presto.operator.OuterLookupSource | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter outer : boolean to outerPositionTracker : Optional<OuterPositionTracker> in method private PartitionedLookupSource(lookupSources List<? extends LookupSource>, hashChannelTypes List<Type>, outerPositionTracker Optional<OuterPositionTracker>) in class com.facebook.presto.operator.PartitionedLookupSource | From | To | |
| Rename Parameter lookupSource : LookupSource to lookupSourceSupplier : Supplier<LookupSource> in method public setLookupSourceSupplier(lookupSourceSupplier Supplier<LookupSource>, operatorContext OperatorContext) : void in class com.facebook.presto.operator.SettableLookupSourceFactory | From | To | |
| Rename Parameter lookupSourceClass : Class<? extends LookupSource> to joinHashSupplierClass : Class<? extends Supplier> in method public LookupSourceSupplierFactory(joinHashSupplierClass Class<? extends Supplier>, pagesHashStrategyFactory PagesHashStrategyFactory) in class com.facebook.presto.sql.gen.JoinCompiler.LookupSourceSupplierFactory | From | To |