presto 505098d925910f6f1a46e73484f4b63a50dced59

505098d925910f6f1a46e73484f4b63a50dced59

Files Diff

Added: 3
Removed: 2
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move Method	2
Move Method public getDistribution() : PlanDistribution from class com.facebook.presto.sql.planner.SubPlanBuilder to public getDistribution() : PlanDistribution from class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties	From	To
Move Method public getChildren() : List<SubPlan> from class com.facebook.presto.sql.planner.SubPlanBuilder to public getChildren() : List<SubPlan> from class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties	From	To
Move Attribute	3
Move Attribute private hash : Optional<Symbol> from class com.facebook.presto.sql.planner.SubPlanBuilder to private hash : Optional<Symbol> from class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties	From	To
Move Attribute private children : List<SubPlan> from class com.facebook.presto.sql.planner.SubPlanBuilder to private children : List<SubPlan> from class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties	From	To
Move Attribute private partitionBy : List<Symbol> from class com.facebook.presto.sql.planner.SubPlanBuilder to private partitionBy : List<Symbol> from class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties	From	To
Extract Class	1
Extract Class com.facebook.presto.sql.planner.PlanFragmenter.FragmentProperties from class com.facebook.presto.sql.planner.SubPlanBuilder	From	To
Move And Rename Class	2
Move And Rename Class com.facebook.presto.sql.planner.SubPlanBuilder moved and renamed to com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Move And Rename Class com.facebook.presto.sql.planner.DistributedLogicalPlanner.Visitor moved and renamed to com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Merge Parameter	1
Merge Parameter [functions : Map<Symbol,Signature>, aggregations : Map<Symbol,FunctionCall>] to node : AggregationNode in method public visitAggregation(node AggregationNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Variable Type	7
Change Variable Type current : SubPlanBuilder to probeSource : PlanWithProperties in method public visitIndexJoin(node IndexJoinNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Variable Type right : SubPlanBuilder to right : PlanWithProperties in method public visitJoin(node JoinNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Variable Type filteringSource : SubPlanBuilder to filteringSource : PlanWithProperties in method public visitSemiJoin(node SemiJoinNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Variable Type source : SubPlanBuilder to source : PlanWithProperties in method public visitSemiJoin(node SemiJoinNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Variable Type sourceBuilder : ImmutableList.Builder<SubPlan> to sourceOutputLayouts : ImmutableList.Builder<List<Symbol>> in method public visitUnion(node UnionNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Variable Type left : SubPlanBuilder to left : PlanWithProperties in method public visitJoin(node JoinNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Variable Type current : SubPlanBuilder to source : PlanWithProperties in method public visitAggregation(node AggregationNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Inline Variable	1
Inline Variable source : PlanNode in method public visitTableCommit(node TableCommitNode, context Void) : Void from class com.facebook.presto.sql.planner.PlanSanityChecker.Visitor	From	To
Rename Method	2
Rename Method public setRoot(root PlanNode) : SubPlanBuilder renamed to public PlanWithProperties(node PlanNode, properties ActualProperties) in class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Rename Method public getId() : PlanFragmentId renamed to public getNode() : PlanNode in class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Rename Variable	5
Rename Variable current : SubPlanBuilder to source : PlanWithProperties in method public visitAggregation(node AggregationNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Rename Variable sourceBuilder : ImmutableList.Builder<PlanNode> to builder : ImmutableList.Builder<PlanNode> in method public visitUnion(node UnionNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Rename Variable source : PlanNode to child : PlanNode in method public visitUnion(node UnionNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Rename Variable current : SubPlanBuilder to probeSource : PlanWithProperties in method public visitIndexJoin(node IndexJoinNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Rename Variable sourceBuilder : ImmutableList.Builder<SubPlan> to sourceOutputLayouts : ImmutableList.Builder<List<Symbol>> in method public visitUnion(node UnionNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Inline Method	1
Inline Method private addDistributedAggregation(plan SubPlanBuilder, aggregations Map<Symbol,FunctionCall>, functions Map<Symbol,Signature>, masks Map<Symbol,Symbol>, groupBy List<Symbol>, sampleWeight Optional<Symbol>, confidence double, hashSymbol Optional<Symbol>) : SubPlanBuilder inlined to public visitAggregation(node AggregationNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type	19
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitLimit(node LimitNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitSemiJoin(node SemiJoinNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitDistinctLimit(node DistinctLimitNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitRowNumber(node RowNumberNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitJoin(node JoinNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitMarkDistinct(node MarkDistinctNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitOutput(node OutputNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitTopN(node TopNNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitTopNRowNumber(node TopNRowNumberNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitTableCommit(node TableCommitNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitUnion(node UnionNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitValues(node ValuesNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitSort(node SortNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitIndexJoin(node IndexJoinNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type PlanFragmentId to PlanNode in method public getNode() : PlanNode in class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitTableScan(node TableScanNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitWindow(node WindowNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method public visitAggregation(node AggregationNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Return Type SubPlanBuilder to PlanWithProperties in method protected visitPlan(node PlanNode, context Void) : PlanWithProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Rename Attribute	3
Rename Attribute createSingleNodePlan : boolean to session : Session in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Rename Attribute root : PlanNode to node : PlanNode in class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Rename Attribute outputLayout : List<Symbol> to properties : ActualProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Change Attribute Type	2
Change Attribute Type createSingleNodePlan : boolean to session : Session in class com.facebook.presto.sql.planner.optimizations.AddExchanges.Rewriter	From	To
Change Attribute Type outputLayout : List<Symbol> to properties : ActualProperties in class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Extract And Move Method	5
Extract And Move Method public getProperties() : ActualProperties extracted from public visitAggregation(node AggregationNode, context Void) : SubPlanBuilder in class com.facebook.presto.sql.planner.DistributedLogicalPlanner.Visitor & moved to class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Extract And Move Method public getProperties() : ActualProperties extracted from public visitJoin(node JoinNode, context Void) : SubPlanBuilder in class com.facebook.presto.sql.planner.DistributedLogicalPlanner.Visitor & moved to class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Extract And Move Method public getProperties() : ActualProperties extracted from public visitIndexJoin(node IndexJoinNode, context Void) : SubPlanBuilder in class com.facebook.presto.sql.planner.DistributedLogicalPlanner.Visitor & moved to class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Extract And Move Method public getProperties() : ActualProperties extracted from public visitMarkDistinct(node MarkDistinctNode, context Void) : SubPlanBuilder in class com.facebook.presto.sql.planner.DistributedLogicalPlanner.Visitor & moved to class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Extract And Move Method public getProperties() : ActualProperties extracted from public visitSemiJoin(node SemiJoinNode, context Void) : SubPlanBuilder in class com.facebook.presto.sql.planner.DistributedLogicalPlanner.Visitor & moved to class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To
Rename Parameter	1
Rename Parameter root : PlanNode to node : PlanNode in method public PlanWithProperties(node PlanNode, properties ActualProperties) in class com.facebook.presto.sql.planner.optimizations.AddExchanges.PlanWithProperties	From	To

505098d925910f6f1a46e73484f4b63a50dced59

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: