51e6a49647db3c630633afd6e8a8121f36c8c4e5
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private newSymbol(context Context, expression Expression) : Optional<Symbol> renamed to private newGeometrySymbol(context Context, expression Expression) : Optional<Symbol> in class com.facebook.presto.sql.planner.iterative.rule.TransformSpatialPredicateToJoin | From | To | |
| Change Parameter Type | 9 | ||
| Change Parameter Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in method public SpatialIndexBuilderOperatorFactory(operatorId int, planNodeId PlanNodeId, types List<Type>, outputChannels List<Integer>, indexChannel int, radiusChannel Optional<Integer>, spatialRelationshipTest SpatialPredicate, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int, pagesIndexFactory PagesIndex.Factory) in class com.facebook.presto.operator.SpatialIndexBuilderOperator.SpatialIndexBuilderOperatorFactory | From | To | |
| Change Parameter Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in method private buildIndex(driverContext DriverContext, spatialRelationshipTest SpatialPredicate, radiusChannel Optional<Integer>, filterFunction Optional<InternalJoinFilterFunction>, buildPages RowPagesBuilder) : PagesSpatialIndexFactory in class com.facebook.presto.plugin.geospatial.TestSpatialJoinOperator | From | To | |
| Change Parameter Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in method public createPagesSpatialIndex(session Session, geometryChannel int, radiusChannel Optional<Integer>, spatialRelationshipTest SpatialPredicate, filterFunctionFactory Optional<JoinFilterFunctionFactory>, outputChannels List<Integer>) : PagesSpatialIndexSupplier in class com.facebook.presto.operator.PagesIndex | From | To | |
| Change Parameter Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in method public PagesSpatialIndexSupplier(session Session, addresses LongArrayList, types List<Type>, outputChannels List<Integer>, channels List<List<Block>>, geometryChannel int, radiusChannel Optional<Integer>, spatialRelationshipTest SpatialPredicate, filterFunctionFactory Optional<JoinFilterFunctionCompiler.JoinFilterFunctionFactory>) in class com.facebook.presto.operator.PagesSpatialIndexSupplier | From | To | |
| Change Parameter Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in method private SpatialIndexBuilderOperator(operatorContext OperatorContext, pagesSpatialIndexFactory PagesSpatialIndexFactory, outputChannels List<Integer>, indexChannel int, radiusChannel Optional<Integer>, spatialRelationshipTest SpatialPredicate, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int, pagesIndexFactory PagesIndex.Factory) in class com.facebook.presto.operator.SpatialIndexBuilderOperator | From | To | |
| Change Parameter Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in method private createSpatialLookupJoin(node JoinNode, probeNode PlanNode, probeSymbol Symbol, buildNode PlanNode, buildSymbol Symbol, radiusSymbol Optional<Symbol>, spatialRelationshipTest SpatialPredicate, joinFilter Optional<Expression>, context LocalExecutionPlanContext) : PhysicalOperation in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Change Parameter Type expression : FunctionCall to expression : Expression in method private removeExpressionFromFilter(filter Expression, expression Expression) : Optional<Expression> in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Change Parameter Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in method public PagesRTreeIndex(session Session, addresses LongArrayList, types List<Type>, outputChannels List<Integer>, channels List<List<Block>>, rtree STRtree, radiusChannel Optional<Integer>, spatialRelationshipTest SpatialPredicate, filterFunctionFactory Optional<JoinFilterFunctionFactory>) in class com.facebook.presto.operator.PagesRTreeIndex | From | To | |
| Change Parameter Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in method private createPagesSpatialIndexFactory(node JoinNode, buildNode PlanNode, buildSymbol Symbol, radiusSymbol Optional<Symbol>, probeLayout Map<Symbol,Integer>, spatialRelationshipTest SpatialPredicate, joinFilter Optional<Expression>, context LocalExecutionPlanContext) : PagesSpatialIndexFactory in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Rename Variable | 1 | ||
| Rename Variable firstArgument : Expression to radius : Expression in method private tryCreateSpatialJoin(context Context, filterNode FilterNode, joinNode JoinNode, filter Expression, spatialComparison ComparisonExpression) : Result in class com.facebook.presto.sql.planner.iterative.rule.TransformSpatialPredicateToJoin | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable functionCall : FunctionCall to spatialFunction : FunctionCall in method private isSpatialJoinFilter(left PlanNode, right PlanNode, spatialFunction FunctionCall) : boolean in class com.facebook.presto.util.SpatialJoinUtils | From | To | |
| Extract Variable | 1 | ||
| Extract Variable buildChannelGetter : Function<Symbol,Integer> in method private createPagesSpatialIndexFactory(node JoinNode, buildNode PlanNode, buildSymbol Symbol, radiusSymbol Optional<Symbol>, probeLayout Map<Symbol,Integer>, spatialRelationshipTest SpatialPredicate, joinFilter Optional<Expression>, context LocalExecutionPlanContext) : PagesSpatialIndexFactory from class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Inline Variable | 1 | ||
| Inline Variable buildSymbols : Set<SymbolReference> in method private createSpatialJoin(node JoinNode, context LocalExecutionPlanContext) : PhysicalOperation from class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Extract Method | 5 | ||
| Extract Method private tryCreateSpatialJoin(context LocalExecutionPlanContext, node JoinNode, filterExpression Optional<Expression>, spatialFunction FunctionCall, radius Optional<Expression>, comparisonType Optional<ComparisonExpressionType>) : Optional<PhysicalOperation> extracted from private createSpatialJoin(node JoinNode, context LocalExecutionPlanContext) : PhysicalOperation in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Extract Method public extractSupportedSpatialComparisons(filterExpression Expression) : List<ComparisonExpression> extracted from public isSpatialJoinFilter(left PlanNode, right PlanNode, filterExpression Expression) : boolean in class com.facebook.presto.util.SpatialJoinUtils | From | To | |
| Extract Method private isSpatialJoinFilter(left PlanNode, right PlanNode, spatialFunction FunctionCall) : boolean extracted from public isSpatialJoinFilter(left PlanNode, right PlanNode, filterExpression Expression) : boolean in class com.facebook.presto.util.SpatialJoinUtils | From | To | |
| Extract Method private tryCreateSpatialJoin(context Context, filterNode FilterNode, joinNode JoinNode, filter Expression, spatialComparison ComparisonExpression) : Result extracted from public apply(node FilterNode, captures Captures, context Context) : Result in class com.facebook.presto.sql.planner.iterative.rule.TransformSpatialPredicateToJoin | From | To | |
| Extract Method private tryCreateSpatialJoin(context Context, filterNode FilterNode, joinNode JoinNode, filter Expression, spatialFunction FunctionCall) : Result extracted from public apply(node FilterNode, captures Captures, context Context) : Result in class com.facebook.presto.sql.planner.iterative.rule.TransformSpatialPredicateToJoin | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in class com.facebook.presto.operator.SpatialIndexBuilderOperator | From | To | |
| Change Attribute Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in class com.facebook.presto.operator.PagesSpatialIndexSupplier | From | To | |
| Change Attribute Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in class com.facebook.presto.operator.PagesRTreeIndex | From | To | |
| Change Attribute Type spatialRelationshipTest : BiPredicate<OGCGeometry,OGCGeometry> to spatialRelationshipTest : SpatialPredicate in class com.facebook.presto.operator.SpatialIndexBuilderOperator.SpatialIndexBuilderOperatorFactory | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public extractSupportedSpatialComparisons(filterExpression Expression) : List<ComparisonExpression> extracted from private createSpatialJoin(node JoinNode, context LocalExecutionPlanContext) : PhysicalOperation in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor & moved to class com.facebook.presto.util.SpatialJoinUtils | From | To | |
| Extract And Move Method public extractSupportedSpatialComparisons(filterExpression Expression) : List<ComparisonExpression> extracted from public apply(node FilterNode, captures Captures, context Context) : Result in class com.facebook.presto.sql.planner.iterative.rule.TransformSpatialPredicateToJoin & moved to class com.facebook.presto.util.SpatialJoinUtils | From | To |