presto 5643df402431bc9ae81b1fcec8a7cec2765ca9d5

5643df402431bc9ae81b1fcec8a7cec2765ca9d5

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 22

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	1
Change Parameter Type accessControl : ConnectorAccessControl to accessControl : TransactionalConnectorAccessControl in method public addCatalogAccessControl(connectorId String, catalogName String, accessControl TransactionalConnectorAccessControl) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable	14
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanRenameColumn(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanCreateViewWithSelectFromTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanDropView(transactionId TransactionId, identity Identity, viewName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanCreateView(transactionId TransactionId, identity Identity, viewName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanDropTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanSelectFromView(transactionId TransactionId, identity Identity, viewName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanDeleteFromTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanRenameTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName, newTableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanInsertIntoTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanCreateViewWithSelectFromView(transactionId TransactionId, identity Identity, viewName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanAddColumns(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanCreateTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanSelectFromTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Rename Variable accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanSetCatalogSessionProperty(identity Identity, catalogName String, propertyName String) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Return Type	2
Change Return Type ConnectorAccessControl to TransactionalConnectorAccessControl in method public getAccessControl() : TransactionalConnectorAccessControl in class com.facebook.presto.transaction.LegacyTransactionConnector	From	To
Change Return Type ConnectorAccessControl to TransactionalConnectorAccessControl in method public getAccessControl() : TransactionalConnectorAccessControl in class com.facebook.presto.spi.transaction.TransactionalConnector	From	To
Change Variable Type	15
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanSelectFromTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanSetCatalogSessionProperty(identity Identity, catalogName String, propertyName String) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanRenameColumn(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to accessControl : TransactionalConnectorAccessControl in method private addConnectorInternal(type ConnectorType, catalogName String, connectorId String, connector TransactionalConnector) : void in class com.facebook.presto.connector.ConnectorManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanCreateViewWithSelectFromTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanDropView(transactionId TransactionId, identity Identity, viewName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanCreateView(transactionId TransactionId, identity Identity, viewName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanDropTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanSelectFromView(transactionId TransactionId, identity Identity, viewName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanRenameTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName, newTableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanInsertIntoTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanDeleteFromTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanCreateViewWithSelectFromView(transactionId TransactionId, identity Identity, viewName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanAddColumns(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Change Variable Type accessControl : ConnectorAccessControl to entry : CatalogAccessControlEntry in method public checkCanCreateTable(transactionId TransactionId, identity Identity, tableName QualifiedObjectName) : void in class com.facebook.presto.security.AccessControlManager	From	To
Extract Interface	1
Extract Interface com.facebook.presto.spi.security.TransactionalConnectorAccessControl from classes [com.facebook.presto.security.TestAccessControlManager.DenyConnectorAccessControl]	From	To
Change Attribute Type	1
Change Attribute Type catalogAccessControl : Map<String,ConnectorAccessControl> to catalogAccessControl : Map<String,CatalogAccessControlEntry> in class com.facebook.presto.security.AccessControlManager	From	To

5643df402431bc9ae81b1fcec8a7cec2765ca9d5

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: