presto 5696ac1850a5c6ebba60bc5e7b48fb36cea21e16

5696ac1850a5c6ebba60bc5e7b48fb36cea21e16

Files Diff

Added: 8
Removed: 0
Renamed: 0
Modified: 29

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method public getClientId() : String renamed to public getPartitionedBy() : List<String> in class com.facebook.presto.hive.HiveOutputTableHandle	From	To
Pull Up Method	7
Pull Up Method public HiveOutputTableHandle(clientId String, schemaName String, tableName String, inputColumns List<HiveColumnHandle>, filePrefix String, writePath String, hiveStorageFormat HiveStorageFormat, tableOwner String) from class com.facebook.presto.hive.HiveOutputTableHandle to public HiveWritableTableHandle(clientId String, schemaName String, tableName String, inputColumns List<HiveColumnHandle>, filePrefix String, writePath Optional<String>, hiveStorageFormat HiveStorageFormat) from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Method public getFilePrefix() : String from class com.facebook.presto.hive.HiveOutputTableHandle to public getFilePrefix() : String from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Method public getSchemaName() : String from class com.facebook.presto.hive.HiveOutputTableHandle to public getSchemaName() : String from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Method public toString() : String from class com.facebook.presto.hive.HiveOutputTableHandle to public toString() : String from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Method public getInputColumns() : List<HiveColumnHandle> from class com.facebook.presto.hive.HiveOutputTableHandle to public getInputColumns() : List<HiveColumnHandle> from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Method public getHiveStorageFormat() : HiveStorageFormat from class com.facebook.presto.hive.HiveOutputTableHandle to public getHiveStorageFormat() : HiveStorageFormat from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Method public getTableName() : String from class com.facebook.presto.hive.HiveOutputTableHandle to public getTableName() : String from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Change Parameter Type	2
Change Parameter Type writePath : Path to writePath : Optional<Path> in method public HivePageSink(schemaName String, tableName String, isCreateTable boolean, inputColumns List<HiveColumnHandle>, tableStorageFormat HiveStorageFormat, writePath Optional<Path>, filePrefix String, metastore HiveMetastore, pageIndexerFactory PageIndexerFactory, typeManager TypeManager, hdfsEnvironment HdfsEnvironment, maxWriters int, partitionUpdateCodec JsonCodec<PartitionUpdate>) in class com.facebook.presto.hive.HivePageSink	From	To
Change Parameter Type writePath : String to writePath : Optional<String> in method public HiveWritableTableHandle(clientId String, schemaName String, tableName String, inputColumns List<HiveColumnHandle>, filePrefix String, writePath Optional<String>, hiveStorageFormat HiveStorageFormat) in class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Move Method	1
Move Method public getWritePath() : String from class com.facebook.presto.hive.HiveOutputTableHandle to public getWritePath() : String from class com.facebook.presto.hive.PartitionUpdate	From	To
Pull Up Attribute	6
Pull Up Attribute private clientId : String from class com.facebook.presto.hive.HiveOutputTableHandle to private clientId : String from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Attribute private inputColumns : List<HiveColumnHandle> from class com.facebook.presto.hive.HiveOutputTableHandle to private inputColumns : List<HiveColumnHandle> from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Attribute private filePrefix : String from class com.facebook.presto.hive.HiveOutputTableHandle to private filePrefix : String from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Attribute private schemaName : String from class com.facebook.presto.hive.HiveOutputTableHandle to private schemaName : String from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Attribute private tableName : String from class com.facebook.presto.hive.HiveOutputTableHandle to private tableName : String from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Pull Up Attribute private hiveStorageFormat : HiveStorageFormat from class com.facebook.presto.hive.HiveOutputTableHandle to private hiveStorageFormat : HiveStorageFormat from class com.facebook.presto.hive.HiveWritableTableHandle	From	To
Change Return Type	3
Change Return Type void to Table in method private createTable(schemaName String, tableName String, tableOwner String, columnHandles List<HiveColumnHandle>, hiveStorageFormat HiveStorageFormat, partitionedBy List<String>, targetPath Path) : Table in class com.facebook.presto.hive.HiveMetadata	From	To
Change Return Type String to List<String> in method public getPartitionedBy() : List<String> in class com.facebook.presto.hive.HiveOutputTableHandle	From	To
Change Return Type ConnectorInsertTableHandle to HiveInsertTableHandle in method public beginInsert(session ConnectorSession, tableHandle ConnectorTableHandle) : HiveInsertTableHandle in class com.facebook.presto.hive.HiveMetadata	From	To
Move Attribute	1
Move Attribute private writePath : String from class com.facebook.presto.hive.HiveOutputTableHandle to private writePath : String from class com.facebook.presto.hive.PartitionUpdate	From	To
Extract Superclass	1
Extract Superclass com.facebook.presto.hive.HiveWritableTableHandle from classes [com.facebook.presto.hive.HiveOutputTableHandle]	From	To
Change Variable Type	2
Change Variable Type handle : HiveOutputTableHandle to handle : HiveWritableTableHandle in method public createPageSink(session ConnectorSession, tableHandle ConnectorOutputTableHandle) : ConnectorPageSink in class com.facebook.presto.hive.HivePageSinkProvider	From	To
Change Variable Type field : StructField to field : FieldSchema in method public hiveColumnHandles(typeManager TypeManager, connectorId String, table Table, includeSampleWeight boolean) : List<HiveColumnHandle> in class com.facebook.presto.hive.HiveUtil	From	To
Extract Method	1
Extract Method private createPageSink(handle HiveWritableTableHandle, isCreateTable boolean) : ConnectorPageSink extracted from public createPageSink(session ConnectorSession, tableHandle ConnectorOutputTableHandle) : ConnectorPageSink in class com.facebook.presto.hive.HivePageSinkProvider	From	To
Change Attribute Type	1
Change Attribute Type writePath : Path to writePath : Optional<Path> in class com.facebook.presto.hive.HivePageSink	From	To
Rename Parameter	2
Rename Parameter patitionManager : HivePartitionManager to partitionManager : HivePartitionManager in method public HiveMetadata(connectorId HiveConnectorId, metastore HiveMetastore, hdfsEnvironment HdfsEnvironment, partitionManager HivePartitionManager, timeZone DateTimeZone, maxConcurrentFileRenames int, allowDropTable boolean, allowRenameTable boolean, allowAddColumn boolean, allowRenameColumn boolean, allowCorruptWritesForTesting boolean, typeManager TypeManager, partitionUpdateCodec JsonCodec<PartitionUpdate>) in class com.facebook.presto.hive.HiveMetadata	From	To
Rename Parameter insertTableHandle : ConnectorInsertTableHandle to tableHandle : ConnectorInsertTableHandle in method public createPageSink(session ConnectorSession, tableHandle ConnectorInsertTableHandle) : ConnectorPageSink in class com.facebook.presto.hive.HivePageSinkProvider	From	To

5696ac1850a5c6ebba60bc5e7b48fb36cea21e16

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: