presto 58bfad51c928934aa952b9027ddc9764a363a3e0

58bfad51c928934aa952b9027ddc9764a363a3e0

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 8

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method public getMasterSequenceId() : long renamed to public getTotalPagesSent() : long in class com.facebook.presto.execution.SharedBufferInfo	From	To
Rename Method public getPagesAdded() : long renamed to public getTotalQueuedPages() : long in class com.facebook.presto.execution.SharedBufferInfo	From	To
Move And Rename Method	2
Move And Rename Method private getPagesInternal(maxSize DataSize, sequenceId long) : List<Page> from class com.facebook.presto.execution.SharedBuffer to public getPages(maxSize DataSize, sequenceId long) : List<Page> from class com.facebook.presto.execution.PartitionBuffer	From	To
Move And Rename Method private addInternal(page Page) : void from class com.facebook.presto.execution.SharedBuffer to private addToMasterBuffer(page Page) : void from class com.facebook.presto.execution.PartitionBuffer	From	To
Change Parameter Type	3
Change Parameter Type pagesAdded : long to canAddPages : boolean in method public SharedBufferInfo(state BufferState, canAddBuffers boolean, canAddPages boolean, totalBufferedBytes long, totalBufferedPages long, totalQueuedPages long, totalPagesSent long, buffers List<BufferInfo>) in class com.facebook.presto.execution.SharedBufferInfo	From	To
Change Parameter Type masterSequenceId : long to canAddBuffers : boolean in method public SharedBufferInfo(state BufferState, canAddBuffers boolean, canAddPages boolean, totalBufferedBytes long, totalBufferedPages long, totalQueuedPages long, totalPagesSent long, buffers List<BufferInfo>) in class com.facebook.presto.execution.SharedBufferInfo	From	To
Change Parameter Type partitionFunction : PagePartitionFunction to partitionBuffer : PartitionBuffer in method private NamedBuffer(bufferId TaskId, partitionBuffer PartitionBuffer) in class com.facebook.presto.execution.SharedBuffer.NamedBuffer	From	To
Rename Variable	4
Rename Variable other : SharedBufferInfo to that : SharedBufferInfo in method public equals(o Object) : boolean in class com.facebook.presto.execution.SharedBufferInfo	From	To
Rename Variable other : BufferResult to that : BufferResult in method public equals(o Object) : boolean in class com.facebook.presto.execution.BufferResult	From	To
Rename Variable size : int to bufferedPages : int in method public getInfo() : BufferInfo in class com.facebook.presto.execution.SharedBuffer.NamedBuffer	From	To
Rename Variable other : BufferInfo to that : BufferInfo in method public equals(o Object) : boolean in class com.facebook.presto.execution.BufferInfo	From	To
Move Attribute	6
Move Attribute private masterSequenceId : AtomicLong from class com.facebook.presto.execution.SharedBuffer to private masterSequenceId : AtomicLong from class com.facebook.presto.execution.PartitionBuffer	From	To
Move Attribute private queuedPages : BlockingQueue<QueuedPage> from class com.facebook.presto.execution.SharedBuffer to private queuedPages : BlockingQueue<QueuedPage> from class com.facebook.presto.execution.PartitionBuffer	From	To
Move Attribute private bufferedBytes : long from class com.facebook.presto.execution.SharedBuffer to private bufferedBytes : long from class com.facebook.presto.execution.PageBufferInfo	From	To
Move Attribute private masterBuffer : LinkedList<Page> from class com.facebook.presto.execution.SharedBuffer to private masterBuffer : LinkedList<Page> from class com.facebook.presto.execution.PartitionBuffer	From	To
Move Attribute private pagesAdded : AtomicLong from class com.facebook.presto.execution.SharedBuffer to private pagesAdded : AtomicLong from class com.facebook.presto.execution.PartitionBuffer	From	To
Move Attribute private pagesAdded : long from class com.facebook.presto.execution.SharedBufferInfo to private pagesAdded : long from class com.facebook.presto.execution.PageBufferInfo	From	To
Extract Class	3
Extract Class com.facebook.presto.execution.PageBufferInfo from class com.facebook.presto.execution.SharedBuffer	From	To
Extract Class com.facebook.presto.execution.PartitionBuffer from class com.facebook.presto.execution.SharedBuffer	From	To
Extract Class com.facebook.presto.execution.PartitionBuffer from class com.facebook.presto.execution.SharedBufferInfo	From	To
Move Class	1
Move Class com.facebook.presto.execution.SharedBuffer.QueuedPage moved to com.facebook.presto.execution.PartitionBuffer.QueuedPage	From	To
Extract Method	3
Extract Method private enqueuePage(sharedBuffer SharedBuffer, page Page, partition int) : ListenableFuture<?> extracted from private enqueuePage(sharedBuffer SharedBuffer, page Page) : ListenableFuture<?> in class com.facebook.presto.execution.TestSharedBuffer	From	To
Extract Method public enqueue(partition int, page Page) : ListenableFuture<?> extracted from public enqueue(page Page) : ListenableFuture<?> in class com.facebook.presto.execution.SharedBuffer	From	To
Extract Method private addPage(sharedBuffer SharedBuffer, page Page, partition int) : void extracted from private addPage(sharedBuffer SharedBuffer, page Page) : void in class com.facebook.presto.execution.TestSharedBuffer	From	To
Rename Parameter	6
Rename Parameter pagesAdded : long to canAddPages : boolean in method public SharedBufferInfo(state BufferState, canAddBuffers boolean, canAddPages boolean, totalBufferedBytes long, totalBufferedPages long, totalQueuedPages long, totalPagesSent long, buffers List<BufferInfo>) in class com.facebook.presto.execution.SharedBufferInfo	From	To
Rename Parameter masterSequenceId : long to canAddBuffers : boolean in method public SharedBufferInfo(state BufferState, canAddBuffers boolean, canAddPages boolean, totalBufferedBytes long, totalBufferedPages long, totalQueuedPages long, totalPagesSent long, buffers List<BufferInfo>) in class com.facebook.presto.execution.SharedBufferInfo	From	To
Rename Parameter obj : Object to o : Object in method public equals(o Object) : boolean in class com.facebook.presto.execution.BufferResult	From	To
Rename Parameter partitionFunction : PagePartitionFunction to partitionBuffer : PartitionBuffer in method private NamedBuffer(bufferId TaskId, partitionBuffer PartitionBuffer) in class com.facebook.presto.execution.SharedBuffer.NamedBuffer	From	To
Rename Parameter obj : Object to o : Object in method public equals(o Object) : boolean in class com.facebook.presto.execution.BufferInfo	From	To
Rename Parameter obj : Object to o : Object in method public equals(o Object) : boolean in class com.facebook.presto.execution.SharedBufferInfo	From	To

58bfad51c928934aa952b9027ddc9764a363a3e0

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: