596ca8dfe7696dcc52547c0574d863d5ef3183b1
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private compileFilterFunctionInternal(filterExpression RowExpression, leftBlocksSize int) : Class<? extends InternalJoinFilterFunction> renamed to private compileInternalJoinFilterFunction(filterExpression RowExpression, leftBlocksSize int) : Class<? extends InternalJoinFilterFunction> in class com.facebook.presto.sql.gen.JoinFilterFunctionCompiler | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method public HashBuilderOperatorFactory(operatorId int, planNodeId PlanNodeId, types List<Type>, layout Map<Symbol,Integer>, hashChannels List<Integer>, hashChannel Optional<Integer>, outer boolean, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int) in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To | |
| Change Parameter Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method public ParallelHashBuildOperatorFactory(operatorId int, planNodeId PlanNodeId, types List<Type>, layout Map<Symbol,Integer>, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, outer boolean, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int, partitionCount int) in class com.facebook.presto.operator.ParallelHashBuildOperator.ParallelHashBuildOperatorFactory | From | To | |
| Change Parameter Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method public ParallelHashBuildOperator(operatorContext OperatorContext, lookupSourceSupplier PartitionedLookupSourceSupplier, partitionIndex int, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int) in class com.facebook.presto.operator.ParallelHashBuildOperator | From | To | |
| Change Parameter Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method public HashBuilderOperator(operatorContext OperatorContext, lookupSourceSupplier SettableLookupSourceSupplier, hashChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int) in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Rename Variable | 2 | ||
| Rename Variable filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method private buildHash(parallelBuild boolean, taskContext TaskContext, hashChannels List<Integer>, buildPages RowPagesBuilder, filterFunction Optional<InternalJoinFilterFunction>) : LookupSourceSupplier in class com.facebook.presto.operator.TestHashJoinOperator | From | To | |
| Rename Variable filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method private createLookupJoinSource(node JoinNode, buildNode PlanNode, buildSymbols List<Symbol>, buildHashSymbol Optional<Symbol>, probeLayout Map<Symbol,Integer>, context LocalExecutionPlanContext) : LookupSourceSupplier in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Change Return Type | 2 | ||
| Change Return Type InternalJoinFilterFunction to JoinFilterFunctionFactory in method private compileJoinFilterFunction(filterExpression Expression, probeLayout Map<Symbol,Integer>, buildLayout Map<Symbol,Integer>, types Map<Symbol,Type>, session Session) : JoinFilterFunctionFactory in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Change Return Type InternalJoinFilterFunctionFactory to JoinFilterFunctionFactory in method public compileJoinFilterFunction(filter RowExpression, leftBlocksSize int) : JoinFilterFunctionFactory in class com.facebook.presto.sql.gen.JoinFilterFunctionCompiler | From | To | |
| Move Class | 1 | ||
| Move Class com.facebook.presto.sql.gen.JoinCompiler.JoinFilterFunctionFactory moved to com.facebook.presto.sql.gen.JoinFilterFunctionCompiler.JoinFilterFunctionFactory | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To | |
| Rename Attribute filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Rename Attribute filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in class com.facebook.presto.operator.ParallelHashBuildOperator.ParallelHashBuildOperatorFactory | From | To | |
| Rename Attribute filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in class com.facebook.presto.operator.ParallelHashBuildOperator | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method private createLookupJoinSource(node JoinNode, buildNode PlanNode, buildSymbols List<Symbol>, buildHashSymbol Optional<Symbol>, probeLayout Map<Symbol,Integer>, context LocalExecutionPlanContext) : LookupSourceSupplier in class com.facebook.presto.sql.planner.LocalExecutionPlanner.Visitor | From | To | |
| Change Variable Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method private buildHash(parallelBuild boolean, taskContext TaskContext, hashChannels List<Integer>, buildPages RowPagesBuilder, filterFunction Optional<InternalJoinFilterFunction>) : LookupSourceSupplier in class com.facebook.presto.operator.TestHashJoinOperator | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To | |
| Change Attribute Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in class com.facebook.presto.operator.HashBuilderOperator | From | To | |
| Change Attribute Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in class com.facebook.presto.operator.ParallelHashBuildOperator.ParallelHashBuildOperatorFactory | From | To | |
| Change Attribute Type filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in class com.facebook.presto.operator.ParallelHashBuildOperator | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method public ParallelHashBuildOperatorFactory(operatorId int, planNodeId PlanNodeId, types List<Type>, layout Map<Symbol,Integer>, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, outer boolean, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int, partitionCount int) in class com.facebook.presto.operator.ParallelHashBuildOperator.ParallelHashBuildOperatorFactory | From | To | |
| Rename Parameter filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method public HashBuilderOperatorFactory(operatorId int, planNodeId PlanNodeId, types List<Type>, layout Map<Symbol,Integer>, hashChannels List<Integer>, hashChannel Optional<Integer>, outer boolean, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int) in class com.facebook.presto.operator.HashBuilderOperator.HashBuilderOperatorFactory | From | To | |
| Rename Parameter filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method public ParallelHashBuildOperator(operatorContext OperatorContext, lookupSourceSupplier PartitionedLookupSourceSupplier, partitionIndex int, hashChannels List<Integer>, preComputedHashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int) in class com.facebook.presto.operator.ParallelHashBuildOperator | From | To | |
| Rename Parameter filterFunction : Optional<InternalJoinFilterFunction> to filterFunctionFactory : Optional<JoinFilterFunctionFactory> in method public HashBuilderOperator(operatorContext OperatorContext, lookupSourceSupplier SettableLookupSourceSupplier, hashChannels List<Integer>, hashChannel Optional<Integer>, filterFunctionFactory Optional<JoinFilterFunctionFactory>, expectedPositions int) in class com.facebook.presto.operator.HashBuilderOperator | From | To |