5d45fd80e4451c0853f7212b7adfb1e3b8efdcaf
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 1 | ||
Change Parameter Type node : QuerySpecification to node : Select in method private extractNamedOutputExpressions(node Select) : Multimap<QualifiedName,Expression> in class com.facebook.presto.sql.analyzer.StatementAnalyzer.Visitor | From | To | |
Change Return Type | 1 | ||
Change Return Type void to List<FunctionCall> in method private analyzeAggregations(node QuerySpecification, sourceScope Scope, orderByScope Optional<Scope>, groupingSets List<List<Expression>>, columnReferences Set<Expression>, outputExpressions List<Expression>, orderByExpressions List<Expression>) : List<FunctionCall> in class com.facebook.presto.sql.analyzer.StatementAnalyzer.Visitor | From | To | |
Extract Method | 5 | ||
Extract Method private planBuilderFor(relationPlan RelationPlan) : PlanBuilder extracted from private planQueryBody(query Query) : PlanBuilder in class com.facebook.presto.sql.planner.QueryPlanner | From | To | |
Extract Method private legacyVisitQuerySpecification(node QuerySpecification, scope Optional<Scope>) : Scope extracted from protected visitQuerySpecification(node QuerySpecification, scope Optional<Scope>) : Scope in class com.facebook.presto.sql.analyzer.StatementAnalyzer.Visitor | From | To | |
Extract Method private window(subPlan PlanBuilder, windowFunctions List<FunctionCall>) : PlanBuilder extracted from private window(subPlan PlanBuilder, node QuerySpecification) : PlanBuilder in class com.facebook.presto.sql.planner.QueryPlanner | From | To | |
Extract Method private analyzeWindowFunctions(node QuerySpecification, expressions List<Expression>) : List<FunctionCall> extracted from private analyzeWindowFunctions(node QuerySpecification, outputExpressions List<Expression>, orderByExpressions List<Expression>) : void in class com.facebook.presto.sql.analyzer.StatementAnalyzer.Visitor | From | To | |
Extract Method private planBuilderFor(relationPlan RelationPlan) : PlanBuilder extracted from private planFrom(node QuerySpecification) : PlanBuilder in class com.facebook.presto.sql.planner.QueryPlanner | From | To | |
Rename Parameter | 3 | ||
Rename Parameter scope : Scope to sourceScope : Scope in method private analyzeAggregations(node QuerySpecification, sourceScope Scope, orderByScope Optional<Scope>, groupingSets List<List<Expression>>, columnReferences Set<Expression>, outputExpressions List<Expression>, orderByExpressions List<Expression>) : List<FunctionCall> in class com.facebook.presto.sql.analyzer.StatementAnalyzer.Visitor | From | To | |
Rename Parameter scope : Scope to orderByScope : Scope in method private analyzeOrderBy(node Query, orderByScope Scope) : void in class com.facebook.presto.sql.analyzer.StatementAnalyzer.Visitor | From | To | |
Rename Parameter outputExpressions : List<Expression> to expressions : List<Expression> in method private analyzeWindowFunctions(node QuerySpecification, expressions List<Expression>) : List<FunctionCall> in class com.facebook.presto.sql.analyzer.StatementAnalyzer.Visitor | From | To |