615d8bdfc40bab81d521850055ebf873ab4a77d2
Files Diff
- Added: 14
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type expectedRows : int to expectedSchemas : List<List<String>> in method private assertGetSchemasResult(rs ResultSet, expectedSchemas List<List<String>>) : void in class com.facebook.presto.jdbc.TestDriver | From | To | |
| Inline Method | 1 | ||
| Inline Method private assertRowCount(rs ResultSet, expected int) : void inlined to private assertGetSchemasResult(rs ResultSet, expectedSchemas List<List<String>>) : void in class com.facebook.presto.jdbc.TestDriver | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable query : StringBuilder to out : StringBuilder in method private buildFilters(out StringBuilder, filters List<String>) : void in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method | 12 | ||
| Extract Method private optionalStringLikeFilter(filters List<String>, columnName String, value String) : void extracted from public getTables(catalog String, schemaPattern String, tableNamePattern String, types String[]) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private buildFilters(out StringBuilder, filters List<String>) : void extracted from public getSchemas(catalog String, schemaPattern String) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private buildFilters(out StringBuilder, filters List<String>) : void extracted from public getTables(catalog String, schemaPattern String, tableNamePattern String, types String[]) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private optionalStringLikeFilter(filters List<String>, columnName String, value String) : void extracted from public getColumns(catalog String, schemaPattern String, tableNamePattern String, columnNamePattern String) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private buildFilters(out StringBuilder, filters List<String>) : void extracted from public getColumns(catalog String, schemaPattern String, tableNamePattern String, columnNamePattern String) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private emptyStringLikeFilter(filters List<String>, columnName String, value String) : void extracted from public getTables(catalog String, schemaPattern String, tableNamePattern String, types String[]) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private emptyStringEqualsFilter(filters List<String>, columnName String, value String) : void extracted from public getSchemas(catalog String, schemaPattern String) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private emptyStringLikeFilter(filters List<String>, columnName String, value String) : void extracted from public getColumns(catalog String, schemaPattern String, tableNamePattern String, columnNamePattern String) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private optionalStringInFilter(filters List<String>, columnName String, values String[]) : void extracted from public getTables(catalog String, schemaPattern String, tableNamePattern String, types String[]) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private emptyStringEqualsFilter(filters List<String>, columnName String, value String) : void extracted from public getColumns(catalog String, schemaPattern String, tableNamePattern String, columnNamePattern String) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private emptyStringEqualsFilter(filters List<String>, columnName String, value String) : void extracted from public getTables(catalog String, schemaPattern String, tableNamePattern String, types String[]) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Extract Method private optionalStringLikeFilter(filters List<String>, columnName String, value String) : void extracted from public getSchemas(catalog String, schemaPattern String) : ResultSet in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Rename Parameter | 7 | ||
| Rename Parameter expectedRows : int to expectedSchemas : List<List<String>> in method private assertGetSchemasResult(rs ResultSet, expectedSchemas List<List<String>>) : void in class com.facebook.presto.jdbc.TestDriver | From | To | |
| Rename Parameter schemaPattern : String to value : String in method private emptyStringLikeFilter(filters List<String>, columnName String, value String) : void in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Rename Parameter catalog : String to value : String in method private emptyStringEqualsFilter(filters List<String>, columnName String, value String) : void in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Rename Parameter tableNamePattern : String to value : String in method private optionalStringLikeFilter(filters List<String>, columnName String, value String) : void in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To | |
| Rename Parameter schemaPattern : String to value : String in method private optionalStringLikeFilter(filters List<String>, columnName String, value String) : void in class com.facebook.presto.jdbc.PrestoDatabaseMetaData | From | To |