62a8af4b374a36399437f36dfcd0a86244ea4bc5
Files Diff
- Added: 4
- Removed: 2
- Renamed: 0
- Modified: 21
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Added | |
| com.squareup.okhttp3:mockwebserver:3.8.1 | |
| com.squareup.okhttp3:okhttp:3.8.1 | |
| Updated | |
| From ch.qos.logback:logback-core 1.1.3 To 1.0.13 | |
| From ch.qos.logback:logback-core 1.0.13 To 1.1.3 | |
| From ch.qos.logback:logback-classic 1.1.3 To 1.0.13 | |
| From ch.qos.logback:logback-classic 1.0.13 To 1.1.3 |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [httpClient : HttpClient, queryResultsCodec : JsonCodec<QueryResults>] to okHttpClient : OkHttpClient in class com.facebook.presto.benchmark.driver.BenchmarkQueryRunner | From | To | |
| Move And Inline Method | 2 | ||
| Move And Inline Method public create(session ClientSession, socksProxy Optional<HostAndPort>, keystorePath Optional<String>, keystorePassword Optional<String>, truststorePath Optional<String>, truststorePassword Optional<String>, user Optional<String>, password Optional<String>, kerberosPrincipal Optional<String>, kerberosRemoteServiceName Optional<String>, authenticationEnabled boolean, kerberosConfig KerberosConfig) : QueryRunner moved from class com.facebook.presto.cli.QueryRunner to class com.facebook.presto.cli.TestTableNameCompleter & inlined to public testAutoCompleteWithoutSchema() : void | From | To | |
| Move And Inline Method public create(session ClientSession, socksProxy Optional<HostAndPort>, keystorePath Optional<String>, keystorePassword Optional<String>, truststorePath Optional<String>, truststorePassword Optional<String>, user Optional<String>, password Optional<String>, kerberosPrincipal Optional<String>, kerberosRemoteServiceName Optional<String>, authenticationEnabled boolean, kerberosConfig KerberosConfig) : QueryRunner moved from class com.facebook.presto.cli.QueryRunner to class com.facebook.presto.cli.Console & inlined to public run() : void | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type httpClient : HttpClient to httpClient : OkHttpClient in method public StatementClient(httpClient OkHttpClient, session ClientSession, query String) in class com.facebook.presto.client.StatementClient | From | To | |
| Rename Variable | 3 | ||
| Rename Variable uri : String to url : String in method private createConnection() : Connection in class com.facebook.presto.jdbc.TestProgressMonitor | From | To | |
| Rename Variable uri : URI to url : HttpUrl in method public getServerInfo(server URI) : ServerInfo in class com.facebook.presto.jdbc.QueryExecutor | From | To | |
| Rename Variable serverInfo : ServerInfo to expected : ServerInfo in method public testGetServerInfo() : void in class com.facebook.presto.jdbc.TestQueryExecutor | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private QUERY_RESULTS_CODEC : JsonCodec<QueryResults> from class com.facebook.presto.tests.AbstractTestingPrestoClient to private QUERY_RESULTS_CODEC : JsonCodec<QueryResults> from class com.facebook.presto.client.StatementClient | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type uri : URI to url : HttpUrl in method public getServerInfo(server URI) : ServerInfo in class com.facebook.presto.jdbc.QueryExecutor | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type httpClient : HttpClient to httpClient : OkHttpClient in class com.facebook.presto.jdbc.QueryExecutor | From | To | |
| Change Attribute Type httpClient : HttpClient to httpClient : OkHttpClient in class com.facebook.presto.cli.QueryRunner | From | To | |
| Change Attribute Type httpClient : HttpClient to httpClient : OkHttpClient in class com.facebook.presto.tests.AbstractTestingPrestoClient | From | To | |
| Change Attribute Type httpClient : HttpClient to httpClient : OkHttpClient in class com.facebook.presto.client.StatementClient | From | To |