presto 637a1b650f4149d83df93ccf9a40db44e420e425

637a1b650f4149d83df93ccf9a40db44e420e425

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 12

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Merge Attribute	1
Merge Attribute [shardUuids : Set<UUID>, bucketNumber : OptionalInt] to shardUuid : UUID in class com.facebook.presto.raptor.metadata.ShardNodes	From	To
Change Parameter Type	3
Change Parameter Type shard : ShardNodes to bucketShards : BucketShards in method private createSplit(bucketShards BucketShards) : ConnectorSplit in class com.facebook.presto.raptor.RaptorSplitManager.RaptorSplitSource	From	To
Change Parameter Type shardManager : ShardManager to nodeSupplier : NodeSupplier in method public RaptorNodePartitioningProvider(nodeSupplier NodeSupplier) in class com.facebook.presto.raptor.RaptorNodePartitioningProvider	From	To
Change Parameter Type addresses : List<HostAddress> to address : HostAddress in method public RaptorSplit(connectorId String, shardUuids Set<UUID>, bucketNumber int, address HostAddress, effectivePredicate TupleDomain<RaptorColumnHandle>, transactionId OptionalLong) in class com.facebook.presto.raptor.RaptorSplit	From	To
Move Method	1
Move Method public getBucketNumber() : OptionalInt from class com.facebook.presto.raptor.metadata.ShardNodes to public getBucketNumber() : OptionalInt from class com.facebook.presto.raptor.metadata.BucketShards	From	To
Rename Variable	5
Rename Variable identifier : String to bucketNode : BucketNode in method public getBucketAssignments(distributionId long) : Map<Integer,String> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Rename Variable distribution : ImmutableMap.Builder<Integer,Node> to assignments : ImmutableMap.Builder<Integer,String> in method public getBucketAssignments(distributionId long) : Map<Integer,String> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Rename Variable shardBuilder : ImmutableSet.Builder<UUID> to shards : ImmutableSet.Builder<ShardNodes> in method private computeMerged() : BucketShards in class com.facebook.presto.raptor.metadata.ShardIterator	From	To
Rename Variable nodes : List<Node> to list : List<T> in method private cyclingShuffledIterator(collection Collection<T>) : Iterator<T> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Rename Variable node : Node to nodeId : String in method public getBucketAssignments(distributionId long) : Map<Integer,String> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Change Return Type	7
Change Return Type Map<Integer,Node> to Map<Integer,String> in method public getBucketAssignments(distributionId long) : Map<Integer,String> in class com.facebook.presto.raptor.metadata.ShardManager	From	To
Change Return Type ShardNodes to BucketShards in method private computeMerged() : BucketShards in class com.facebook.presto.raptor.metadata.ShardIterator	From	To
Change Return Type ResultIterator<ShardNodes> to ResultIterator<BucketShards> in method public getShardNodes(tableId long, bucketed boolean, merged boolean, effectivePredicate TupleDomain<RaptorColumnHandle>) : ResultIterator<BucketShards> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Change Return Type ShardNodes to BucketShards in method protected computeNext() : BucketShards in class com.facebook.presto.raptor.metadata.ShardIterator	From	To
Change Return Type ShardNodes to BucketShards in method private compute() : BucketShards in class com.facebook.presto.raptor.metadata.ShardIterator	From	To
Change Return Type Map<Integer,Node> to Map<Integer,String> in method public getBucketAssignments(distributionId long) : Map<Integer,String> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Change Return Type ResultIterator<ShardNodes> to ResultIterator<BucketShards> in method public getShardNodes(tableId long, bucketed boolean, merged boolean, effectivePredicate TupleDomain<RaptorColumnHandle>) : ResultIterator<BucketShards> in class com.facebook.presto.raptor.metadata.ShardManager	From	To
Move Attribute	1
Move Attribute private bucketNumber : OptionalInt from class com.facebook.presto.raptor.metadata.ShardNodes to private bucketNumber : OptionalInt from class com.facebook.presto.raptor.metadata.BucketShards	From	To
Rename Attribute	1
Rename Attribute shardManager : ShardManager to nodeSupplier : NodeSupplier in class com.facebook.presto.raptor.RaptorNodePartitioningProvider	From	To
Change Variable Type	10
Change Variable Type iterator : ResultIterator<ShardNodes> to iterator : ResultIterator<BucketShards> in method private getShardNodes(tableId long, predicate TupleDomain<RaptorColumnHandle>) : Set<ShardNodes> in class com.facebook.presto.raptor.metadata.TestDatabaseShardManager	From	To
Change Variable Type shardBuilder : ImmutableSet.Builder<UUID> to shards : ImmutableSet.Builder<ShardNodes> in method private computeMerged() : BucketShards in class com.facebook.presto.raptor.metadata.ShardIterator	From	To
Change Variable Type iterator : ResultIterator<ShardNodes> to iterator : ResultIterator<BucketShards> in method public testEmptyTable() : void in class com.facebook.presto.raptor.metadata.TestDatabaseShardManager	From	To
Change Variable Type node : Node to nodeId : String in method public getBucketAssignments(distributionId long) : Map<Integer,String> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Change Variable Type nodeIds : Collection<String> to nodeIds : Set<String> in method private createSplit(bucketShards BucketShards) : ConnectorSplit in class com.facebook.presto.raptor.RaptorSplitManager.RaptorSplitSource	From	To
Change Variable Type shardNodes : Set<ShardNodes> to shardNodes : Set<BucketShards> in method public testReplaceShardUuids() : void in class com.facebook.presto.raptor.metadata.TestDatabaseShardManager	From	To
Change Variable Type iterator : ResultIterator<ShardNodes> to iterator : ResultIterator<BucketShards> in method public testEmptyTableBucketed() : void in class com.facebook.presto.raptor.metadata.TestDatabaseShardManager	From	To
Change Variable Type nodes : List<Node> to list : List<T> in method private cyclingShuffledIterator(collection Collection<T>) : Iterator<T> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Change Variable Type identifier : String to bucketNode : BucketNode in method public getBucketAssignments(distributionId long) : Map<Integer,String> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Change Variable Type distribution : ImmutableMap.Builder<Integer,Node> to assignments : ImmutableMap.Builder<Integer,String> in method public getBucketAssignments(distributionId long) : Map<Integer,String> in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Inline Variable	1
Inline Variable nodeIdBytes : byte[] in method private computeMerged() : ShardNodes from class com.facebook.presto.raptor.metadata.ShardIterator	From	To
Change Attribute Type	2
Change Attribute Type shardManager : ShardManager to nodeSupplier : NodeSupplier in class com.facebook.presto.raptor.RaptorNodePartitioningProvider	From	To
Change Attribute Type iterator : ResultIterator<ShardNodes> to iterator : ResultIterator<BucketShards> in class com.facebook.presto.raptor.RaptorSplitManager.RaptorSplitSource	From	To
Extract Method	3
Extract Method private getNodeIdentifiers() : Set<String> extracted from public createBuckets(distributionId long, bucketCount int) : void in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Extract Method private getPartitioningHandle(distributionId long) : RaptorPartitioningHandle extracted from private getTableLayout(handle RaptorTableHandle, constraint TupleDomain<ColumnHandle>) : ConnectorTableLayout in class com.facebook.presto.raptor.RaptorMetadata	From	To
Extract Method private cyclingShuffledIterator(collection Collection<T>) : Iterator<T> extracted from public createBuckets(distributionId long, bucketCount int) : void in class com.facebook.presto.raptor.metadata.DatabaseShardManager	From	To
Rename Parameter	3
Rename Parameter shard : ShardNodes to bucketShards : BucketShards in method private createSplit(bucketShards BucketShards) : ConnectorSplit in class com.facebook.presto.raptor.RaptorSplitManager.RaptorSplitSource	From	To
Rename Parameter shardManager : ShardManager to nodeSupplier : NodeSupplier in method public RaptorNodePartitioningProvider(nodeSupplier NodeSupplier) in class com.facebook.presto.raptor.RaptorNodePartitioningProvider	From	To
Rename Parameter addresses : List<HostAddress> to address : HostAddress in method public RaptorSplit(connectorId String, shardUuids Set<UUID>, bucketNumber int, address HostAddress, effectivePredicate TupleDomain<RaptorColumnHandle>, transactionId OptionalLong) in class com.facebook.presto.raptor.RaptorSplit	From	To

637a1b650f4149d83df93ccf9a40db44e420e425

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: